Received: by 10.223.185.116 with SMTP id b49csp1167579wrg; Wed, 21 Feb 2018 13:21:05 -0800 (PST) X-Google-Smtp-Source: AH8x224ZI9Unj+i0SoS8wsz2t6HiDmPgQbIbgL//ANZP8wMAtWpK6giBdX6Api1m6M/oUsK6Neng X-Received: by 10.101.101.84 with SMTP id a20mr3793247pgw.163.1519248065033; Wed, 21 Feb 2018 13:21:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519248064; cv=none; d=google.com; s=arc-20160816; b=kD+NqnASSbnHI8yAW7sRsluNr2WdqIlJXCJh7mlhyoCAg5BorTvLfOZg0tNU0qEc72 zI4GpbTDM/4In/gq+njUbON92guZwl8uPustuvSVhlP7rhv4yCQXZ/Wi8L7yAKq2GrY/ MDO/mvIf8Fe4I/ytII+HzI2heK3ItP2gsw/VAPyFIBJvEOu4idEIUQsCdqUHE8dcT63O C8pLo93NwhGpRbDgTF7Z658ulyPof1SyxptSud7xvS7Mqnd5PJlbgENW/6Ehd4t5/X3f nXnwMCrpZva/JqcwQCWH/vYcqgdxZgmnNZGDCmYdRBGJS30Y//M4b5riEalAODfIPhMP 7GOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=G5sh78afo258XEhnOgQ2r2mhmZJxuzzjwEWMVGe8Rhk=; b=k74pGcvTSbr3ayiuOxrNB9QmhZqYB/zCkFFJ2Qym4ivpAGKy1NUXl0omybrtjxMw8O LEECcSKVJAXiyJz54mqwHpW0fVwqH2DGlWk08le9h0tUGXcBnlT7riuLxgX7PbORdlav nXLVBuaA2moRAY9IXrRyB6nYwIQEwMDYwglQ00ACjy0RvSiCKfYFs+zDSxcqN9l8iOur 1fTXa4+89e2zrTBeNd+D81rmWNWkPbQO85praj3L0PQNnZuV5VYrsIddHcZ50Skjyo/7 ZV7lmnmCCUN8TFqTSxOleJ0TLFWVJ7Fp3opZnkPl8jUHRcBMlmrQ5n+kSIlZfqNT+O3U L1tA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o11si188170pgp.757.2018.02.21.13.20.50; Wed, 21 Feb 2018 13:21:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751952AbeBUVTt (ORCPT + 99 others); Wed, 21 Feb 2018 16:19:49 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:46952 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751535AbeBUU5X (ORCPT ); Wed, 21 Feb 2018 15:57:23 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id 58B25207FF; Wed, 21 Feb 2018 21:57:21 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id 78F5C20804; Wed, 21 Feb 2018 21:56:56 +0100 (CET) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 020/100] rtc: ds1305: stop validating rtc_time in .read_time Date: Wed, 21 Feb 2018 21:55:15 +0100 Message-Id: <20180221205635.31314-21-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com> References: <20180221205635.31314-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ds1305.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ds1305.c b/drivers/rtc/rtc-ds1305.c index 3d2400a39da9..2d502fc85698 100644 --- a/drivers/rtc/rtc-ds1305.c +++ b/drivers/rtc/rtc-ds1305.c @@ -203,8 +203,7 @@ static int ds1305_get_time(struct device *dev, struct rtc_time *time) time->tm_hour, time->tm_mday, time->tm_mon, time->tm_year, time->tm_wday); - /* Time may not be set */ - return rtc_valid_tm(time); + return 0; } static int ds1305_set_time(struct device *dev, struct rtc_time *time) -- 2.16.1