Received: by 10.223.185.116 with SMTP id b49csp1167622wrg; Wed, 21 Feb 2018 13:21:07 -0800 (PST) X-Google-Smtp-Source: AH8x225TRmiqDJ+L1Un4FViCOGoaJ+f58uZePYqg1sWxP3qlhafztLts6ZLp3hmaDiwVi0Tyu30M X-Received: by 2002:a17:902:584c:: with SMTP id f12-v6mr4343515plj.374.1519248067336; Wed, 21 Feb 2018 13:21:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519248067; cv=none; d=google.com; s=arc-20160816; b=WPzfyw8IouyirB+9BliFquI+Pr1QqdmnVaQuixvM95yxy0deOuTO47s+n6MuyMCxxW ntHzXY/tHu7tD6ByDIkYz48FHnYptC3kz4D9dPK+CJkyMA3AxIeCAe5HeTZfmahLNDCQ NutzkIVuZmC1AnhPasM/5PsrpXvdKzU5VwikwfH3wVP2rVHz+U4LGskJ6Bm8M7O3M/I5 FagflkDqZ2pE3ggYjxnnh8BJjyLIvVMI5aL+GMfzWZkkbLZVj1BPuggF2pc052Rr8gbk Ny9yMAhbwQhJ5DPxLdyS1CWiAhYtcfsTQf7hE0WIgK6uoQnlP/iRSoXcvEp0+LmmUHrj HFbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=PWsf0H3Dx7WGLS91m/1hucWgMEkb5WvipEZ1t1HUE7k=; b=l6mSACAQP5nppMrCbF0kTVTlcddDI+mDJFmY02rsVvNizu26OgIcBMklwUw+JXNPOF pU6OAza1iIaFuc+Fx5qMT1vwTi0/x+B0sQCQppbI/Fia/HqScK7Sc/m9yW7p0+C/62Qy RwDNfu5rUpaiG61OWLX/hT8SQxEvxuYVeAEi1yUoudSFCI/gabf1AvjzQLCqvVk90Fqx DQJx7y/AFEzTWIPJLFlfEhFUlmfG5VGY0ipP9Ke5VYbYbzCsJz/iUTMdeNApaaKO8ntB Y7uUY9Y42AS/56V8UJzHABqcfxJ/L8gk/Q+CfX4sMJexvRAGQZ6l0GdmoJHkrVeLfP4p 0AZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k6si8444409pgo.818.2018.02.21.13.20.52; Wed, 21 Feb 2018 13:21:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751691AbeBUVUR (ORCPT + 99 others); Wed, 21 Feb 2018 16:20:17 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:46954 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751537AbeBUU5X (ORCPT ); Wed, 21 Feb 2018 15:57:23 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id 6505320804; Wed, 21 Feb 2018 21:57:21 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id BE2ED20807; Wed, 21 Feb 2018 21:56:56 +0100 (CET) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 021/100] rtc: ds1307: stop validating rtc_time in .read_time Date: Wed, 21 Feb 2018 21:55:16 +0100 Message-Id: <20180221205635.31314-22-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com> References: <20180221205635.31314-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ds1307.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index 4021d478b9f3..a13e59edff53 100644 --- a/drivers/rtc/rtc-ds1307.c +++ b/drivers/rtc/rtc-ds1307.c @@ -437,8 +437,7 @@ static int ds1307_get_time(struct device *dev, struct rtc_time *t) t->tm_hour, t->tm_mday, t->tm_mon, t->tm_year, t->tm_wday); - /* initial clock setting can be undefined */ - return rtc_valid_tm(t); + return 0; } static int ds1307_set_time(struct device *dev, struct rtc_time *t) -- 2.16.1