Received: by 10.223.185.116 with SMTP id b49csp1168650wrg; Wed, 21 Feb 2018 13:22:20 -0800 (PST) X-Google-Smtp-Source: AH8x2244gt5HHOWnHidhlYdmD+GhOeejgwv/ADjZPZvEruzqhRFVUCR79r8na8dCXzMWOUFDi9/S X-Received: by 10.98.56.150 with SMTP id f144mr4593904pfa.150.1519248140418; Wed, 21 Feb 2018 13:22:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519248140; cv=none; d=google.com; s=arc-20160816; b=mHs2Znonx+wBkEVdb8KOYUGMpNgfx6XRMWKZlwmCj1iWJnH/R5RgT6pn2c+16Qs/UC 3l+6dJmNJUQw8ZHFLmbIIcYJltyZb9PRftmR/ey40wZNwMbbWAc9amCdNkPy+61eyFHl hsW2ERwZ+C/tGAzY5qxZDIzVIV5lLyCukj4tlWpE0tdT1RJqmJDjplwTNpZsTsMmYIPl mNjOUaBcUn+YE0ah2CP/KFYF/+AXs1M+3vUTb8P/BNGHy0y36wlomfWuo5edoiElVKn7 580IdGTpYL85VjIyiM99QjZUW1AMRLWSYgtGukWUgxxyfHCo7h2pB45DHrB5rhC9aa6h LF/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=CkGWyjrU/4SOrXMd9Ap3lIbe30Ipv0jcAQepMEukPi0=; b=zwefoHHU2UCA29uWUlk7gnXXJK3coO92rOlFosx2CjdXQ+IxtGffjSP9OVEOF1dnHu WiEbDbOCodYqpUWqYelygiSJ7Ydd69ct9Lc/AupRsSs9FjtM6Rzv0tcj99+i3KRLHcX+ KsLpjyOrqTVGd5opdV+sw5901YJVtBxYg8VrbU40cnXExhKS/Ih6KDytAQnv9njpguUB dx0sy1qzVCOa5RSSFPYGbyt4fAbLJp1NacKCtakWf6TgIixRnIqT4ESxIvMo8ooypELG 1U8jHHrBkWmSRTlzXIHgJGbC9YxQIo+Z9DUemvFLbpmgx93rO2x0+PsadsjTM4fIeplO xYbg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a3-v6si3394623plm.119.2018.02.21.13.22.06; Wed, 21 Feb 2018 13:22:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751453AbeBUU5P (ORCPT + 99 others); Wed, 21 Feb 2018 15:57:15 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:46939 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751420AbeBUU5O (ORCPT ); Wed, 21 Feb 2018 15:57:14 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id E152E207F5; Wed, 21 Feb 2018 21:57:11 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id 12F3E207F6; Wed, 21 Feb 2018 21:56:54 +0100 (CET) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 012/100] rtc: coh901331: stop validating rtc_time in .read_time Date: Wed, 21 Feb 2018 21:55:07 +0100 Message-Id: <20180221205635.31314-13-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com> References: <20180221205635.31314-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org rtc_time_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-coh901331.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-coh901331.c b/drivers/rtc/rtc-coh901331.c index cfc4141d99cd..2fc517498a5d 100644 --- a/drivers/rtc/rtc-coh901331.c +++ b/drivers/rtc/rtc-coh901331.c @@ -82,7 +82,7 @@ static int coh901331_read_time(struct device *dev, struct rtc_time *tm) if (readl(rtap->virtbase + COH901331_VALID)) { rtc_time_to_tm(readl(rtap->virtbase + COH901331_CUR_TIME), tm); clk_disable(rtap->clk); - return rtc_valid_tm(tm); + return 0; } clk_disable(rtap->clk); return -EINVAL; -- 2.16.1