Received: by 10.223.185.116 with SMTP id b49csp1169516wrg; Wed, 21 Feb 2018 13:23:26 -0800 (PST) X-Google-Smtp-Source: AH8x224+Sk9qM/MSD59EL6aSeiYoyfzckJe71i3Hfub7uWEA6e6jF7kfHtpnBiLJK8Iu2sceMx7U X-Received: by 10.101.86.73 with SMTP id m9mr3843815pgs.70.1519248206762; Wed, 21 Feb 2018 13:23:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519248206; cv=none; d=google.com; s=arc-20160816; b=SK9H4Jj0rGHYJLfkBMsH8m7T9XfnqZBNmEaYtbNRnLLnghs+6LojSUwsk5byalyFla fMEG3w8lJD0ABPzfzFwLuKNE7sLOSHtoDvGbnUku8K9oBUWPFPomInUiO4UA1tKomo30 zfv1wawpxTp1i5HzmrYMp+xpdzjdOe/dtaCF1oYCGzG+8RYS7mExxTuB3lJRguKbc91V mUI/EliHurRcTxgqF7jOezcRfdR07j49t8QnSG9xW/CKujLJJJBD4C1PNJc06YraIruz LwZuShQfT0Typkfq5t6jniAMxrryCwPHjT+XBPrevQMkRU78B1OPb4hus/qbaX3w6qxk oV2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=6n4WQvGb71Wjny5TgylRludji8GghkY61aHEuxF/rWM=; b=LTcg/t8Z57EKK1OGUXw212ZkF9yd7gjF68kzxoyL6f+CHyctYJnyt69GiwQRLkyqT1 HNQ6JjEHNZ+wkWIq6D+Up9KSIjm3319pNEkEpU1ELV/NWXwjRXG2AT103cp4Nx+vP+Vd KkXkekJRuNdPP97Rywwg89aKqKV5girGZcWi3vdDXEngxS5vJYKupl/x4Ko6fOrDUhOv WFzO3px7H/mIkPQzSz5KqwoNuSMpCKk3d86XbCaXIkX7ZbBhq2W3Wo2H2IsupEOLFBqw kj/sD+prYojQVDs8lbyqHL4J1TUup6H2RoR5vb80mgms2Hgy42rP/kdHFlYIXzMItVRA ejoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o5-v6si7823643plh.135.2018.02.21.13.23.12; Wed, 21 Feb 2018 13:23:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751413AbeBUU5N (ORCPT + 99 others); Wed, 21 Feb 2018 15:57:13 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:46903 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbeBUU5E (ORCPT ); Wed, 21 Feb 2018 15:57:04 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id 6540920836; Wed, 21 Feb 2018 21:57:02 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id 28F06207E2; Wed, 21 Feb 2018 21:56:52 +0100 (CET) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 005/100] rtc: stk17ta8: let the core handle invalid time Date: Wed, 21 Feb 2018 21:55:00 +0100 Message-Id: <20180221205635.31314-6-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com> References: <20180221205635.31314-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Returning a valid time when the time is invalid is a bad practice, because then userspace is not able to react on the information. Also, it doesn't make sense to return epoch because it is already the default time. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-stk17ta8.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/rtc/rtc-stk17ta8.c b/drivers/rtc/rtc-stk17ta8.c index b670e44306a8..c66ec6ae233c 100644 --- a/drivers/rtc/rtc-stk17ta8.c +++ b/drivers/rtc/rtc-stk17ta8.c @@ -129,10 +129,6 @@ static int stk17ta8_rtc_read_time(struct device *dev, struct rtc_time *tm) /* year is 1900 + tm->tm_year */ tm->tm_year = bcd2bin(year) + bcd2bin(century) * 100 - 1900; - if (rtc_valid_tm(tm) < 0) { - dev_err(dev, "retrieved date/time is not valid.\n"); - rtc_time_to_tm(0, tm); - } return 0; } -- 2.16.1