Received: by 10.223.185.116 with SMTP id b49csp1170256wrg; Wed, 21 Feb 2018 13:24:26 -0800 (PST) X-Google-Smtp-Source: AH8x225b9YPlARcXJr6EngDo0jBmBA7qTdQXyniu3ZPxuSLQM/BR1kgHIpQ3rrwNa5A84kt94koq X-Received: by 2002:a17:902:4222:: with SMTP id g31-v6mr4214176pld.335.1519248266087; Wed, 21 Feb 2018 13:24:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519248266; cv=none; d=google.com; s=arc-20160816; b=ZY+MZXoi9fL2a/FIwSd8tQ+b9G28WjGPR5yyA4FWCL3YGnuQ6dVpt31s1b2guzc55G bB/EVideLLPl33ngu+9130rtEQzgPFLHkZtzz1klDONPXA1VTvxc4vmb7wNervRep7yU 5v1sMejfO0ESAJ8rM3DhsrlE20lLJ3RF7iQX5MfDXdqf0qx8WUHz37bd8HT17BwY2k4V NvJfzkQtWWH+jVA9nfNJFUwNmE5OEUZgxU+Idt6oefk36DoEifKH/q4BQhiiPgF9R17+ BqkzW3/MyDSRkn3bluF43bHmXN0bErzhinUKqGfP2kb8bLJLb17xaGYO7WRHgxuunxJ/ 8qfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=XgFUU8qDPASTYTAT930ZSJ+Qxe44p+1q5l2hYUE3XIw=; b=ejthif32MeiBP2A3ymHnRPREQtaxJTWG8mhBZLXEvuki9zIGx0SFweSxOv3AvnmR4E oerqJtzlamOdumh+QVUaPBfKXTQg9/hN/pkrV6PowFNsTo5gyx9h+H08TmIm/4Nd/JZS W4Gi4BEuYoLhNCjwA9qYxobGfj+q0KLEYRTxv/zN4FtVFb+tvV0KBq2an8O9VQCtvo+2 UpaWxH6CvpzgL2FugGiKJP2GqzgVRFky+onPlJp8aVSeuskeo1xjsZiWdyf2nBXS4wTd nHAfcvwUrW1KT3RIQUCqDdapjFOcpQvWn1T70pw+0pLWceVuBvOt7hIqD9fPvi6THBdV 3hPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o7-v6si13405172pll.332.2018.02.21.13.24.11; Wed, 21 Feb 2018 13:24:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751469AbeBUVXO (ORCPT + 99 others); Wed, 21 Feb 2018 16:23:14 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:46905 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbeBUU5M (ORCPT ); Wed, 21 Feb 2018 15:57:12 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id 2757B207E5; Wed, 21 Feb 2018 21:57:11 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id A1F21207EF; Wed, 21 Feb 2018 21:56:52 +0100 (CET) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 007/100] rtc: ab3100: stop validating rtc_time in .read_time Date: Wed, 21 Feb 2018 21:55:02 +0100 Message-Id: <20180221205635.31314-8-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com> References: <20180221205635.31314-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org rtc_time64_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ab3100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-ab3100.c b/drivers/rtc/rtc-ab3100.c index 9b725c553058..821ff52a2222 100644 --- a/drivers/rtc/rtc-ab3100.c +++ b/drivers/rtc/rtc-ab3100.c @@ -106,7 +106,7 @@ static int ab3100_rtc_read_time(struct device *dev, struct rtc_time *tm) rtc_time64_to_tm(time, tm); - return rtc_valid_tm(tm); + return 0; } static int ab3100_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alarm) -- 2.16.1