Received: by 10.223.185.116 with SMTP id b49csp1170507wrg; Wed, 21 Feb 2018 13:24:43 -0800 (PST) X-Google-Smtp-Source: AH8x226RVDJdtThsQrG4Sw6BDgcdpzjEgERZS9utJrRuDNP0aH2Ou26eL5ogh67bjsp070iW/6FK X-Received: by 10.99.120.193 with SMTP id t184mr3853083pgc.348.1519248283355; Wed, 21 Feb 2018 13:24:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519248283; cv=none; d=google.com; s=arc-20160816; b=R/tfMi/KoymZhcw1wwY8/NJrQMyGBke/uBqkqPPCOkI7ee9PLkawnU7IX0+i7QOOx5 LP3ptSlaq32qgCSTyKpafOMOX+oEBeWvXZVCH+79NqyD9MaNxCSRLGS9B6loH+7ay5nX 0gRgwuZhKimFd/okHd2iBrlpxyUsw/934S1kVmGZRrwHOwA1ZDUJ+Dvs8iRl0ItLqGNV JzqvAOMKL2DXYdr5o4TwCAY1Z4dUkTVLpLPLJMv+L93do/sZdxKE1nGlFAQ8yUtQDfTR bqcdlE4cws7THLAok1eUO7QpWjzgem8ftVGuaba1l4EtsXKfec2pKq/XF0pc1jBAriJd 0gFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=CGx0wgar7zdfR8wCooj5p8ODVFkPU10O+b2p/4gEsYg=; b=MYtzf15IxdsVzIycKeQQBYBHy69Y6qTGLn/SYrbfZXlBxyjj3G+Ut4xQ4ZKAH80nz2 jtI6EEKX+ehZdJPiWcwV/hY8XkBGeW6sx8UwPxaU4hJ0QhjeBEZyswRk7UIium/PqDDH mlyux/ThXK6fLTZeOllwFtz5Zp2RliiZ9EjJib9gfwHUgh0jtH+zP057axp11d98ijUO xpGU8u4AUpAeqpaIjuJDWw+RtBiG5Q1RUaio3nP7IFLU1jBSx7Y/DFnWKE/laq5c12Wk wGjn4Fsg/t/UsgFXL6oA8xzp4H8cQliAZZuhw/fIgd5gGYlzpjCaEeBDREb6dLJrwAKz OFug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l6si1774503pgq.562.2018.02.21.13.24.29; Wed, 21 Feb 2018 13:24:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751632AbeBUVXm (ORCPT + 99 others); Wed, 21 Feb 2018 16:23:42 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:46894 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751180AbeBUU5D (ORCPT ); Wed, 21 Feb 2018 15:57:03 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id 7F19520831; Wed, 21 Feb 2018 21:57:01 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id 4636D203A2; Wed, 21 Feb 2018 21:56:51 +0100 (CET) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 002/100] rtc: ds1553: let the core handle invalid time Date: Wed, 21 Feb 2018 21:54:57 +0100 Message-Id: <20180221205635.31314-3-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com> References: <20180221205635.31314-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Returning a valid time when the time is invalid is a bad practice, because then userspace is not able to react on the information. Also, it doesn't make sense to return epoch because it is already the default time. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ds1553.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/rtc/rtc-ds1553.c b/drivers/rtc/rtc-ds1553.c index 7334c824371a..2441b9a2b366 100644 --- a/drivers/rtc/rtc-ds1553.c +++ b/drivers/rtc/rtc-ds1553.c @@ -127,10 +127,6 @@ static int ds1553_rtc_read_time(struct device *dev, struct rtc_time *tm) /* year is 1900 + tm->tm_year */ tm->tm_year = bcd2bin(year) + bcd2bin(century) * 100 - 1900; - if (rtc_valid_tm(tm) < 0) { - dev_err(dev, "retrieved date/time is not valid.\n"); - rtc_time_to_tm(0, tm); - } return 0; } -- 2.16.1