Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180221213334.19969-1-anders.roxell@linaro.org>
References: <20180221213334.19969-1-anders.roxell@linaro.org>
From:   =?UTF-8?Q?Daniel_D=C3=ADaz_Rodr=C3=ADguez?= 
        <daniel.diaz@linaro.org>
Date:   Wed, 21 Feb 2018 15:41:49 -0600
Message-ID: <CAEUSe7-4pyGvDXKECtc_aoikmNERWGvLecuCYXBCAxLO44gwmw@mail.gmail.com>
Subject: Re: [PATCH] tools/gpio/gpio-event-mon: fix warning
To:     Anders Roxell <anders.roxell@linaro.org>
Cc:     linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 21 February 2018 at 15:33, Anders Roxell <anders.roxell@linaro.org> wrot=
e:
> PRIu64 is defined in user space to match libc's uint64_t definition.
> However, gpioevent_data structure in the kernel is defined using the
> kernel's own __u64 type.
>
> gpio-event-mon.c: In function =E2=80=98monitor_device=E2=80=99:
> gpio-event-mon.c:102:19: warning: format =E2=80=98%lu=E2=80=99 expects ar=
gument of type
>     =E2=80=98long unsigned int=E2=80=99, but argument 3 has type =E2=80=
=98__u64 {aka long long
>     unsigned int}=E2=80=99 [-Wformat=3D]
>    fprintf(stdout, "GPIO EVENT %" PRIu64 ": ", event.timestamp);
>                    ^~~~~~~~~~~~~~
>   LD       /tmp/kselftest/gpiogpio-event-mon-in.o
>   LINK     /tmp/kselftest/gpiogpio-event-mon
>
> Fix is to replace PRIu64 with llu, which we know is what the kernel uses
> for __u64.
>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

Tested-by: Daniel D=C3=ADaz <daniel.diaz@linaro.org>


> ---
>  tools/gpio/gpio-event-mon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/gpio/gpio-event-mon.c b/tools/gpio/gpio-event-mon.c
> index dac4d4131d9b..c864544efe05 100644
> --- a/tools/gpio/gpio-event-mon.c
> +++ b/tools/gpio/gpio-event-mon.c
> @@ -99,7 +99,7 @@ int monitor_device(const char *device_name,
>                         ret =3D -EIO;
>                         break;
>                 }
> -               fprintf(stdout, "GPIO EVENT %" PRIu64 ": ", event.timesta=
mp);
> +               fprintf(stdout, "GPIO EVENT %llu: ", event.timestamp);
>                 switch (event.id) {
>                 case GPIOEVENT_EVENT_RISING_EDGE:
>                         fprintf(stdout, "rising edge");
> --
> 2.11.0