Received: by 10.223.185.116 with SMTP id b49csp1594555wrg; Wed, 21 Feb 2018 23:08:48 -0800 (PST) X-Google-Smtp-Source: AH8x226m8s22namFL+ZcV/qZZh6VFEYMXWb/gfoAPXBGkXBP/mfUz0+fjTmklxfRKrzuAY+EDykP X-Received: by 10.99.173.73 with SMTP id y9mr4815006pgo.432.1519283328861; Wed, 21 Feb 2018 23:08:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519283328; cv=none; d=google.com; s=arc-20160816; b=guOXN7aJ9lNgtjITthUIpwDXWilhuxcUMWgNxGLeJrkTRvnNyynXIej3R3ZemQiMyG p4HQqt1Ez217ijlAkaHAmPfK/vgj+bcDe9Ll2BahUNKwgbp4Ln2S67BWHV7I9V3wGK/D NeenY+aJAwezKk9M5SMcCIHMYYE+JqpLjIqRmIszAO8/Xeyb9whOfPaB3zAzOtwFtjSQ 62PbpXYcByUWYtcDrcaLTka179hD4sru73Zu9YVzk6oqlWdiszDdiLJ2tHEJTpaf29Xv hOguFK4mdE87QjC+Fj9Dr8yKX/ArPOl1twlwT7CxeY5wVzfwQWUTFWQy+Gi0YdG8eqj8 SwHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=Ic6Hp7sxx2V+ZNRkuRNTAcmjQud7Bg/KDESE8iYyLu0=; b=Zr4sl86KJQmcHxCnqMbzzg9aDSX5W1UGzXqFBlp+BtWjCJwIWT7BjU1mq3Sx29+eAU l2jq7DQzEIfmlkgb0yK9CJOn6/3o1UPsGog2tjvjE/iG09O4B82FQ+QVoLsefhnL2Hvw 4MUYJ//IR+mukVPYDbbpKVF70pc59kgxvsVKqF7tz/sJr8dWPdSPOjglgVhYpyCoFSah UARDsH5sQz8ujmLqLbr+8Hm9Lf28RFxqw3I/2PG7/0BUKNudwh3kqzGcf/B4L4dpqhWS 6kkhseTakEhMdASoUCzSNd6X4gInP5G9rWwEzuLLsnbHaZ8QYH85u7md9QAnhBr7sdFB FOZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=EIPyRtV1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z5si890986pfb.355.2018.02.21.23.08.34; Wed, 21 Feb 2018 23:08:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=EIPyRtV1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752779AbeBVHGw (ORCPT + 99 others); Thu, 22 Feb 2018 02:06:52 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:55184 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752728AbeBVHGt (ORCPT ); Thu, 22 Feb 2018 02:06:49 -0500 Received: by mail-wm0-f66.google.com with SMTP id z81so1826821wmb.4 for ; Wed, 21 Feb 2018 23:06:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Ic6Hp7sxx2V+ZNRkuRNTAcmjQud7Bg/KDESE8iYyLu0=; b=EIPyRtV10VUSRRxgnyszWDNGg6hSagvdHKVGvBigbi7Kn4R52HyrMat8Mx430HpNGv Ixe8qevHti+b7pg28LJIx9n3DLEZ5QoXtJ33pKue3hYgN0ej9V8piVDorHQK+z4St/+j SnvBnPbrlseUA8Eb/IGd2aoIgD8GMi9KmqDtYrkg6/ehZnhLc1Q/fbvfvNU4ZqQ/1XEP dUqOZbuSNrziSChqlsrJwtIOMEKs4ZZFdQKZk2Ay/kYsnUNfoVEkYxSNa3hMd5gDV3Wb l/2+GzbeARLrP03qj6JzvfbuYIkvXOwG4ufKmy0K+nxE4gL9IWlHX1qtpboy/Txlejd7 KHTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Ic6Hp7sxx2V+ZNRkuRNTAcmjQud7Bg/KDESE8iYyLu0=; b=nxirqWUazAaCZ/F9GYCUNtQVaOFp2y+bvdhazoJM+aM3Jg4/b9SBP81guSEc416zA4 lrszx59CtWPn4Sg4On6lcgMiBCqXXxRlCeozGpKfDhmGMB5K/ypwNqmY9xmKcajd7jWy qPLYf/BfSnxyzi9d5bwVC8r7HIllx0Hs2ue5jrZh8eJKcLhSc3G7SMv0j8qq/IpAuxbI JDZv/rjI8NSbCjwe4oyojY+py6k/Bpl/UiF3Y+4mllhWJtVyPcD5mkTT+i6ZgJG6xoj5 /JuDSH6Il8FtPUPqu1zpScX1R5wnx9yQrO426WmuCBJauoWaUmWsaXJqSRF+fO7HCPQG W7uw== X-Gm-Message-State: APf1xPC9JhOgeIdw09cHnxxhdoEMuZrAccU6PwyPABqfhQGx/+zZoDMJ e7JGaWUme4mrVZ9U1NbD8ZA= X-Received: by 10.80.194.25 with SMTP id n25mr8128746edf.84.1519283208500; Wed, 21 Feb 2018 23:06:48 -0800 (PST) Received: from auth1-smtp.messagingengine.com (auth1-smtp.messagingengine.com. [66.111.4.227]) by smtp.gmail.com with ESMTPSA id f16sm23815643edj.68.2018.02.21.23.06.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Feb 2018 23:06:47 -0800 (PST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 4F3232096E; Thu, 22 Feb 2018 02:06:46 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute7.internal (MEProxy); Thu, 22 Feb 2018 02:06:46 -0500 X-ME-Sender: Received: from localhost (unknown [45.32.128.109]) by mail.messagingengine.com (Postfix) with ESMTPA id C85502460B; Thu, 22 Feb 2018 02:06:45 -0500 (EST) From: Boqun Feng To: linux-kernel@vger.kernel.org Cc: Peter Zijlstra , Ingo Molnar , Andrea Parri , Boqun Feng Subject: [RFC tip/locking/lockdep v5 14/17] Revert "locking/lockdep/selftests: Fix mixed read-write ABBA tests" Date: Thu, 22 Feb 2018 15:09:01 +0800 Message-Id: <20180222070904.548-15-boqun.feng@gmail.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180222070904.548-1-boqun.feng@gmail.com> References: <20180222070904.548-1-boqun.feng@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit d82fed75294229abc9d757f08a4817febae6c4f4. Since we now could handle mixed read-write deadlock detection well, the self tests could be detected as expected, no need to use this work-around. Signed-off-by: Boqun Feng --- lib/locking-selftest.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/lib/locking-selftest.c b/lib/locking-selftest.c index 6b7a28d84fc4..79270288fa28 100644 --- a/lib/locking-selftest.c +++ b/lib/locking-selftest.c @@ -2266,14 +2266,6 @@ void locking_selftest(void) print_testname("mixed read-lock/lock-write ABBA"); pr_cont(" |"); dotest(rlock_ABBA1, FAILURE, LOCKTYPE_RWLOCK); -#ifdef CONFIG_PROVE_LOCKING - /* - * Lockdep does indeed fail here, but there's nothing we can do about - * that now. Don't kill lockdep for it. - */ - unexpected_testcase_failures--; -#endif - pr_cont(" |"); dotest(rwsem_ABBA1, FAILURE, LOCKTYPE_RWSEM); -- 2.16.1