Received: by 10.223.185.116 with SMTP id b49csp1625515wrg; Wed, 21 Feb 2018 23:50:48 -0800 (PST) X-Google-Smtp-Source: AH8x2266jCMq9gJH4AF1VwqDK4wTKGC1sHnA/8keo5s/N3B2jsBl3kZ31cdX84xnCMXaxgFL8E11 X-Received: by 10.98.49.7 with SMTP id x7mr6058153pfx.101.1519285848515; Wed, 21 Feb 2018 23:50:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519285848; cv=none; d=google.com; s=arc-20160816; b=ivmJo85nSo7yYYW1zJSOX8oJxh9MMTkOEWUvc77EAvqAFGY3jg46J4BQXEvEjM3gcf +o9YQWszIjcztNKbNgI8/2tuuNaQcFvj9GSQpVD3TexDqdEOuyc1H5HjezOZ/ATqzOqx bus+dbJZcx9JDw4G8eG1i13CcMdkHLxxzVuF0DRLBpZUGDTfAK9UhXkL4a88HrzVJZq/ E4aHk2LO3hCbQznsQ/oGDVNhWYuI/SZEsmyHkuzV7I8UyN0tJx3S0/svYVM5buRXw3xE CQmdORvlpZ3rYuwdawXgYYFMFjxWK7Qe2RoF7CmYYMnpW9r4bqqAgl1ZfnTqfjWvmUzy ZZvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=BQ9xOmpdx+7MmhmvbBgaPrXlqHbjNItDnJ/z45n11ew=; b=08r5IRcGO8j8fKZJxzIJ7NALNpyZ4veSfuOGVBvVIkqSzcwBkrp7C2m2Xao7NZ9Vil 1yx9EMOcA5sYle9iUFXuP/flLFSfVA9kL16WU+JIaP0pjIr7vpcG3lAJkAizPQtNBbQp v7BZK7XjkEYgvM7qlnsOLtjme8agL7SKMxiw1+0toehgK0gSvqWrKvuONdJFEXa5eEdU gzVTdAwarQYZJIX9YVeyGjyqvN/S2safv6ApBDOBqnSxFBR+D4WGq0I9XxebowTjDwXk XKZ3ZXFXHY3dSDPtaP7e9qdG2TNM3LpXmsd2gzNy8TtpYleQFvzazC9rwGdaIYdHsYyr H46w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=GKO9FhVq; dkim=pass header.i=@codeaurora.org header.s=default header.b=jcrK8R3/; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l64si2405767pfi.388.2018.02.21.23.50.34; Wed, 21 Feb 2018 23:50:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=GKO9FhVq; dkim=pass header.i=@codeaurora.org header.s=default header.b=jcrK8R3/; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752803AbeBVHqi (ORCPT + 99 others); Thu, 22 Feb 2018 02:46:38 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:37990 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752754AbeBVHqf (ORCPT ); Thu, 22 Feb 2018 02:46:35 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 82A80607CF; Thu, 22 Feb 2018 07:46:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1519285594; bh=AsvJ+SOFQRslN6hmcHEEPHLzEs1VFTOYfij4cYW9OVE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GKO9FhVqTn4dfaUTMFP8SEXrnu2zIFGJMnhRc6kdvEBa8K/ArHpifEiw/i7eTPLDG nwrkWDl8kwn3LVlQOp8eY1ZZ+nU1kFEmStf28MOrvq3UKn7HPB91Nk4KFwA42OIefF LVCW5/PTIT+QuJjD1zVlVxIw3rpEC/BMn7+TBzIM= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from blr-ubuntu-poza.qualcomm.com (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: poza@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1CEC3606DC; Thu, 22 Feb 2018 07:46:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1519285593; bh=AsvJ+SOFQRslN6hmcHEEPHLzEs1VFTOYfij4cYW9OVE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jcrK8R3/NSqO3ZoYu/qrfzwNsOGIvn0erHRjqaCFZXyadcFnEl4+noGWv1NNT1A45 JOhLEkhQ7s1/XGy8vb+09+zqB5hHZ1C/g4rDTQk3e4jy7/ptbgtCWO/MYJ01bEhjDf JbnZjjg2gI5c32o3J7KoifX7os2xxnzp/AHsQO/U= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1CEC3606DC Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=poza@codeaurora.org From: Oza Pawandeep To: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Sinan Kaya , Timur Tabi Cc: Oza Pawandeep Subject: [PATCH v9 3/7] PCI/ERR: add mutex to synchronize recovery Date: Thu, 22 Feb 2018 13:16:07 +0530 Message-Id: <1519285571-5634-4-git-send-email-poza@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1519285571-5634-1-git-send-email-poza@codeaurora.org> References: <1519285571-5634-1-git-send-email-poza@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch protects pci_do_recovery with mutex. Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/pcie-err.c b/drivers/pci/pcie/pcie-err.c index a532fe0..8318c84 100644 --- a/drivers/pci/pcie/pcie-err.c +++ b/drivers/pci/pcie/pcie-err.c @@ -20,6 +20,8 @@ #include #include "portdrv.h" +static DEFINE_MUTEX(pci_err_recovery_lock); + struct aer_broadcast_data { enum pci_channel_state state; enum pci_ers_result result; @@ -283,6 +285,8 @@ void pci_do_recovery(struct pci_dev *dev, int severity) pci_ers_result_t status, result = PCI_ERS_RESULT_RECOVERED; enum pci_channel_state state; + mutex_lock(&pci_err_recovery_lock); + if (severity == AER_FATAL) state = pci_channel_io_frozen; else @@ -326,9 +330,11 @@ void pci_do_recovery(struct pci_dev *dev, int severity) report_resume); dev_info(&dev->dev, "Device recovery successful\n"); + mutex_unlock(&pci_err_recovery_lock); return; failed: /* TODO: Should kernel panic here? */ dev_info(&dev->dev, "Device recovery failed\n"); + mutex_unlock(&pci_err_recovery_lock); } -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc., a Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.