Received: by 10.223.185.116 with SMTP id b49csp1625750wrg; Wed, 21 Feb 2018 23:51:10 -0800 (PST) X-Google-Smtp-Source: AH8x2244sSwT8/iVjX7YCs7SMWFGyM4w/x/K9rroAVRa+9XdxZ/vtW9GO3O8X17cTKPk8Lnw13wf X-Received: by 2002:a17:902:6a0f:: with SMTP id m15-v6mr5692249plk.379.1519285869912; Wed, 21 Feb 2018 23:51:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519285869; cv=none; d=google.com; s=arc-20160816; b=c66s2TSAT3WbxuVYUMcKknsycQ1ZIUV2VWN4Yi7I4icsM5teNP3vNKr6zxe+wZ65sK jGtqqVoN/oQKBWw3+vAoME9AsIsyRpeUfCKZ3YrrCFxdJSGLB2GNQfmj0Bw8Rutk077h 9mdo9E9O0j4jcP0KqSrANHLMZTdjkbowp0NuNwJAjEKWxmkYqritp26URhcLRHXY5f08 HiwOGgp0gaFxM4a4GfDvqUGGm1zvPpv6ej9JyR5Dm190i6odNaWwDDD3cRsQNzjyKIk7 O58aVKtkyTSDD066otBXTZ1PJN48/WIqWpCmfqZct3bEfEsuMjZz7pOcWQF9eYyVl7ep exfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=0iVqLB17v3qyR8v47m+nwLKCpehLgVYfe3Q18mNaV6E=; b=K3MrpVvhfbWfXiNir2mzYUfzmx1uToxhKjOiFah720zpSft5T0x52heTTDz+nYLXAl lolROadaHz3Z+CEmBZTMvBNHWJkWPF56Yp+1joozZu06EN3itj9XxmJiVeMIs8RUq2/W 9bvJ8DFnutEdTwikAD4UMXKRr2W2Ks1uQ/WkHTK74Cou+mvljKDfIXLdYzvV3lzxdfYF kGcLKTbtdbDh53G8enDakDjBe4Leg+/5efXObuorE1J6xafCxjDJG5LkbanVsJmPMtpJ TxBuTAKieMpbTfPTFlPh3/V+8zPQzt6hLrKN7ttOsh1hkjRcNwltyPhAQUkCnYhyGSux 4L2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=UEcYPzK8; dkim=pass header.i=@codeaurora.org header.s=default header.b=m+mi7c2j; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b5si3976737pfc.337.2018.02.21.23.50.55; Wed, 21 Feb 2018 23:51:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=UEcYPzK8; dkim=pass header.i=@codeaurora.org header.s=default header.b=m+mi7c2j; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752671AbeBVHqZ (ORCPT + 99 others); Thu, 22 Feb 2018 02:46:25 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:37582 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752628AbeBVHqX (ORCPT ); Thu, 22 Feb 2018 02:46:23 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id E963F60A05; Thu, 22 Feb 2018 07:46:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1519285582; bh=hwZOzCyTX+fdjKhqkG69kQbw+SmmOK6GyEvYYnbZGyg=; h=From:To:Cc:Subject:Date:From; b=UEcYPzK8Xtezfp/qqhCZ1ItzgeWBIe5qlukw1DahkWWLegjRPedbqu916Emw+iOER iOu4rsDv/LCftvHZfTxJ+2KQFKEpj4Z2p6wt6CBm0OJEfH7SDsvrGCVSeD6NUjor8U 4pu9acP4syS3RCFGTF2DXLB2M1lSlwC/Tx4c/VPw= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from blr-ubuntu-poza.qualcomm.com (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: poza@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2712F606DC; Thu, 22 Feb 2018 07:46:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1519285581; bh=hwZOzCyTX+fdjKhqkG69kQbw+SmmOK6GyEvYYnbZGyg=; h=From:To:Cc:Subject:Date:From; b=m+mi7c2jhaVkofT18N7t5lUhGk7RDiEdM6XzKQdFSE3T++9zD+qoaH4VXypdZyGDv e1Yctyw17ypVITYcsIChJw8h9DEk07R1V8J42JBJzdah0l23X9sciNSTKV1M875ibC N6wIM+WQEqSIr6xE/yM1Pu2bHo00DXQZsRgWGx30= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2712F606DC Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=poza@codeaurora.org From: Oza Pawandeep To: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Sinan Kaya , Timur Tabi Cc: Oza Pawandeep Subject: [PATCH v9 0/7] Address error and recovery for AER and DPC Date: Thu, 22 Feb 2018 13:16:04 +0530 Message-Id: <1519285571-5634-1-git-send-email-poza@codeaurora.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch set brings in error handling support for DPC The current implementation of AER and error message broadcasting to the EP driver is tightly coupled and limited to AER service driver. It is important to factor out broadcasting and other link handling callbacks. So that not only when AER gets triggered, but also when DPC get triggered (for e.g. ERR_FATAL), callbacks are handled appropriately. DPC should enumerate the devices after recovering the link, which is achieved by implementing error_resume callback. Changes since v8: Fixed Kbuild errors. Changes since v7: Rebased the code on pci master. > https://kernel.googlesource.com/pub/scm/linux/kernel/git/helgaas/pci Changes since v6: Sinan's and Stefan's comments implemented. > reordered patch 6 and 7 > cleaned up Changes since v5: Sinan's and Keith's comments incorporated. > made separate patch for mutex > unified error repotting codes into driver/pci/pci.h > got rid of wait link active/inactive and made generic function in driver/pci/pci.c Changes since v4: Bjorn's comments incorporated. > Renamed only do_recovery. > moved the things more locally to drivers/pci/pci.h Changes since v3: Bjorn's comments incorporated. > Made separate patch renaming generic pci_err.c > Introduce pci_err.h to contain all the error types and recovery > removed all the dependencies on pci.h Changes since v2: Based on feedback from Keith: " When DPC is triggered due to receipt of an uncorrectable error Message, the Requester ID from the Message is recorded in the DPC Error Source ID register and that Message is discarded and not forwarded Upstream. " Removed the patch where AER checks if DPC service is active Changes since v1: Kbuild errors fixed: > pci_find_dpc_dev made static > ras_event.h updated > pci_find_aer_service call with CONFIG check > pci_find_dpc_service call with CONFIG check Oza Pawandeep (7): PCI/AER: Rename error recovery to generic pci naming PCI/AER: factor out error reporting from AER PCI/ERR: add mutex to synchronize recovery PCI/DPC: Unify and plumb error handling into DPC PCI/AER: Unify aer error defines at single space PCI/DPC: Enumerate the devices after DPC trigger event PCI: Unify wait for link active into generic pci drivers/acpi/apei/ghes.c | 1 + drivers/pci/hotplug/pciehp_hpc.c | 21 +- drivers/pci/pci.c | 39 +++- drivers/pci/pci.h | 11 + drivers/pci/pcie/Makefile | 2 +- drivers/pci/pcie/aer/aerdrv.h | 30 --- drivers/pci/pcie/aer/aerdrv_core.c | 293 +------------------------- drivers/pci/pcie/aer/aerdrv_errprint.c | 1 + drivers/pci/pcie/pcie-dpc.c | 115 ++++++++++- drivers/pci/pcie/pcie-err.c | 366 +++++++++++++++++++++++++++++++++ drivers/pci/pcie/portdrv.h | 2 + include/linux/aer.h | 4 - include/linux/pci.h | 1 + 13 files changed, 534 insertions(+), 352 deletions(-) create mode 100644 drivers/pci/pcie/pcie-err.c -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc., a Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.