Received: by 10.223.185.116 with SMTP id b49csp1723604wrg; Thu, 22 Feb 2018 01:57:55 -0800 (PST) X-Google-Smtp-Source: AH8x227OztebxCN1QiIGpz/XvMXCQpisdTUUOQxrpLNilp93kSedKpR3DHOlJpCiVz+jRi+h0SId X-Received: by 2002:a17:902:24a5:: with SMTP id w34-v6mr5914286pla.221.1519293475044; Thu, 22 Feb 2018 01:57:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519293475; cv=none; d=google.com; s=arc-20160816; b=aDc6qZ+QDEvui7bX7oYyI2gcPqsGMvILOLc48t8X7NddcLtXrfKvbQ8LHOGAX0mgL6 ZvYCZk5KB2ch2Vd/nWccbyuuA2UzjOOKMyboBAcIt1IrMrAPanbhCMWVMyBjpEM1IIBU o4d1W+QHZDbb+ZybOkOXuM5D4PBAzJngohIbGmpZtR4Qh4Vvfj99psFwsPG8FyHfewsL /jz0f6+5OYR1lw1kRJwWxSLXfPfn7aIwIJ923sf6FJEjzdKDs5vju+aOtcameFqZI6cP MyMjO/0yaKm54gIpuRI663HVNCEWqhZ/L46oRyQ2GhlJIjBm3i/WPPeCFsx2oqk2BjSu 6pJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=u4Hempg6NUOu+NDWApwBSiicO2lt9NhC7whjY6wA49A=; b=VIgvSPfsBd6+H/zDa2L2aFhkKuIidgsL1aYiB8yh3oDn76WmeCSqhkiYUPgssq0/lb SZexm4UCZdw4TS6aqeBQFW4TKym4Yd7HfaGE7jI9bYIYo+eDI9GXwl9VQJ2VSmXZ8Y5I gs8n4EUFFsPnsEhLDtWBnfVnFAUAFxRLs16/020+WdBo1h1e+S6schHMzURfPU50nthD hD+AfpLx5DUg6xfh5HGpMT++S1kDiXXhwan6QqPXYIUYz4IxLy+cySAxhr4TpYDunLj/ al163iPwW/w/gdtjJxRWbAYgV3yuQuDE9Lhv5M1GuZu7cqA3cgeJtqQtWtndyTuc7D7j k52A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LiOoH7PQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m10si2795228pge.338.2018.02.22.01.57.40; Thu, 22 Feb 2018 01:57:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LiOoH7PQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753255AbeBVJzK (ORCPT + 99 others); Thu, 22 Feb 2018 04:55:10 -0500 Received: from mail-it0-f68.google.com ([209.85.214.68]:34143 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752644AbeBVJzH (ORCPT ); Thu, 22 Feb 2018 04:55:07 -0500 Received: by mail-it0-f68.google.com with SMTP id a203so1240210itd.1 for ; Thu, 22 Feb 2018 01:55:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=u4Hempg6NUOu+NDWApwBSiicO2lt9NhC7whjY6wA49A=; b=LiOoH7PQTl00OpqbtsIFow6pA1lTv6xyQVUTOFOSfTArlYB9LqSYX+zbfCfzG2dbtx X9IfovWA6CrUxfVx6mA9ZE+Wj/9Wxaqa2DmQo7LhdeFt93pM6Hu1oyffMe3G9ydEy/AJ SjnRon3GKaigqH/xVvN4GZnAxo5zSFuEbE/ME= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=u4Hempg6NUOu+NDWApwBSiicO2lt9NhC7whjY6wA49A=; b=EejDzrsoy3CkgmdQoqOilk+Mb9u9OBhbhHV0fDd/ICq45o1SWdALm4hq5DOJ7Lm4+C /2g5Nn1NTV6aCQmhyQNVE5rrrQNqpOHKw0uft+92tsbq3RroDCVLsxZCfI2ipy2n9V5M s0rhhjhOPkZ9OyBIuYSPxdS33/a/8F6IP3XJG1hnOUpS1JfAnxUtp5hOfIWBO7Oo90AB tXPhhv4AdqkjKV4fbwkMRKdJXFk9n8MPIRnaqGPePSnGGpzKS1Mw5z63SWV8uOnk6Rgh IINuZta8zDvb+C2uGR3QuWsTZKirxbc6YsOLMuwp9dRW/v7YvlExST5mqHwQQc0CwT8y PXtg== X-Gm-Message-State: APf1xPBIhbV1CAnvoRd2s1lJDxs/h3qU08W34KY6RZWkURH2y4WtDLju bUekrScG3u3fUub+WQiegsRph4DgAoo= X-Received: by 10.36.79.149 with SMTP id c143mr7501529itb.63.1519293306383; Thu, 22 Feb 2018 01:55:06 -0800 (PST) Received: from localhost ([122.167.232.138]) by smtp.gmail.com with ESMTPSA id h189sm9589758ioh.81.2018.02.22.01.55.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Feb 2018 01:55:04 -0800 (PST) From: Viresh Kumar To: Rafael Wysocki , Thierry Reding , Jonathan Hunter Cc: Viresh Kumar , linux-pm@vger.kernel.org, Vincent Guittot , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] cpufreq: tegra186: Break after initialization is done for policy->cpu Date: Thu, 22 Feb 2018 15:24:57 +0530 Message-Id: <77d470741dab32c2076a35253b9c0c2f0136583b.1519293292.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.15.0.194.g9af6a3dea062 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There are two clusters (2 + 4 CPUs) on this platform and a separate cpufreq policy is available for each of the CPUs. The loop in tegra186_cpufreq_init() tries to find the structure for the right CPU and finish initialization. But it is missing a `break` statement at the end, which forces it to restart the loop even when the CPU already matched and initialization is done. Fix that by adding the missing `break` statement. Signed-off-by: Viresh Kumar --- drivers/cpufreq/tegra186-cpufreq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cpufreq/tegra186-cpufreq.c b/drivers/cpufreq/tegra186-cpufreq.c index fe7875311d62..771df649ceb9 100644 --- a/drivers/cpufreq/tegra186-cpufreq.c +++ b/drivers/cpufreq/tegra186-cpufreq.c @@ -79,6 +79,7 @@ static int tegra186_cpufreq_init(struct cpufreq_policy *policy) policy->driver_data = data->regs + info->offset + EDVD_CORE_VOLT_FREQ(core); cpufreq_table_validate_and_show(policy, cluster->table); + break; } policy->cpuinfo.transition_latency = 300 * 1000; -- 2.15.0.194.g9af6a3dea062