Received: by 10.223.185.116 with SMTP id b49csp1941838wrg; Thu, 22 Feb 2018 05:48:42 -0800 (PST) X-Google-Smtp-Source: AH8x224Gdi2KJfFTEoHrTbG7WzKfidcApioHITcGOL4asQepKPwOsfUttjlMhhYwZpT1XRYiQNPx X-Received: by 10.98.102.82 with SMTP id a79mr7013537pfc.138.1519307322186; Thu, 22 Feb 2018 05:48:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519307322; cv=none; d=google.com; s=arc-20160816; b=he2VyueJKzG2hoJ23CdeXcAZOw4kNGrsdi8OMIEjcpf6FaiROLmdfEpo29cHm8tagY H4Rwr+hyo+I78eKLhYFwOA1IRrvl8oeI4I+grToYjeIleZQwAclBNJF58dW9AzZlJHdR EzZ4jSm4HgfAmp/CsrMEBBSTS7+sMluXZ/z96w2sZnpu1zj/XkSxfpe6M07BPSTnIEti O3MzB2WILBevLXsLEFVj0WA7EYemcI6Bj+GSFSddRhjGaFRXk0C/4OK3W8qZok+O7f31 OmxtOEmw8UR2GMF4pmjenzoz9Zex0RHNs2CVYzTBJvAWagI2VyOqznFEyXk3fFeI6H3h tnVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=7GTaC3y9NK/m9rSmtZJI6vC5EYFdOCiXUQTJPIPeLtg=; b=DHt7iX8ykDnrqSSc2/nNkE5mhiFt9n/yGJONe/vfaRjwk5J9tKWWtTo7Vlr3IS0OSO vTbRZtJd66TP6jvr+1IUo08OKkJ+hROeK7mPKT0S41RKgYpWz6eBotdOOx7MCX2H7/o0 EVqyAp5qtYjHz2WicKkj1WigfNljWGGfPPnLK26iqLJM3gx7s68MdpJPFx67cKHRbim2 Hc1cGPj7rDRGk800BLK1BpqyzHIqJmGn74n3YqsLwwjjx4KGd8EcVS0MNPxNCkMdLPE0 EM0EdMkIagNbKVGkPinABZYbhqeTvttVi2uIWkJwWcR9HHbPysuvunVDoPBBaqOrYy02 7dsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XqcPFM4w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e18si65230pfi.130.2018.02.22.05.48.27; Thu, 22 Feb 2018 05:48:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XqcPFM4w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932644AbeBVNrn (ORCPT + 99 others); Thu, 22 Feb 2018 08:47:43 -0500 Received: from mail-io0-f194.google.com ([209.85.223.194]:36382 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932579AbeBVNrk (ORCPT ); Thu, 22 Feb 2018 08:47:40 -0500 Received: by mail-io0-f194.google.com with SMTP id t22so6068828iob.3 for ; Thu, 22 Feb 2018 05:47:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=7GTaC3y9NK/m9rSmtZJI6vC5EYFdOCiXUQTJPIPeLtg=; b=XqcPFM4w4r9U/yhV7042SrSKYuSx07L7EkKtSbsrm8f7zu+g+SJ9Ql4DTQH6CQhLhe vMZfkl8UqU3hjklGzFn0L6l1qQaWnS3S7YCyiKbcGtvfheOnFf5Xun1DLdTLEnjz69Z/ hpfFPq0l/mZTnKioE/FYQcn1ijBJycc2WGk78= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7GTaC3y9NK/m9rSmtZJI6vC5EYFdOCiXUQTJPIPeLtg=; b=I5uXnnqee9i5vpdYAMIj2EOylLuiYdhY57wm2T/lDx6E9XYEL+7rM7xbWK/0PlQY4C t2kQ+kD7r4Db1OYvVRcfitOyTmd7FuN4nG5RXdeztP9Igeepr1QXwTL62HXdr3zKsWrk Oz4OmpjSck4s/6Z63KuxcK2ieEDZArcvTp+nHF6gRs6O1oGUDqfvtY1aVksXAhAcWGHl xg5BDq8pvmrZnIxc7gpe/CA/AKqTXQGNPSaSWUhJmbctwXvJMGIBz6ZHJ9bW7pJ153Dr 2lQd1h38u+kDNDFqIjnhZiijc84gte7fjTZXFe+yL0sfy9X9OuNcynYAESvMb4i67RlZ yXqA== X-Gm-Message-State: APf1xPCK/yg3ydVRUj1KGe/ZWrIjt9Y3MMxhCRNHEJvKHyxm1qHqhknt 8smfMkztwG+d8UKs2liKWLxG0nP3Wi/DIlE5DgPXUQ== X-Received: by 10.107.139.77 with SMTP id n74mr8768754iod.109.1519307259808; Thu, 22 Feb 2018 05:47:39 -0800 (PST) MIME-Version: 1.0 Received: by 10.79.230.25 with HTTP; Thu, 22 Feb 2018 05:47:39 -0800 (PST) In-Reply-To: <1518100057-23234-4-git-send-email-amelie.delaunay@st.com> References: <1518100057-23234-1-git-send-email-amelie.delaunay@st.com> <1518100057-23234-4-git-send-email-amelie.delaunay@st.com> From: Linus Walleij Date: Thu, 22 Feb 2018 14:47:39 +0100 Message-ID: Subject: Re: [PATCH 3/6] gpio: Add GPIO support for the ST Multi-Function eXpander To: Amelie Delaunay Cc: Lee Jones , Rob Herring , Mark Rutland , Russell King , Alexandre Torgue , Maxime Coquelin , linux-gpio@vger.kernel.org, "linux-kernel@vger.kernel.org" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 8, 2018 at 3:27 PM, Amelie Delaunay wrote: > ST Multi-Function eXpander (MFX) can be used as GPIO expander. > It has 16 fast GPIOs and can have 8 extra alternate GPIOs > when other MFX features are not enabled. > > Signed-off-by: Amelie Delaunay As mentioned I think this driver needs to: - Move to drivers/pinctrl/pinctrl-stmfx.c similar to the sx150x controller. - Pass a regmap around instead of the custom accessor functions. - Maybe refactor and reuse STMPE infrastructure Yours, Linus Walleij