Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 22 Feb 2018 15:51:05 +0100
From:   Boris Brezillon <boris.brezillon@bootlin.com>
To:     Shreeya Patel <shreeya.patel23498@gmail.com>
Cc:     Richard Weinberger <richard@nod.at>,
        boris.brezillon@free-electrons.com, dwmw2@infradead.org,
        computersforpeace@gmail.com, marek.vasut@gmail.com,
        cyrille.pitchen@wedev4u.fr, maximlevitsky@gmail.com,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
        ezequiel@vanguardiasur.com.ar, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH NAND v3] mtd: nand: Replace printk() with appropriate
 pr_*() macro
Message-ID: <20180222155105.097eb00a@bbrezillon>
In-Reply-To: <1519310758.2359.3.camel@gmail.com>
References: <1519305014-2547-1-git-send-email-shreeya.patel23498@gmail.com>
        <2093598.TLbMltDcSo@blindfold>
        <1519310758.2359.3.camel@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 22 Feb 2018 20:15:58 +0530
Shreeya Patel <shreeya.patel23498@gmail.com> wrote:

> On Thu, 2018-02-22 at 15:30 +0100, Richard Weinberger wrote:
> > Am Donnerstag, 22. Februar 2018, 14:10:14 CET schrieb Shreeya Patel:  
> > > 
> > > @@ -438,7 +438,7 @@ static void __init doc2000_count_chips(struct
> > > mtd_info
> > > *mtd) break;
> > >  	}
> > >  	doc->chips_per_floor = i;
> > > -	printk(KERN_DEBUG "Detected %d chips per floor.\n", i);
> > > +	pr_debug("Detected %d chips per floor.\n", i);  
> > <bike-shedding>
> > 
> > You are aware of the fact that printk(KERN_DEBUG and pr_debug() are
> > not 
> > equivalent?
> > Not a big deal, just want to make sure that you understand what you
> > are doing.   
> 
> Actually pr_debug() shouldn't be used here.
> 
> We usually don't prefer pr_debug for drivers, instead we use dev_dbg.
> But as Boris told me that it will be better to first having changed all
> printks to pr_*() macro and then think about dev_*() macros.

pr_xx() vs dev_xx() is yet another story ;-).

-- 
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com