Received: by 10.223.185.116 with SMTP id b49csp2098955wrg; Thu, 22 Feb 2018 08:08:15 -0800 (PST) X-Google-Smtp-Source: AH8x226Z0DVIVvkJtR+BWlYS48Fe7/woqUamFDPvcTBzsE3836pj1mqM5CrHI0I7uFQpMbBZMBP7 X-Received: by 2002:a17:902:ab8a:: with SMTP id f10-v6mr7151496plr.318.1519315695819; Thu, 22 Feb 2018 08:08:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519315695; cv=none; d=google.com; s=arc-20160816; b=xc91j7tGwMRCfeYVtqsK3RCFVFPEr/qapRlkrCIRi0shRJ0+TDrwvGJ7GgDjAOZP20 FwIzekMeu6D8s6JHD4U47vma473WqPGGoq5q0JEaaVvK26Rszdi1PKvXF8heC2pvHoqz LCnnrSFAHKaUR0QUGIR/5m056opR2cxjqXHkzMXv89D4kXJdFevuikR3XiN5haBlMBRA 4q3l1NIuRXgrgWfYu86HcuGWGduuiKna9qcvwOWBiJBTK4BKWCaYdXWRJgl7bA8z6Kw5 kNtt4F5jSGXMKZcePXQ6ciWcbNnXPVmSSYAsfViOmWcVmg07IBRzYkaUSjL40nf450LN ZEYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=CoeaFqstDmrs9gFUWcmFWtXF1LiGQM/ckGF+XbTnCTc=; b=0QFzmPsPvr0YneO/a9pIt6Qxoer/xdo7cXBNx/I0s1jSkAeTfbs34q+2PLktRM+9Bi prUq8f3kAlkwWGsFB+kkx9We5LzEoeIU+iLcDALHYHgTmXegoJ4QhGuP/Lv16PEYz7v7 RPf0IFtG40MNvrbnff0LbbPMZSTyuYQsnxbzNx+mIODWRqFA32UzYVH27cyq+qBKt9cI DzJl5glmZ/i38LJfGGtY1Rd29f6wc4Vxx4kkgsJzwHtANVoiP8nXlfeNtA+/Zl0Ycc38 lepC6m/Gy0NLvrEz9TzluBCpwi2jZSEyuBf5IDgLUr/86CNr252Qg20fSBBYxPbE/ddG +WaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=TjKswCfr; dkim=pass header.i=@codeaurora.org header.s=default header.b=Ydv0zFi5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c6-v6si242855pll.258.2018.02.22.08.07.50; Thu, 22 Feb 2018 08:08:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=TjKswCfr; dkim=pass header.i=@codeaurora.org header.s=default header.b=Ydv0zFi5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933292AbeBVQFC (ORCPT + 99 others); Thu, 22 Feb 2018 11:05:02 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:53680 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933135AbeBVQCZ (ORCPT ); Thu, 22 Feb 2018 11:02:25 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 4898F60ACA; Thu, 22 Feb 2018 16:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1519315344; bh=S9fSwb9+nzYiwiQTrOkRSsXYibVUBtFeaALlFYITOKo=; h=From:To:Cc:Subject:Date:From; b=TjKswCfr6rkAJPr6GMRRxMEv3zhHwSYTmrJNYH/f4nhehnAirg+G/yvZMzZqD9GSs jJGQS5jUyK3MIFge6WgT+xJr/g82g2JiETuiq5rG+QNNFPU+i5lhb4rK+S+X6tvGgA RzVKFZJTNIUJKb5ir5NIPZ4J12OTeh3fdi98M4Pg= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from blr-ubuntu-poza.qualcomm.com (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: poza@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id B600E607CF; Thu, 22 Feb 2018 16:02:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1519315343; bh=S9fSwb9+nzYiwiQTrOkRSsXYibVUBtFeaALlFYITOKo=; h=From:To:Cc:Subject:Date:From; b=Ydv0zFi5+mVZpAary8TOtofamdH8vk1A9DMx01LL1lCnBI/nn0mG/Rbi6wOMkEsAw uXV3SizeEIJThJS4p4LRhrSqow4p7LbSA8rMWhrQzj+UO79Q2gETuEvu2KezNvX0Hi Fd2Njc3dbIk4KhO2tIGD4OSx8524b1fY5+ETMOx4= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B600E607CF Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=poza@codeaurora.org From: Oza Pawandeep To: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Sinan Kaya , Timur Tabi Cc: Oza Pawandeep Subject: [PATCH v10 0/7] Address error and recovery for AER and DPC Date: Thu, 22 Feb 2018 21:32:05 +0530 Message-Id: <1519315332-26852-1-git-send-email-poza@codeaurora.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch set brings in error handling support for DPC The current implementation of AER and error message broadcasting to the EP driver is tightly coupled and limited to AER service driver. It is important to factor out broadcasting and other link handling callbacks. So that not only when AER gets triggered, but also when DPC get triggered (for e.g. ERR_FATAL), callbacks are handled appropriately. DPC should enumerate the devices after recovering the link, which is achieved by implementing error_resume callback. Changes since v9: Sinan's comments addressed. Changes since v8: Fixed Kbuild errors. Changes since v7: Rebased the code on pci master > https://kernel.googlesource.com/pub/scm/linux/kernel/git/helgaas/pci Changes since v6: Sinan's and Stefan's comments implemented. > reordered patch 6 and 7 > cleaned up Changes since v5: Sinan's and Keith's comments incorporated. > made separate patch for mutex > unified error repotting codes into driver/pci/pci.h > got rid of wait link active/inactive and made generic function in driver/pci/pci.c Changes since v4: Bjorn's comments incorporated. > Renamed only do_recovery. > moved the things more locally to drivers/pci/pci.h Changes since v3: Bjorn's comments incorporated. > Made separate patch renaming generic pci_err.c > Introduce pci_err.h to contain all the error types and recovery > removed all the dependencies on pci.h Changes since v2: Based on feedback from Keith: " When DPC is triggered due to receipt of an uncorrectable error Message, the Requester ID from the Message is recorded in the DPC Error Source ID register and that Message is discarded and not forwarded Upstream. " Removed the patch where AER checks if DPC service is active Changes since v1: Kbuild errors fixed: > pci_find_dpc_dev made static > ras_event.h updated > pci_find_aer_service call with CONFIG check > pci_find_dpc_service call with CONFIG check Oza Pawandeep (7): PCI/AER: Rename error recovery to generic pci naming PCI/AER: factor out error reporting from AER PCI/ERR: add mutex to synchronize recovery PCI/DPC: Unify and plumb error handling into DPC PCI/AER: Unify aer error defines at single space PCI/DPC: Enumerate the devices after DPC trigger event PCI: Unify wait for link active into generic pci drivers/acpi/apei/ghes.c | 1 + drivers/pci/hotplug/pciehp_hpc.c | 21 +- drivers/pci/pci.c | 39 +++- drivers/pci/pci.h | 11 + drivers/pci/pcie/Makefile | 2 +- drivers/pci/pcie/aer/aerdrv.h | 30 --- drivers/pci/pcie/aer/aerdrv_core.c | 293 +------------------------- drivers/pci/pcie/aer/aerdrv_errprint.c | 1 + drivers/pci/pcie/pcie-dpc.c | 115 ++++++++++- drivers/pci/pcie/pcie-err.c | 366 +++++++++++++++++++++++++++++++++ drivers/pci/pcie/portdrv.h | 2 + include/linux/aer.h | 4 - include/linux/pci.h | 1 + 13 files changed, 534 insertions(+), 352 deletions(-) create mode 100644 drivers/pci/pcie/pcie-err.c -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc., a Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.