Received: by 10.223.185.116 with SMTP id b49csp2181770wrg; Thu, 22 Feb 2018 09:21:50 -0800 (PST) X-Google-Smtp-Source: AH8x224F4ryNpZZhHtBWHDIU+nfhOVxYW7h9KTor+pPsIwxs2uHryHk4NrVfd11BhADDR6l3yhVl X-Received: by 10.167.131.88 with SMTP id z24mr5896098pfm.86.1519320110504; Thu, 22 Feb 2018 09:21:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519320110; cv=none; d=google.com; s=arc-20160816; b=iliwBw0ciNrJl2xTUqFqSYCS2JV3wwCnCnkTOrppryIQN3HSyz/K95ZgGaR8GG6mmF TD52krym9sx9ZgD0GRgPDj4t6Rg3XegpLT9fzGuRSoTEo8tuLrSS71vn1FXTwCAYSWtC 9dCcTvg8jiy/zcLt6RF76z0Xe0xYIdddDKAnldy8QjTAuPhvTFa7qRHOzlB3/GQ9+taE 12zuk679CtarNIHr49Sd251GfNXsmbhlPCkDQvwF6ojSHpx58yVoXsJWvJglKmuVjvD8 mRLxwyjKtBgziNNQG5x2sTdPQGqveqmwFIcn372yenVePcenIYSDqmiNvIpwv+vifR8f 9KOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=UBtP9GyjEOIzZkSrvk6+T6x6FzdTRH3NSNji5SkC95s=; b=GP4o9WCDM60DXA5y8J4kp60C1J6feDxawyRX3/LBW6IHiG7IMHio7XA0ZsLvDMvgIC B/c47FoLrVDX2OelTHOA7nmfCfi6jPrQVaVjeYHX9NaLGQ+VtAl8tMQEwlLHaRge5PL2 9PZ3XvT68mF5d6SmENiAmAalqew4RkwzteTaiXFZg/4/kqHYbhZ0ga+leHhgE0A1QEZR KZLDGp2C0tIQCcO5oEGPD2VyA3vH9mZ/Rj/e2OY42I7IX5CWAhd1U1Le2k71sP33mbYj SnKjseENIg+K0y9ZVOvjkjClpVRgWuaCDfQeaQqmNXN+hByfyh8eryASngpKXHlipkWy IJUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k9-v6si337520plt.293.2018.02.22.09.21.34; Thu, 22 Feb 2018 09:21:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933464AbeBVRUv (ORCPT + 99 others); Thu, 22 Feb 2018 12:20:51 -0500 Received: from mga01.intel.com ([192.55.52.88]:8006 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933424AbeBVRUt (ORCPT ); Thu, 22 Feb 2018 12:20:49 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Feb 2018 09:20:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,378,1515484800"; d="scan'208";a="32799172" Received: from yoojae-mobl1.amr.corp.intel.com (HELO [10.7.153.147]) ([10.7.153.147]) by fmsmga001.fm.intel.com with ESMTP; 22 Feb 2018 09:20:47 -0800 Subject: Re: [PATCH v2 1/8] [PATCH 1/8] drivers/peci: Add support for PECI bus driver core To: Greg KH Cc: joel@jms.id.au, andrew@aj.id.au, arnd@arndb.de, jdelvare@suse.com, linux@roeck-us.net, benh@kernel.crashing.org, andrew@lunn.ch, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org References: <20180221161606.32247-1-jae.hyun.yoo@linux.intel.com> <20180221161606.32247-2-jae.hyun.yoo@linux.intel.com> <20180221175853.GA22320@kroah.com> <7f152459-a232-e62a-3c34-e995f8c85d63@linux.intel.com> <20180222065455.GA2428@kroah.com> From: Jae Hyun Yoo Message-ID: <9bd825f4-8497-4e2a-b8ea-56888df754e7@linux.intel.com> Date: Thu, 22 Feb 2018 09:20:47 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180222065455.GA2428@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/21/2018 10:54 PM, Greg KH wrote: > On Wed, Feb 21, 2018 at 12:42:30PM -0800, Jae Hyun Yoo wrote: >> On 2/21/2018 9:58 AM, Greg KH wrote: >>> On Wed, Feb 21, 2018 at 08:15:59AM -0800, Jae Hyun Yoo wrote: >>>> This commit adds driver implementation for PECI bus into linux >>>> driver framework. >>>> >>>> Signed-off-by: Jae Hyun Yoo >>>> --- >>> >>> Why is there no other Intel developers willing to review and sign off on >>> this patch? Please get their review first before asking us to do their >>> work for them :) >>> >>> thanks, >>> >>> greg k-h >>> >> >> Hi Greg, >> >> This patch set got our internal review process. Sorry if it's code quality >> is under your expectation but it's the reason why I'm asking you to review >> the code. Could you please share your time to review it? > > Nope. If no other Intel developer thinks it is good enough to put their > name on it as part of their review process, why should I? > > Again, please use the resources you have, to fix the obvious problems in > your code, BEFORE asking the community to do that work for you. > > greg k-h > Okay. I'll take our internal review process again on this patch set and collect more credit tags before submitting v3. Thanks for your advice! Jae