Received: by 10.223.185.116 with SMTP id b49csp2255412wrg; Thu, 22 Feb 2018 10:35:04 -0800 (PST) X-Google-Smtp-Source: AH8x225DLrWfRuhlENykxooqQDJ4+kz9Z/dd5kBrQb/WdMlU/W6ljC5mHO4AfYad0tfGZdyj2M7X X-Received: by 2002:a17:902:b418:: with SMTP id x24-v6mr1579780plr.320.1519324504595; Thu, 22 Feb 2018 10:35:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519324504; cv=none; d=google.com; s=arc-20160816; b=jDytVWrNwPuVSSMteDjiLBtSku8krRCTLq50UU2iXbBcgabwaBuTbtdlVPohEhARhd kXPBkLv4F9kBiY2Fb5dg/Xsv5FKNw1FnvMU9YWc11tW4eKU03ZPxbqdLiIMBYgAd1CP9 4AwAfCBoG4uqpzK9YCveIxUANhEEWgN8twl5evnfcqKv/9KfzCvaTBmB3sfQb7SnaZoz 3WBI49woiLR3hnWOQFf2Qk8GSYJTVnXJuGMb4NtY5V7RZ9ZdUr2pQdpk7cqHndCewQcX HHojOk9DCvwfycxjlr3uVkI1S1pqPBaf+Tj6XfTofCxYZ5E7u+M4gnYvke8WIxJ1Cr7z CrBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=9KgjqA0d7uVApPhoxvxcoxjPLxi45K2mIYv0yP85QDc=; b=z6+pNVhr6dlYr0la1YAZCNas1FV+JKQfhiTuKo9avBSISuKJe5GS3vjJ9e1kOOy/7s FDD7KP2O6T/anKwmX29sZAsivM75WuSJuPQNX8c1lSb4o912yCrPx7jRmU0MBVFQwwvu WU9I/uLQwty8UltOQhS12X0xKyJqLwAw563324GCZkaAUrQ9eViY7XQU25I4IIJ3PHG3 Fw+6cEqXhXlkWuqehFfFe4fy2yIEObVFCaWWEz12iK9PBkG2L1o2YONG5UsqS9eex0y0 a4SBytERvfNtSf0CQwZtsTusCLLF3T6n8H034nefICdR9vyJUoKtD147KkSEFI0GHwuE 2u0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=miLVIRQQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u25si352687pgv.221.2018.02.22.10.34.47; Thu, 22 Feb 2018 10:35:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=miLVIRQQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751252AbeBVSeG (ORCPT + 99 others); Thu, 22 Feb 2018 13:34:06 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:50270 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750752AbeBVSeF (ORCPT ); Thu, 22 Feb 2018 13:34:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9KgjqA0d7uVApPhoxvxcoxjPLxi45K2mIYv0yP85QDc=; b=miLVIRQQCmsYQmQnj2KGC009t DaNXqFZiMCJmL3rmRncOPyI67JRpD++wIg4r2Qkr4M7FoCZh6/5vvm1CG2Db1uZ5ZoQ2x/4hEHEVr V4u1r8Is+CNx+BmUN7S+I10tKJGdvxI4yMmUTi11nYrsrKzqaRyjcig+kicRwSPJKRuvYmtv3HyKz EWO+xCILJz3CUh1fV+VEZjYw/1WrqmQChQfx2t3iGkwnJ6lTUjA3+6GQLVL08P3CfViIwCKBEkOMY m0AKHVoYIlaemWcy6X4+c6Rkf2WUofNqP8SUvx9N20/91WQEuU+Or97WGARh+6RkBs6D32kVe8rPr 0Kn0hf1UA==; Received: from hch by bombadil.infradead.org with local (Exim 4.89 #1 (Red Hat Linux)) id 1eovgx-0001pd-77; Thu, 22 Feb 2018 18:34:03 +0000 Date: Thu, 22 Feb 2018 10:34:03 -0800 From: Christoph Hellwig To: Oza Pawandeep Cc: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Sinan Kaya , Timur Tabi Subject: Re: [PATCH v10 1/7] PCI/AER: Rename error recovery to generic pci naming Message-ID: <20180222183403.GA6267@infradead.org> References: <1519315332-26852-1-git-send-email-poza@codeaurora.org> <1519315332-26852-2-git-send-email-poza@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1519315332-26852-2-git-send-email-poza@codeaurora.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 22, 2018 at 09:32:06PM +0530, Oza Pawandeep wrote: > This patch renames error recovery to generic name with pci prefix > > Signed-off-by: Oza Pawandeep > > diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c > index a4bfea5..306bf2f 100644 > --- a/drivers/pci/pcie/aer/aerdrv_core.c > +++ b/drivers/pci/pcie/aer/aerdrv_core.c > @@ -478,7 +478,7 @@ static pci_ers_result_t reset_link(struct pci_dev *dev) > } > > /** > - * do_recovery - handle nonfatal/fatal error recovery process > + * pci_do_recovery - handle nonfatal/fatal error recovery process > * @dev: pointer to a pci_dev data structure of agent detecting an error > * @severity: error severity type > * > @@ -486,7 +486,7 @@ static pci_ers_result_t reset_link(struct pci_dev *dev) > * error detected message to all downstream drivers within a hierarchy in > * question and return the returned code. > */ > -static void do_recovery(struct pci_dev *dev, int severity) > +static void pci_do_recovery(struct pci_dev *dev, int severity) Maybe pcie_do_recovery? Otherwise looks fine: Reviewed-by: Christoph Hellwig