Received: by 10.223.185.116 with SMTP id b49csp2262235wrg; Thu, 22 Feb 2018 10:42:45 -0800 (PST) X-Google-Smtp-Source: AH8x225EykVxUq3P/K9T/qVc/0fbtXYc+EPVe0VFVl4nUBiQRVcmB1neUXahiCbiLAy7Po/MyNaH X-Received: by 10.98.87.29 with SMTP id l29mr362412pfb.72.1519324965629; Thu, 22 Feb 2018 10:42:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519324965; cv=none; d=google.com; s=arc-20160816; b=kt+E3AjG00QcRn/WKypxnlChj8Ly7WYyddmBW+xfMG2OND+vujHSt7A/5mtiqFB4ka 6PWJiXCLs51AI4IdBtfQrQQzmIvX/Ukq2yzu2cEQhxpCEENxkctjqP2vCiCIoo4Mi7qk MqdXF+//CiPiSQ0Zcwm0tVEDGD+hNa4DqHPfC8Lojf7KFWWW3uQdEa72+hm567G5XgNE EURU0d2JZAT05lwjf/bEv8UPB3+2olVBGsH5SnZqgppUMEyY5A9rjMjvsBGTnY+v7vwj Pd33cagXzsIaH5DjwBXLkgqjaSUgSt+ngqRSdtchvREcZkKAPATQFYpzaOIiPj0jLqTm 8ing== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from :arc-authentication-results; bh=QcJWvikspz93FV+16gRCxm7SdnVpittLd1b4tEKf+z8=; b=MpVfuh3H2kIWNL3xsqoM63RK/mptEssFcSsYuvQ3ydQAFbzLuVm4Iz45olTossQtS5 pGfSYF4vmnWtFGv+e0oiWUmsCnoUJ0XKyWYCpXG3gFuOAx5jw6FnqjqyowPnoQqMLv5N SaBNvFQq5o1XmratGcEQErMLtwXQbRkeIH4IPtoJjYGvuBv8a43qcTnK5TI+iUwFaot0 nMhrh9dhosgbVwgB8+KdzmEySVK3uctqU96d0p83ajfFwyx1nLE8DJ4mNNxtC15Exale rhhJ3YAOVcxhtC6Q+H5Zi3Nq/q4thZISRQn3iRe/U9Hyuo2EuXavnbC6PxIepBT5sI5n GFyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z8-v6si400662plo.762.2018.02.22.10.42.30; Thu, 22 Feb 2018 10:42:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750967AbeBVSlw convert rfc822-to-8bit (ORCPT + 99 others); Thu, 22 Feb 2018 13:41:52 -0500 Received: from smtp-out6.electric.net ([192.162.217.191]:59632 "EHLO smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750725AbeBVSlu (ORCPT ); Thu, 22 Feb 2018 13:41:50 -0500 Received: from 1eovoH-0001kR-WF by out6a.electric.net with emc1-ok (Exim 4.87) (envelope-from ) id 1eovoJ-0001oN-Vq; Thu, 22 Feb 2018 10:41:39 -0800 Received: by emcmailer; Thu, 22 Feb 2018 10:41:39 -0800 Received: from [156.67.243.126] (helo=AcuMS.aculab.com) by out6a.electric.net with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) (Exim 4.87) (envelope-from ) id 1eovoH-0001kR-WF; Thu, 22 Feb 2018 10:41:38 -0800 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 22 Feb 2018 18:42:32 +0000 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Thu, 22 Feb 2018 18:42:32 +0000 From: David Laight To: 'Christoph Hellwig' , Oza Pawandeep CC: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , "Greg Kroah-Hartman" , Kate Stewart , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Dongdong Liu , "Keith Busch" , Wei Zhang , Sinan Kaya , Timur Tabi Subject: RE: [PATCH v10 2/7] PCI/AER: factor out error reporting from AER Thread-Topic: [PATCH v10 2/7] PCI/AER: factor out error reporting from AER Thread-Index: AQHTrAv2aSA2mzKwCE6vohCF40aW/6OwwPCA Date: Thu, 22 Feb 2018 18:42:32 +0000 Message-ID: <0cd107dfe3ec4dda89457b112e8f79e5@AcuMS.aculab.com> References: <1519315332-26852-1-git-send-email-poza@codeaurora.org> <1519315332-26852-3-git-send-email-poza@codeaurora.org> <20180222183448.GB6267@infradead.org> In-Reply-To: <20180222183448.GB6267@infradead.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.33] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Outbound-IP: 156.67.243.126 X-Env-From: David.Laight@ACULAB.COM X-Proto: esmtps X-Revdns: X-HELO: AcuMS.aculab.com X-TLS: TLSv1.2:ECDHE-RSA-AES256-SHA384:256 X-Authenticated_ID: X-PolicySMART: 3396946, 3397078 X-Virus-Status: Scanned by VirusSMART (c) X-Virus-Status: Scanned by VirusSMART (s) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christoph Hellwig > > - pci_uevent_ers(dev, PCI_ERS_RESULT_DISCONNECT); > > - /* TODO: Should kernel panic here? */ > > - pci_info(dev, "AER: Device recovery failed\n"); > > -} > > +EXPORT_SYMBOL(pci_find_aer_service); > > EXPORT_SYMBPOL_GPL please. Is this a function that a 'normal' PCIe device driver would need to call? If so it is a PITA requiring all drivers that want AER to be GPL. David