Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <21797175-11f5-d87e-bc3e-35ca3547627f@prevas.dk>
References: <20180222174140.GA3154@beast> <CA+55aFxDh-69p0Lr52icct6-3PGcsHaZmMqHwks8HptdmdxvTg@mail.gmail.com>
 <66556bf7-3e67-5793-081e-76a01f598374@prevas.dk> <21797175-11f5-d87e-bc3e-35ca3547627f@prevas.dk>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Thu, 22 Feb 2018 13:56:12 -0800
Message-ID: <CA+55aFz_ww8ohU68Jz34pg_x7gpGpJ+FC-dmS_Rm_VvY01GGpg@mail.gmail.com>
Subject: Re: [PATCH v3] kconfig.h: Include compiler types to avoid missed
 struct attributes
To:     Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Cc:     Kees Cook <keescook@chromium.org>,
        Patrick McLean <chutzpah@gentoo.org>,
        "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Feb 22, 2018 at 1:34 PM, Rasmus Villemoes
<rasmus.villemoes@prevas.dk> wrote:
>
> Hm, we should probably make sure that kconfig.h is always on the
> dependency list in .o.cmd, but just exclude it from being processed for
> the CONFIG_ pattern.

That sounds sensible to me.

Not that this likely has ever bit anybody outside of this one case,
but when missing dependencies cause a missed re-compile, the resulting
bugs can be _really_ subtle.

           Linus