Received: by 10.223.185.116 with SMTP id b49csp416342wrg; Fri, 23 Feb 2018 00:28:57 -0800 (PST) X-Google-Smtp-Source: AH8x225O838glQt7vUa4XgFpHu0sHtWqscKye+CpXHtbxUIY7yD5lBao2/6ORt7CrMKnEPUBmyHx X-Received: by 10.101.66.76 with SMTP id d12mr831673pgq.234.1519374537615; Fri, 23 Feb 2018 00:28:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519374537; cv=none; d=google.com; s=arc-20160816; b=dYt7a43pUuCBNBVBRE1l+YBCBZs8bT7/58LUZCxSQ3w1Amk7Rd3GmasVfo1Kw1ahhL PyiLWfT2Q6qzMFAMKLxhNzscykkexaSaf2nSECxaIwsY60rrF9OUBmu1RrDPc29Pbk5s LNdlJGxpy6uM+0u1SntstVGDR5UoSmuMsbQw5BlziTHoWqOD/embA6BT+uXsk2w/qmyj ws9DT0eKLLl8RdHio0lPpZ8bJfG5zkjkPL4kmzpxXb/Q5/nGBEqJFo1GbsC0ZJ1ArUJi QB+GV7NyoJA3exD+TP2rafGjQlNWXQFNAXrq6h4009srk0qHKJbcP4ujTMa03UMXiOVK cmBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=rFvK8GgxJmyDUtCS4E9V4PZPK+FMLnMf4YBkwiXflUc=; b=f90UHXyhWZuDsGvq7fye5/vyO+avFdjjXjxE8JckCWbQJ3Xy8DuvIq4XyEKse4fsWB awOHLc8ymkV1ZPdCqU5ZKdcbw/lMHMg00vxsd6rDp8eaANaV6KzMojRIOoAsJnyUMYxA nMfdCTHNCkEMbl/weENtISaIVLBZZQwCFdAQ1529moXuEas8HBbqpGUaOZSbAofISuww TS8+eJBEH8dYeO24KYlntfih05jsWbl3XAUI7X5B/8U4Ii5mQ8HmkMhGIAzw3tvGPN8S QaCjdre+12HoMOv5SUqR2xtAXpM0sQvwdlc7PdO/ZJ2L+wNU2mMfX9bJEZwWOdr8NwTP /N4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=QHHU3Gxl; dkim=pass header.i=@codeaurora.org header.s=default header.b=C9Hm97rw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a21si1224469pgw.213.2018.02.23.00.28.43; Fri, 23 Feb 2018 00:28:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=QHHU3Gxl; dkim=pass header.i=@codeaurora.org header.s=default header.b=C9Hm97rw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751454AbeBWIYT (ORCPT + 99 others); Fri, 23 Feb 2018 03:24:19 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:59760 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750935AbeBWIYR (ORCPT ); Fri, 23 Feb 2018 03:24:17 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 7A69260F71; Fri, 23 Feb 2018 08:24:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1519374256; bh=b7jbFNlFJxo8oDDCNI9+/7VG7DQJv+sFXCqe9vHp9P0=; h=From:To:Cc:Subject:Date:From; b=QHHU3GxlpCfj46IOEN4+XVwdH9K8fEeCI+bDcljrIXEDI1nX3uo1he53i2n9oX9gE et2Nn4j4eCJ1pjfTQ8Gxt6UTDAVH5UUeX4iLj5izDlin/KmzGeFitNIg9I+qoFAtY8 lI/954i6xjXogglTN6g+mK8Q5RlUz/oJiBfugFPo= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from blr-ubuntu-poza.qualcomm.com (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: poza@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id E2C8C607C6; Fri, 23 Feb 2018 08:24:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1519374255; bh=b7jbFNlFJxo8oDDCNI9+/7VG7DQJv+sFXCqe9vHp9P0=; h=From:To:Cc:Subject:Date:From; b=C9Hm97rwLtyvzkaHc0iCFCJ8J0DNoBGwgsFD8UbTFb8dmab0A3l12+7KMC+2zdfc9 g5Uh52xZmkOVQMS8WsnKSfkFfPzNs3GD5533pn7yKSPSa2ZpXNRLKjta5LyLob05G9 KQ0xstzRgWfO+kMWlDLl3ehny194QeWdLy5xhc1w= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E2C8C607C6 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=poza@codeaurora.org From: Oza Pawandeep To: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Sinan Kaya , Timur Tabi Cc: Oza Pawandeep Subject: [PATCH v11 0/7] Address error and recovery for AER and DPC Date: Fri, 23 Feb 2018 13:53:57 +0530 Message-Id: <1519374244-20539-1-git-send-email-poza@codeaurora.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch set brings in error handling support for DPC The current implementation of AER and error message broadcasting to the EP driver is tightly coupled and limited to AER service driver. It is important to factor out broadcasting and other link handling callbacks. So that not only when AER gets triggered, but also when DPC get triggered (for e.g. ERR_FATAL), callbacks are handled appropriately. DPC should enumerate the devices after recovering the link, which is achieved by implementing error_resume callback. Changes since v10: Christoph Hellwig's, David Laight's and Randy Dunlap's comments addressed. > renamed pci_do_recovery to pcie_do_recovery > removed inner braces in conditional statements. > restrctured the code in pci_wait_for_link > EXPORT_SYMBOL_GPL Changes since v9: Sinan's comments addressed. > bool active = true; unnecessary variable removed. Changes since v8: Fixed Kbuild errors. Changes since v7: Rebased the code on pci master > https://kernel.googlesource.com/pub/scm/linux/kernel/git/helgaas/pci Changes since v6: Sinan's and Stefan's comments implemented. > reordered patch 6 and 7 > cleaned up Changes since v5: Sinan's and Keith's comments incorporated. > made separate patch for mutex > unified error repotting codes into driver/pci/pci.h > got rid of wait link active/inactive and made generic function in driver/pci/pci.c Changes since v4: Bjorn's comments incorporated. > Renamed only do_recovery. > moved the things more locally to drivers/pci/pci.h Changes since v3: Bjorn's comments incorporated. > Made separate patch renaming generic pci_err.c > Introduce pci_err.h to contain all the error types and recovery > removed all the dependencies on pci.h Changes since v2: Based on feedback from Keith: " When DPC is triggered due to receipt of an uncorrectable error Message, the Requester ID from the Message is recorded in the DPC Error Source ID register and that Message is discarded and not forwarded Upstream. " Removed the patch where AER checks if DPC service is active Changes since v1: Kbuild errors fixed: > pci_find_dpc_dev made static > ras_event.h updated > pci_find_aer_service call with CONFIG check > pci_find_dpc_service call with CONFIG check Oza Pawandeep (7): PCI/AER: Rename error recovery to generic pci naming PCI/AER: factor out error reporting from AER PCI/ERR: add mutex to synchronize recovery PCI/DPC: Unify and plumb error handling into DPC PCI/AER: Unify aer error defines at single space PCI/DPC: Enumerate the devices after DPC trigger event PCI: Unify wait for link active into generic pci drivers/acpi/apei/ghes.c | 1 + drivers/pci/hotplug/pciehp_hpc.c | 21 +- drivers/pci/pci.c | 39 +++- drivers/pci/pci.h | 11 + drivers/pci/pcie/Makefile | 2 +- drivers/pci/pcie/aer/aerdrv.h | 30 --- drivers/pci/pcie/aer/aerdrv_core.c | 293 +------------------------- drivers/pci/pcie/aer/aerdrv_errprint.c | 1 + drivers/pci/pcie/pcie-dpc.c | 115 ++++++++++- drivers/pci/pcie/pcie-err.c | 366 +++++++++++++++++++++++++++++++++ drivers/pci/pcie/portdrv.h | 2 + include/linux/aer.h | 4 - include/linux/pci.h | 1 + 13 files changed, 534 insertions(+), 352 deletions(-) create mode 100644 drivers/pci/pcie/pcie-err.c -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc., a Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.