Received: by 10.223.185.116 with SMTP id b49csp487531wrg; Fri, 23 Feb 2018 01:54:14 -0800 (PST) X-Google-Smtp-Source: AH8x2249RlXCFh2tyiO8I270mqIqztFlij5zTS3/19mxZSEgjNap5r7yJ5UxHHIrGpPgYagY23a/ X-Received: by 10.98.225.2 with SMTP id q2mr1178736pfh.23.1519379654573; Fri, 23 Feb 2018 01:54:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519379654; cv=none; d=google.com; s=arc-20160816; b=LsRo7PNQqYcufNKwWCCodR2gRT9/pGz2Hkj4+DDo4LRyAuuDKwjCcof46d0OdE5BTd XxHF5nzfz3DO7Qt4LMfMcaeVwRmEFnAPzwlJGA8iEZKWGccwxQQOowpPpTT5fkpfumA/ 2gvmzcML92Y78gRBY8IZGMydzJFK7EQjRSptY8KAeSIlGr8XUx3agsJrivuqUzgEtb0w +fCSRbCB/O8RIg3NptEm3b8wlCJniYaw40fNLRtkmbzlJ8Wx5LHKhgbfvcpd34yLEVaH snTr3FJCS/iE/kiyCJwN6R4WbfKYcJZQOFCebbbNLxJRBmajYp8B5vpAvSEYM+cHCQNR x1wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dmarc-filter:arc-authentication-results; bh=cKpyL1KUmAQzttk2LJ0EMQOXy0BCxOB9z3fkRtLdYww=; b=lZI18RLqJMa/AyaBlk9bJ3if5HcOu62hDfy3eoX8iUT5waQQYo8FYSQmDnhah429sD rsJdChRpEgsc6rTM812fHNvHMQFshSatKTblOjhTJPj01vlv4H/CEaDZbK6E65r2kswu fy7aMk8GKE+YWE9XSuS5JzqzsvwquRWJ98oSoidG4xrMldap2Jl4jYGsy204AEnASI4m P81KP2Ee3xSUtZBu279YCBoOB1bBhwv4f9zh9lH2PFV7TFnh1UPl3Rm8vxTF1gszl/sn wUCKkFTRvxXejqTE+ngqSzwsT74aH2oSQd3eziP0EkVQNoYuCqgXtXpRi3EMFIPnHRSV 2Tnw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i11-v6si1562966plr.671.2018.02.23.01.54.00; Fri, 23 Feb 2018 01:54:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751666AbeBWJxJ (ORCPT + 99 others); Fri, 23 Feb 2018 04:53:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:50682 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751545AbeBWJxH (ORCPT ); Fri, 23 Feb 2018 04:53:07 -0500 Received: from saruman (jahogan.plus.com [212.159.75.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C35DE217A3; Fri, 23 Feb 2018 09:53:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C35DE217A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jhogan@kernel.org Date: Fri, 23 Feb 2018 09:53:02 +0000 From: James Hogan To: David Daney Cc: Colin King , Ralf Baechle , "Steven J . Hill" , David Daney , linux-mips@linux-mips.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: OCTEON: irq: check for null return on kzalloc allocation Message-ID: <20180223095301.GL6245@saruman> References: <20180222180853.11505-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yQDbd2FCF2Yhw41T" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --yQDbd2FCF2Yhw41T Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 22, 2018 at 10:10:30AM -0800, David Daney wrote: > On 02/22/2018 10:08 AM, Colin King wrote: > > From: Colin Ian King > >=20 > > The allocation of host_data is not null checked, leading to a > > null pointer dereference if the allocation fails. Fix this by > > adding a null check and return with -ENOMEM. > >=20 > > Fixes: 64b139f97c01 ("MIPS: OCTEON: irq: add CIB and other fixes") > > Signed-off-by: Colin Ian King >=20 > Acked-by: David Daney Applied to my fixes branch with 4.0+ stable tag. Thanks James --yQDbd2FCF2Yhw41T Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEd80NauSabkiESfLYbAtpk944dnoFAlqP5H0ACgkQbAtpk944 dnquzw//VizcEzcb175yh9w/aAkX32RslfjWvO87s8+78qDYNkW5MECM1iJ1RqKX MMnyBu1tUC+rwnmCA4Rug8JgufRQZ2WHcfCYDZW6Bh+TBHFzR0ZmY61Qrmpnyrni lia4pM1uOz7DFOKby7l9jYyi//9TeAK+gjDGWgu2dVYbmVKnppZkcEGnN5MJNSzl u5zFi3DHCJJnBmgyXxOr/p6LGRCU+Asgn70ry2EV6Swjn56fmGKCdlKRl9O4KTbF WnHRaQ/gobmLbS6tRrzvQtYzxTof73Yqu2pG8k8AImWFZKIYNbx1yNnoEOIQ72GT jE/lUdbhmT4okPMBKTvN6lTJ2GJZ63XKu/EyhM7GeUtbeuIrl+2toTgBf7E5hf1U YdwXjHgTmUlm6ctqPKffNAlpYGzT5SVxgzZOlvqOcsmc8TSuOzw8s1IRMDvfuFeZ O8qP+UG0reVvJ/jpo9CsxpwIbCQX18yE8smcRJKz3urx62IAzyW+IsBUPtXpHRkT NQl2wP4NUPF7ZIhpG/SGpWxrbPOLiJn95Ug8QNZkcjrM8t36U3zRjCtxskfgI9Wd nVVy/L26d7Q7oxJd0wZNzz4XMvDVo3ynlVW91AYdkklXrrT5p759G1S2h94SjrTP AH89bDl4FDBfNYp6tgKxsnjq9ESRJYTDl6WfWlJbBa9SF0xA3aI= =j8OB -----END PGP SIGNATURE----- --yQDbd2FCF2Yhw41T--