Received: by 10.223.185.116 with SMTP id b49csp495554wrg; Fri, 23 Feb 2018 02:02:57 -0800 (PST) X-Google-Smtp-Source: AH8x226hU6qWJgkV8ZfG8da0bEe8pLWaLa6DrLMQNTzz3ry8xTpvBy+uhA3CTHnm6mf7qR5qZ7Fj X-Received: by 10.99.138.74 with SMTP id y71mr1016827pgd.419.1519380177180; Fri, 23 Feb 2018 02:02:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519380177; cv=none; d=google.com; s=arc-20160816; b=cFm6AL0Cea13ufxCEzpShHi0AMBUnAMVsaxScQGHCY2Bn+DFKkOnkiJSKjGsbG2hTW QpNnd2KaHnCZBT4Z766RuRP7+i+FpSxCHg0u+J7Hjmzpe5qJLWYf8V/JuhzfRLiOTxf8 rnptl7LacV+uO+xjJyPVaCtafBc1vAm9b6btbtFrwH9w6ADz+GIk+KbXxxAAY8NYSn2K k3v+phthCslr9NxS9qjwadEU+fTPES4y2f7pGUV5dkAzIzP39oj39GY67ct0bciCAJ/X aUl6/tx1/N8hSfJ/3aHc1b6EYognHZf7pPCNKDQZvDZP0PkOkxXF/EcpMAvCRm5RMdlU s/bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:organization:references:in-reply-to:subject:cc:to:from :date:arc-authentication-results; bh=8cg+Vf6KXd2Qsuxr4wPx5x2V3vf82RU/DmoPoM6EfUY=; b=e0VccnJldqb19qenGwgURBtAJ/mCnhAevgMbIZgjKJAQDz98Y7J79yODf2RSumD0om H+HMz9g0lHMSKc3DJ5IPwsO7vU+IL2hItGyCKibEJKaqeUDVmaNTpflJvj7KmzBtJbpv BLPbcJrVlJ7O7R9jTrEnp5lOVXII4H0Zpz44upK7OVh3P4WSgB2EiilaPsgPyzkhG3hB nak65YC5qr29pljLRj0Dj0/825lOlUTaX3JC4fMoKtydYdXxmng+PNCYVmC7UIJf78e/ CamVtkDipnoPQ7Buj4YZFO3drQ6Yb3LWJiVaG8uujwiBM8wSV9HeoSQunfANRG62/Rt2 1LSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3-v6si1545127pln.468.2018.02.23.02.02.42; Fri, 23 Feb 2018 02:02:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751525AbeBWKBy (ORCPT + 99 others); Fri, 23 Feb 2018 05:01:54 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:58306 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751468AbeBWKBx (ORCPT ); Fri, 23 Feb 2018 05:01:53 -0500 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w1NA0vw1079224 for ; Fri, 23 Feb 2018 05:01:53 -0500 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0a-001b2d01.pphosted.com with ESMTP id 2gafdw3kaq-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 23 Feb 2018 05:01:52 -0500 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 23 Feb 2018 10:01:48 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 23 Feb 2018 10:01:45 -0000 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w1NA1jDr48168972; Fri, 23 Feb 2018 10:01:45 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 744014203F; Fri, 23 Feb 2018 09:54:20 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0B13542045; Fri, 23 Feb 2018 09:54:20 +0000 (GMT) Received: from ThinkPad (unknown [9.152.212.63]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 23 Feb 2018 09:54:19 +0000 (GMT) Date: Fri, 23 Feb 2018 11:01:43 +0100 From: Philipp Rudo To: Dave Young Cc: linux-s390@vger.kernel.org, AKASHI Takahiro , Heiko Carstens , x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Thiago Jung Bauermann , Eric Biederman , Michael Ellerman , Martin Schwidefsky , Andrew Morton , Vivek Goyal Subject: Re: [PATCH 00/17] Add kexec_file_load support to s390 In-Reply-To: <20180223083405.GA29498@dhcp-128-65.nay.redhat.com> References: <20180212100754.55121-1-prudo@linux.vnet.ibm.com> <20180214073543.GA12328@dhcp-128-65.nay.redhat.com> <20180214105449.1325bfbe@ThinkPad> <20180223083405.GA29498@dhcp-128-65.nay.redhat.com> Organization: IBM X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18022310-0012-0000-0000-000005B3E9A7 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18022310-0013-0000-0000-000019300658 Message-Id: <20180223110143.1747fb3f@ThinkPad> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-02-23_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1802230123 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dave On Fri, 23 Feb 2018 16:34:05 +0800 Dave Young wrote: > On 02/14/18 at 10:54am, Philipp Rudo wrote: > > Hi Dave, > > > > I just browsed AKASHI's patches (v7). The way I see it the common code changes > > are on different areas of kexec_file and shouldn't get in conflict. Only in the > > arch code (s390 and arm64) some function calls might need an update. But I have > > to take a closer look on the patches first. > > I'm tring both in local branch with both series (V8 from AKASHI and this series), > but there are indeed some conflicts, may because AKASHI factored out some arch > code from ppc/x86 to common code. I feared this would happen. I didn't have time to look at AKASHI's v8 yesterday but hope to find some today. How do you think i should handle conflicts with his patches? I don't think it is wise to include the changes into my patches as that would make AKASHI's patches a prereq for mine. Is adding one (multiple?) fixup patches on top of my series ok for you? Thanks Philipp > > > > @AKASHI: Welcome to the list. While browsing I couldn't find any > > arch_apply_relocation function for arm64. These require the biggest changes in > > my patch set. Did I just miss it or does arm64 work differently? > > > > @Dave: Happy holiday > > Thank you! > > > > > Thanks > > Philipp > > > > On Wed, 14 Feb 2018 15:35:43 +0800 > > Dave Young wrote: > > > > > Hi Philipp, > > > > > > I added AKASHI in cc, he posted arm64 kexec_file series previously. > > > I would like to read both series especially the general part, but > > > maybe at the end of this month because of a holiday.. > > > > > > From the patch log the cleanup looks nice, but still need read the > > > details. > > > > > > On 02/12/18 at 11:07am, Philipp Rudo wrote: > > > > Hi everybody > > > > > > > > resending the series as there was no reaction, yet. Furthermore i was told > > > > that Andrew and the x86 list should also be CCed, so welcome. > > > > > > > > No changes made to the patches since first time i sent them. The patches > > > > apply to the current master (v4.16-rc1). > > > > > > > > Thanks > > > > Philipp > > > > > > > > --- > > > > > > > > this series adds the kexec_file_load system call to s390. Before the system > > > > call is added there are some preparations/clean ups to common > > > > kexec_file_load. In detail this series contains: > > > > > > > > Patch #1&2: Minor cleanups/fixes. > > > > > > > > Patch #3-9: Clean up the purgatory load/relocation code. Especially remove > > > > the mis-use of the purgatory_info->sechdrs->sh_offset field, currently > > > > holding a pointer into either kexec_purgatory (ro) or purgatory_buf (rw) > > > > depending on the section. With these patches the section address will be > > > > calculated verbosely and sh_offset will contain the offset of the section > > > > in the stripped purgatory binary (purgatory_buf). > > > > > > > > Patch #10: Allows architectures to set the purgaory load address. This > > > > patch is important for s390 as the kernel and purgatory have to be loaded > > > > to fixed addresses. In current code this is impossible as the purgatory > > > > load is opaque to the architecture. > > > > > > > > Patch #11: Moves x86 purgatories sha implementation to common lib/ > > > > directory. > > > > > > > > Patches #12-17 finally adds the kexec_file_load system call to s390. > > > > > > > > Please note that I had to touch arch code for x86 and power a little. In > > > > theory this should not change the behavior but I don't have a way to test > > > > it. Cross-compiling with defconfig(*) works fine for both. > > > > > > > > Thanks > > > > Philipp > > > > > > > > (*) On x86 with the orc unwinder turned off. objtool SEGFAULTs on s390... > > > > > > > > Philipp Rudo (17): > > > > kexec_file: Silence compile warnings > > > > kexec_file: Remove checks in kexec_purgatory_load > > > > kexec_file: Make purgatory_info->ehdr const > > > > kexec_file: Search symbols in read-only kexec_purgatory > > > > kexec_file: Use read-only sections in arch_kexec_apply_relocations* > > > > kexec_file: Split up __kexec_load_puragory > > > > kexec_file: Simplify kexec_purgatory_setup_sechdrs 1 > > > > kexec_file: Simplify kexec_purgatory_setup_sechdrs 2 > > > > kexec_file: Remove mis-use of sh_offset field > > > > kexec_file: Allow archs to set purgatory load address > > > > kexec_file: Move purgatories sha256 to common code > > > > s390/kexec_file: Prepare setup.h for kexec_file_load > > > > s390/kexec_file: Add purgatory > > > > s390/kexec_file: Add kexec_file_load system call > > > > s390/kexec_file: Add image loader > > > > s390/kexec_file: Add crash support to image loader > > > > s390/kexec_file: Add ELF loader > > > > > > > > arch/powerpc/kernel/kexec_elf_64.c | 9 +- > > > > arch/s390/Kbuild | 1 + > > > > arch/s390/Kconfig | 4 + > > > > arch/s390/include/asm/kexec.h | 23 ++ > > > > arch/s390/include/asm/purgatory.h | 17 ++ > > > > arch/s390/include/asm/setup.h | 40 ++- > > > > arch/s390/kernel/Makefile | 1 + > > > > arch/s390/kernel/asm-offsets.c | 5 + > > > > arch/s390/kernel/compat_wrapper.c | 1 + > > > > arch/s390/kernel/kexec_elf.c | 149 ++++++++++ > > > > arch/s390/kernel/kexec_image.c | 78 +++++ > > > > arch/s390/kernel/machine_kexec_file.c | 291 +++++++++++++++++++ > > > > arch/s390/kernel/syscalls/syscall.tbl | 1 + > > > > arch/s390/purgatory/Makefile | 37 +++ > > > > arch/s390/purgatory/head.S | 279 ++++++++++++++++++ > > > > arch/s390/purgatory/purgatory.c | 42 +++ > > > > arch/x86/kernel/kexec-bzimage64.c | 8 +- > > > > arch/x86/kernel/machine_kexec_64.c | 66 ++--- > > > > arch/x86/purgatory/Makefile | 3 + > > > > arch/x86/purgatory/purgatory.c | 2 +- > > > > include/linux/kexec.h | 38 +-- > > > > {arch/x86/purgatory => include/linux}/sha256.h | 10 +- > > > > kernel/kexec_file.c | 375 ++++++++++++------------- > > > > {arch/x86/purgatory => lib}/sha256.c | 4 +- > > > > 24 files changed, 1200 insertions(+), 284 deletions(-) > > > > create mode 100644 arch/s390/include/asm/purgatory.h > > > > create mode 100644 arch/s390/kernel/kexec_elf.c > > > > create mode 100644 arch/s390/kernel/kexec_image.c > > > > create mode 100644 arch/s390/kernel/machine_kexec_file.c > > > > create mode 100644 arch/s390/purgatory/Makefile > > > > create mode 100644 arch/s390/purgatory/head.S > > > > create mode 100644 arch/s390/purgatory/purgatory.c > > > > rename {arch/x86/purgatory => include/linux}/sha256.h (63%) > > > > rename {arch/x86/purgatory => lib}/sha256.c (99%) > > > > > > > > -- > > > > 2.13.5 > > > > > > > > > > > > _______________________________________________ > > > > kexec mailing list > > > > kexec@lists.infradead.org > > > > http://lists.infradead.org/mailman/listinfo/kexec > > > > > > Thanks > > > Dave > > > > > > > _______________________________________________ > kexec mailing list > kexec@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec >