Received: by 10.223.185.116 with SMTP id b49csp658931wrg; Fri, 23 Feb 2018 04:54:48 -0800 (PST) X-Google-Smtp-Source: AH8x224cHueCRJqL1gJmbYC+EoTFfVSvEM5U/ANzo71afS3KPJeHeQ8djOhX+wlSNR8LOyITmgzQ X-Received: by 10.101.98.201 with SMTP id m9mr1391831pgv.100.1519390488363; Fri, 23 Feb 2018 04:54:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519390488; cv=none; d=google.com; s=arc-20160816; b=JpBHBEcvm0MeV5qSOa4OJX5jn9w3MPFiM3ydI9m3zveHikVjSSb10svio+eV+ZDLp0 s2FNaEdHmfAebLmEwYsp6Isfdr+NzissWamWpSTmQCnJ3FZ0i2YWdQq7m8lLQHVkJgEQ hx4Z6WHWm+Et3b76Q27eJT3sXuqEZsV+muMz8thDWmQvmJhCccRh1zFO4GJ4826byL+c mD8TYDsrdDETOboRCBN1z62AnjREilTBsohgYaVzKgQCArZ13frv7iGHoAjL8bv+2+iF gak8/BsWuSOS1u5DeECUDSnOQ3s4tRUHBembk/6SXEKUS1yRz3jwYPzRmG8Kx/6XaKOz 4m6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=rCOLCFV3wIQ0EoOVYF2vYGWyLSv4W2nlUVSZL9S0iho=; b=grgRl69bGW+aV3vSwfGbW+uIYCPcV7Ejm5zscuSrBdmKe6xhBzmdvawDnNjPr/Ybzg KO3T0vSc6OkeQj1uc83Y0cn+lUCNrlkOgaxn912Uui/hk/5/6do1Ce55wpv0Bg+sdNfe 5iEu4mj+qRY1uzNPeMOCJ0vdE57lNKe9sxUTyqOuDbyrFo/rxqiOoE4hgUSRDxfww6CV 5o1QoLiNVMvb8+xatbmuBsxIC3h+2M7S/lyedvLx3uEJkM87FinbzRsfix/iW0zldhso Ww3ueH+I4QTrG/aIvgA7aJmmbcP1I6PjxSZEWSRdtSmfyuM9dlr6nt6d0vYHTAc6g+qx iZxg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o17si1490805pgc.665.2018.02.23.04.54.34; Fri, 23 Feb 2018 04:54:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751742AbeBWMw6 (ORCPT + 99 others); Fri, 23 Feb 2018 07:52:58 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:53952 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751423AbeBWMwD (ORCPT ); Fri, 23 Feb 2018 07:52:03 -0500 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx08-.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id w1NCnViJ015357; Fri, 23 Feb 2018 13:51:22 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2g9bpka35q-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 23 Feb 2018 13:51:22 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 0389E31; Fri, 23 Feb 2018 12:51:22 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag5node3.st.com [10.75.127.15]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id C01584DB9; Fri, 23 Feb 2018 12:51:21 +0000 (GMT) Received: from localhost (10.75.127.45) by SFHDAG5NODE3.st.com (10.75.127.15) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Fri, 23 Feb 2018 13:51:21 +0100 From: Fabrice Gasnier To: CC: , , , , , , , , , , Subject: [PATCH 5/7] iio: adc: stm32-dfsdm: misc style improvements and fixes Date: Fri, 23 Feb 2018 13:50:59 +0100 Message-ID: <1519390261-25453-6-git-send-email-fabrice.gasnier@st.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1519390261-25453-1-git-send-email-fabrice.gasnier@st.com> References: <1519390261-25453-1-git-send-email-fabrice.gasnier@st.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.75.127.45] X-ClientProxiedBy: SFHDAG7NODE3.st.com (10.75.127.21) To SFHDAG5NODE3.st.com (10.75.127.15) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-02-23_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Misc fixes & style improvements: - checkpatch warns about line over 80 characters. - remove extra spaces and a blank line (e.g. checkpatch --strict) - remove bad error message always printed in probe routine. Signed-off-by: Fabrice Gasnier --- drivers/iio/adc/stm32-dfsdm-adc.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c index 01422d1..57bcb45 100644 --- a/drivers/iio/adc/stm32-dfsdm-adc.c +++ b/drivers/iio/adc/stm32-dfsdm-adc.c @@ -253,7 +253,8 @@ static int stm32_dfsdm_start_filter(struct stm32_dfsdm *dfsdm, DFSDM_CR1_RSWSTART(1)); } -static void stm32_dfsdm_stop_filter(struct stm32_dfsdm *dfsdm, unsigned int fl_id) +static void stm32_dfsdm_stop_filter(struct stm32_dfsdm *dfsdm, + unsigned int fl_id) { /* Disable conversion */ regmap_update_bits(dfsdm->regmap, DFSDM_CR1(fl_id), @@ -337,7 +338,7 @@ static int stm32_dfsdm_channel_parse_of(struct stm32_dfsdm *dfsdm, "st,adc-channel-types", chan_idx, &of_str); if (!ret) { - val = stm32_dfsdm_str2val(of_str, stm32_dfsdm_chan_type); + val = stm32_dfsdm_str2val(of_str, stm32_dfsdm_chan_type); if (val < 0) return val; } else { @@ -349,7 +350,7 @@ static int stm32_dfsdm_channel_parse_of(struct stm32_dfsdm *dfsdm, "st,adc-channel-clk-src", chan_idx, &of_str); if (!ret) { - val = stm32_dfsdm_str2val(of_str, stm32_dfsdm_chan_src); + val = stm32_dfsdm_str2val(of_str, stm32_dfsdm_chan_src); if (val < 0) return val; } else { @@ -1093,7 +1094,6 @@ static int stm32_dfsdm_adc_probe(struct platform_device *pdev) char *name; int ret, irq, val; - dev_data = of_device_get_match_data(dev); iio = devm_iio_device_alloc(dev, sizeof(*adc)); if (!iio) { @@ -1161,7 +1161,6 @@ static int stm32_dfsdm_adc_probe(struct platform_device *pdev) if (ret < 0) goto err_cleanup; - dev_err(dev, "of_platform_populate\n"); if (dev_data->type == DFSDM_AUDIO) { ret = of_platform_populate(np, NULL, NULL, dev); if (ret < 0) { -- 1.9.1