Received: by 10.223.185.116 with SMTP id b49csp1029094wrg; Fri, 23 Feb 2018 10:36:59 -0800 (PST) X-Google-Smtp-Source: AH8x227PhYjvzvB7moGqa19lmmje9ot58iyBDiymB3KtVzE+2jYOh3HTekxFIPaaHKvem5oyB1Ii X-Received: by 10.98.252.22 with SMTP id e22mr2640731pfh.235.1519411019499; Fri, 23 Feb 2018 10:36:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519411019; cv=none; d=google.com; s=arc-20160816; b=EifdWJxfutLPeJ3gEH0iMBZm8xfn+abXvMUHwdzmbWFEZiQldR0gRKIPnp4pKNa/pt fWF/Az3JfK5yhLokMIUkkFRO0zM5xvb6tAykChsVGx8nwsJNRXcH29Lfda8s0vu0NzU3 h9oVj96iSo/7RpzxZrM1jtAHzThSCCBbptENVWc5balDO9+pFlUFTuT6LlOdVH6710MW tF27bEzwSqF11UJiRT6Apxtz554Smr8wFm7uhiKXsWMmYv6LBFKkgJARG4E1pxT1Hhbt 59di3GI80MvFqPjoqQu5QNO/2FpyfIHNU3REV1hGdUTudyjrJlQcJXME/WHfurFM1D06 H+4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=0HUeRsc4WeX+r+RRdHJHH5wKPc8sYNo5xdAn0EKBvpc=; b=cROn+ptZSfzvKmrtG4R8bx8HhW/buYzMYo6cUHJVG9QE4vN+wwatzzxcVh4TjyvUkC sGFksjfcBgi68TdLxwKO9acHbMwK/vBI+HpjhmY+UPPwYjnukudHVq2rwt2tI/rBwh6V +6Cmcmshkdbe1wPcuwOr0GGZJNURb0GEYsHeJ6GwXz2cqY3uPLNF/UBOGO/zkqlTHsm4 ymBTkf8GxjKSE/GxHJEiNBme3H90ZclEFS891Jh0oI/YBhCHCSGhj2t4hjtopeMZfjO3 Nuar5HvD1dasEZAuovYHdHHeFttGWtHLV+EE4koWrkDy88PuIGqJBrscuPYrrr52xkWv TlHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x189si1814435pgb.216.2018.02.23.10.36.45; Fri, 23 Feb 2018 10:36:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753887AbeBWSfm (ORCPT + 99 others); Fri, 23 Feb 2018 13:35:42 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:37372 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753875AbeBWSfi (ORCPT ); Fri, 23 Feb 2018 13:35:38 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id C4CEC11D8; Fri, 23 Feb 2018 18:35:37 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann Subject: [PATCH 4.4 063/193] isdn: icn: remove a #warning Date: Fri, 23 Feb 2018 19:24:56 +0100 Message-Id: <20180223170335.827722797@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180223170325.997716448@linuxfoundation.org> References: <20180223170325.997716448@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Arnd Bergmann commit 01ed1e1504ac83a8b0b365c9f55d3427babbd7d9 upstream. The icn driver currently produces an unconditional #warning whenever we build it, introduced by Karsten Keil back in 2003: #warning TODO test headroom or use skb->nb to flag ACK Karsten's original commit (from BitKeeper) contains this description: - here are lot of bugs left, so ISDN is not stable yet but I think it's really time to fix it, even if it need some cycles to get it right (normally I'm only send patches if it works 100% for me). - I add some additional #warnings to address places which need fixing (I hope that some of the other ISDN developer jump in) Apparently this has not happened, and it is unlikely that it ever will, given that the driver doesn't seem to work. No substantial bug fixes other than janitorial cleanups have happened in the driver since then, and I see no indication that anyone who patched it had the hardware. We should probably either remove the driver, or remove all of i4l, but for now, this shuts up the distracting #warning by turning it into a comment. Signed-off-by: Arnd Bergmann Link: http://git.meleeweb.net/linux.git/commit/?id=b0deac0886b0056765afd149e9834373b38e096b Signed-off-by: Greg Kroah-Hartman Signed-off-by: Greg Kroah-Hartman --- drivers/isdn/icn/icn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/isdn/icn/icn.c +++ b/drivers/isdn/icn/icn.c @@ -718,7 +718,7 @@ icn_sendbuf(int channel, int ack, struct return 0; if (card->sndcount[channel] > ICN_MAX_SQUEUE) return 0; -#warning TODO test headroom or use skb->nb to flag ACK + /* TODO test headroom or use skb->nb to flag ACK */ nskb = skb_clone(skb, GFP_ATOMIC); if (nskb) { /* Push ACK flag as one