Received: by 10.223.185.116 with SMTP id b49csp1045557wrg; Fri, 23 Feb 2018 10:56:12 -0800 (PST) X-Google-Smtp-Source: AH8x224CFBHj3HS9TQq16NMdVpgouSDEsVPabsX1IvaPrCoOBgZ7Dwou9rIbYTMwHMD3zqL8DXCu X-Received: by 2002:a17:902:d891:: with SMTP id b17-v6mr2514076plz.241.1519412172582; Fri, 23 Feb 2018 10:56:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519412172; cv=none; d=google.com; s=arc-20160816; b=pG1QdzDESIzPVZJE3iZPA1xSoXEeW6oOi/DMivqpDh7I/r+uFXcr2zbvWYsTK5c+Vg W/whfZBWITgXVtpHwR9ETqIoDw6MQL79y80ak80r499F1rWjRtb2kojaL1Te0rvRAej4 r7sNJ6EHQQSD5+pIxzeXs+cuPhwqTk8T/SWX1MWB08f40sBRzfTiw4QjUx6r7v8lhLnl iKoIZC7dWtu/87UUX1zGP/lNRW12xulP+K+qNmyABT/4oGQuiPSYp8s19TVw8B8/XgHy sFkzDMgEazxjpSQALaHs5V+tURgGheYlax+W/kQdleLpUOHeJOT3MvSHyQ7AaIrr+NAj 1iIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=qc6i25+JDID8p2V3EN9h2bszPyJwdPxFeEPfTY+3PlM=; b=uOp40ex0xsG0wkAvcv5oDCKlFXn5DStjVoG+4W+0M855BQ9O9znCoUSHC30GLq+4rU OgTI0Rfn2TdVuFxC4q73klEsdC6nFI1EyyzySuTuo2symOWMEgtCuUtuS9iD79aT4/ca E473j/tpl/knlKa/t2B+S5BM7NNKc3IkgFbdVuhABfhSoztyUm89zpqXGQLRMCBMQy74 ebM2Z0V4oVQX7lqOr2BHi3ZatS4ChT2W32xfZ+TiOKA+CnDLoS7SyMMseno9ZLwG2qRx L7MjLrq4RM1nxtH3ybzFvI1VzJc28j9yS2HAnt/+nJthXSboHe3726mZbfWeSbNWFVnb d3LQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l14si1818764pgc.615.2018.02.23.10.55.57; Fri, 23 Feb 2018 10:56:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965076AbeBWSzG (ORCPT + 99 others); Fri, 23 Feb 2018 13:55:06 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:48030 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935146AbeBWSzC (ORCPT ); Fri, 23 Feb 2018 13:55:02 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id E098911E9; Fri, 23 Feb 2018 18:55:01 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Shaohui Xie , Yangbo Lu , Claudiu Manoil , Andrew Lunn , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 127/159] gianfar: Disable EEE autoneg by default Date: Fri, 23 Feb 2018 19:27:15 +0100 Message-Id: <20180223170758.526380185@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180223170743.086611315@linuxfoundation.org> References: <20180223170743.086611315@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Claudiu Manoil [ Upstream commit b6b5e8a691185606dfffff3198c89e3b4fd9d4f6 ] This controller does not support EEE, but it may connect to a PHY which supports EEE and advertises EEE by default, while its link partner also advertises EEE. If this happens, the PHY enters low power mode when the traffic rate is low and causes packet loss. This patch disables EEE advertisement by default for any PHY that gianfar connects to, to prevent the above unwanted outcome. Signed-off-by: Shaohui Xie Tested-by: Yangbo Lu Signed-off-by: Claudiu Manoil Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/freescale/gianfar.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/drivers/net/ethernet/freescale/gianfar.c +++ b/drivers/net/ethernet/freescale/gianfar.c @@ -1792,6 +1792,7 @@ static int init_phy(struct net_device *d GFAR_SUPPORTED_GBIT : 0; phy_interface_t interface; struct phy_device *phydev; + struct ethtool_eee edata; priv->oldlink = 0; priv->oldspeed = 0; @@ -1816,6 +1817,10 @@ static int init_phy(struct net_device *d /* Add support for flow control, but don't advertise it by default */ phydev->supported |= (SUPPORTED_Pause | SUPPORTED_Asym_Pause); + /* disable EEE autoneg, EEE not supported by eTSEC */ + memset(&edata, 0, sizeof(struct ethtool_eee)); + phy_ethtool_set_eee(phydev, &edata); + return 0; }