Received: by 10.223.185.116 with SMTP id b49csp1047510wrg; Fri, 23 Feb 2018 10:58:29 -0800 (PST) X-Google-Smtp-Source: AH8x226bv0lWRgDVdL1fEVNW17wUa2Xo1371cL5yDc8fQRDRGuo3HOu5RfYbMCer7bUPGj6Wje/Q X-Received: by 10.101.86.198 with SMTP id w6mr2153890pgs.434.1519412309644; Fri, 23 Feb 2018 10:58:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519412309; cv=none; d=google.com; s=arc-20160816; b=mEc/+rHQSXb7QRDiBZyJFZuzAdEmGz1eNtp9gg05cVdxZN+XW1MYF+Xphj1L4gGb57 X3CozIjYdhaw/QcFjGY801p+CYBd4XIVWjBPQeuvJjkRHuHb0aedvJ8bRjNHQr33DGHz U6+zAv4r3wXDAQhzvipktcs3zNFtWwDXahz8p+VcI5o4l53Eb0+E3qDThD5MZ0oo6s+L nbRG2uI9fQfAovwdaybl3YTCixdE9yAvTCazoeJS4wPK5WouBEGgp3JlHDl7ITD5DHe2 Kd9f/fdy4yFlhPiVFLUNq5mL3skxR6W9xj8MxAdLedooGLjQktb7V5rA3c5wA1JLaKPG y5BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=nUX8ZZa7c1xfwz40XpDT/pAnUGs369XxAKsgn5H44ZQ=; b=rsnBlgEDLxEmmb+EP8qabt6a9tbvcBzGAWVTp51veop6Z6lIwK0k5RQEMao3UmwPd6 x8A1tv+IrDMuFpTG4yJho0sMimcxpQAYOzl+LvolE+i8HLd6qHU3rWkOkAXyA+Y7ERsH sIL97aCCKkw0YRHgi2BBe7G2u19xeLXVI1P4hGiLyD0+EGObp9YAy0PGhL136wxCJ204 2ZTsd6+bKMJGTqYUeq46ylbz3TvwGDLD2vgW6Mn8Q5syBdt8KiYp1WQMb+3l84cdJWfn BTc+I/pAdsKswOmmcZsOI92nbZ49IV3ZIj4gLvKCFUWUEx6hEe4wx/30DJWia0YHEqDr jYgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l18si1841866pgn.103.2018.02.23.10.58.14; Fri, 23 Feb 2018 10:58:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935674AbeBWS4v (ORCPT + 99 others); Fri, 23 Feb 2018 13:56:51 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:49338 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935600AbeBWS4s (ORCPT ); Fri, 23 Feb 2018 13:56:48 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 1ACBF12F0; Fri, 23 Feb 2018 18:56:38 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nogah Frankel , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 112/159] net_sched: red: Avoid devision by zero Date: Fri, 23 Feb 2018 19:27:00 +0100 Message-Id: <20180223170756.883664333@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180223170743.086611315@linuxfoundation.org> References: <20180223170743.086611315@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nogah Frankel [ Upstream commit 5c472203421ab4f928aa1ae9e1dbcfdd80324148 ] Do not allow delta value to be zero since it is used as a divisor. Fixes: 8af2a218de38 ("sch_red: Adaptative RED AQM") Signed-off-by: Nogah Frankel Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- include/net/red.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/include/net/red.h +++ b/include/net/red.h @@ -179,7 +179,7 @@ static inline void red_set_parms(struct p->qth_max = qth_max << Wlog; p->Wlog = Wlog; p->Plog = Plog; - if (delta < 0) + if (delta <= 0) delta = 1; p->qth_delta = delta; if (!max_P) {