Received: by 10.223.185.116 with SMTP id b49csp1060997wrg; Fri, 23 Feb 2018 11:11:57 -0800 (PST) X-Google-Smtp-Source: AH8x226En+Ro/XuwP35B3dgyVcByFlQYh5UkSFj32Pw3H2YAzBrpZCu+Pl3y0VHaOwqDsFRIVTQE X-Received: by 10.99.95.15 with SMTP id t15mr2153726pgb.183.1519413117182; Fri, 23 Feb 2018 11:11:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519413117; cv=none; d=google.com; s=arc-20160816; b=L4JaFQ+BU7CZAH5vTQkB2fW4sbISzBPO9TESxmZei888MRFhFz8Tsy+bTOpSKpcsr8 ONpKdwgO35bFmPuZw+XciqawtsuWu2m9p2ZMyVaOZaB7MYXAZ+pxda89YB4fo+T2Hh+L yqYVN5SyAN6lYOVTj6P+zrZOTDQbfmt2yVJqqmzgUWyp6scWl9wbyQPUn8LHW7SSk93N bLkCIQF2+Iv2I+o0Pe0I4TgVJl9o1vnVgbfiaeFZPkP/fYtKdJsbTZ4nqJnsepj6LXy8 qkeK1wwyY0om0BapwhMLYvspQ6ZFZxdF4Akdqx+KlePNzTIrlP2/Of/oyTCVSpJuFz+r CqSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=Z7yFbGI5tPSI/o7Ld7wGXEwxGc6HEZF3jZQ2MK+/Re8=; b=YiSwQAf1p75GRI3vhKfiw5B1+fzzoQjxecL1paqf2TQz/sA7wHNEvXkE3InGe2u9gj wQW8HpN48dQDLX9ImPCn4p6s/MsGVxbKdMpRMjlMbGN5j2UQpivp3qT0XGsTjEyZ54sV vFzkfBUb4EhlTgRsKnPxpDyi31rh2ZTiQyvrs9WQPtWP1CAXP37ZETZ8LLlkXPfeAwt8 30GnqWihryMFY20ZzbA7fqfL6wh9McVndt2O3DyorgXcFZdVo0nStWgG4N8PvyNi+TpG cwXEz/aNtQtoMHVc7P8vbZyVOKcZx02uvXAeS+jLwxhj+/zU/aUv4EuVoklK1nCXJlYM CI0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r12-v6si2280761plj.290.2018.02.23.11.11.42; Fri, 23 Feb 2018 11:11:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965067AbeBWS46 (ORCPT + 99 others); Fri, 23 Feb 2018 13:56:58 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:49470 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935600AbeBWS4z (ORCPT ); Fri, 23 Feb 2018 13:56:55 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id DDBAF12F2; Fri, 23 Feb 2018 18:56:41 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jia-Ju Bai , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 153/159] hippi: Fix a Fix a possible sleep-in-atomic bug in rr_close Date: Fri, 23 Feb 2018 19:27:41 +0100 Message-Id: <20180223170801.455391651@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180223170743.086611315@linuxfoundation.org> References: <20180223170743.086611315@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jia-Ju Bai [ Upstream commit 6e266610eb6553cfb7e7eb5d11914bd01509c406 ] The driver may sleep under a spinlock. The function call path is: rr_close (acquire the spinlock) free_irq --> may sleep To fix it, free_irq is moved to the place without holding the spinlock. This bug is found by my static analysis tool(DSAC) and checked by my code review. Signed-off-by: Jia-Ju Bai Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/hippi/rrunner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/hippi/rrunner.c +++ b/drivers/net/hippi/rrunner.c @@ -1381,8 +1381,8 @@ static int rr_close(struct net_device *d rrpriv->info_dma); rrpriv->info = NULL; - free_irq(pdev->irq, dev); spin_unlock_irqrestore(&rrpriv->lock, flags); + free_irq(pdev->irq, dev); return 0; }