Received: by 10.223.185.116 with SMTP id b49csp1063082wrg; Fri, 23 Feb 2018 11:14:26 -0800 (PST) X-Google-Smtp-Source: AH8x224IQQnKiGlXsOF6FKWZRdRU0fHwlI5FJa6uKLI2a0DQaedEez/gMEccXzSJeePEkhxP+a7Y X-Received: by 10.98.110.71 with SMTP id j68mr1021910pfc.93.1519413266613; Fri, 23 Feb 2018 11:14:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519413266; cv=none; d=google.com; s=arc-20160816; b=Dr137dFoZZMRDpNyp/v8rfuhKj3QiLMkG1QGeCXvfOJiSEtHjtGOxRgJIxBLLr4U50 ingITipgsDCadBfXuHeP49aSE2XmjWoY0oTJlQB+UXG/kogrm4gGiDPu0yPPgbXkXGsY PwC88et4TWnYSlum7/i5R2Jwg5Rwo336DRXGkgnQz2X4WZTd3Fe1lD+/bwO1sNVVvKal /61aSoSmGAc5lzbt8EJtJJCLwsB6SmoffNQicuo5cJLofSjj0CQ+C3PkzYyoAUpVs1Fn mw0kIAVhg1RZASvJpm55T41aJ3w1OC8mc9xUzUj1tFPuGvzdBaT7tZGq7VY1QXUHADId mUaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=aeKtqPtPXqNLaEzXRrKictfO9CDrf0Xq7Mb3WcHufBE=; b=pjH2FngOJfxynliFYNzLt8L3AZFR9NgGRigtsPOB2Q+8k5rAjv7Ga2EZgd6BumZkQ8 TF5elHxoIbE/kPYfI0MeI3rTSo102jB/c5p6L9TMiQ3VvZvi6tRXk/5Bcfx8YZ1MfBYl iZ0LHunqmPk31EByLQgNFQY7RoBfhZWwQT6eCo63j56LcXGt1qEuQ5n3ORGwTp+koZlP G0hecB6yd2TKloiSkDUmi4zrLwg2tbxm/rDnFkIS2HtzID9I8R40Mb9eiENSJZp86NiM EctAWAiKjvqqyDsQlzTVKaHylv6Q6Ki+8ctaV8HrpstgzY/Q6KHorCATkz1LIPIQZVOM VUfw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r1-v6si2166207plb.453.2018.02.23.11.14.12; Fri, 23 Feb 2018 11:14:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965219AbeBWSz6 (ORCPT + 99 others); Fri, 23 Feb 2018 13:55:58 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:48430 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965199AbeBWSzz (ORCPT ); Fri, 23 Feb 2018 13:55:55 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 490511225; Fri, 23 Feb 2018 18:55:54 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stefan Schake , Eric Anholt , Sasha Levin Subject: [PATCH 4.14 143/159] drm/vc4: Release fence after signalling Date: Fri, 23 Feb 2018 19:27:31 +0100 Message-Id: <20180223170800.313006422@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180223170743.086611315@linuxfoundation.org> References: <20180223170743.086611315@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Stefan Schake [ Upstream commit babc8110057cb9ca542c3c1666cbda4e8ccf9250 ] We were never releasing the initial fence reference that is obtained through dma_fence_init. Link: https://github.com/anholt/linux/issues/122 Fixes: cdec4d361323 ("drm/vc4: Expose dma-buf fences for V3D rendering.") Signed-off-by: Stefan Schake Signed-off-by: Eric Anholt Reviewed-by: Eric Anholt Link: https://patchwork.freedesktop.org/patch/msgid/1512236444-301-1-git-send-email-stschake@gmail.com Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/vc4/vc4_gem.c | 4 +++- drivers/gpu/drm/vc4/vc4_irq.c | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) --- a/drivers/gpu/drm/vc4/vc4_gem.c +++ b/drivers/gpu/drm/vc4/vc4_gem.c @@ -829,8 +829,10 @@ vc4_complete_exec(struct drm_device *dev /* If we got force-completed because of GPU reset rather than * through our IRQ handler, signal the fence now. */ - if (exec->fence) + if (exec->fence) { dma_fence_signal(exec->fence); + dma_fence_put(exec->fence); + } if (exec->bo) { for (i = 0; i < exec->bo_count; i++) --- a/drivers/gpu/drm/vc4/vc4_irq.c +++ b/drivers/gpu/drm/vc4/vc4_irq.c @@ -139,6 +139,7 @@ vc4_irq_finish_render_job(struct drm_dev list_move_tail(&exec->head, &vc4->job_done_list); if (exec->fence) { dma_fence_signal_locked(exec->fence); + dma_fence_put(exec->fence); exec->fence = NULL; } vc4_submit_next_render_job(dev);