Received: by 10.223.185.116 with SMTP id b49csp1065264wrg; Fri, 23 Feb 2018 11:16:50 -0800 (PST) X-Google-Smtp-Source: AH8x227C3MGR7/XmlPRVzoDWlLo2YeiiYQvf+37iomvzrO/MxzgaiHJfJZwj7Xu47eH2Eb1LegWP X-Received: by 10.98.200.80 with SMTP id z77mr2688142pff.85.1519413410642; Fri, 23 Feb 2018 11:16:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519413410; cv=none; d=google.com; s=arc-20160816; b=QzKF/2mVY2XVfr6DgyukUl6sgguwdP8cbK4bX0QGzxrs7FbmYDDm27FYUjVxJXjjBM wbujgKGhpzdpLBxCGU3x54OsSQPiFhzCRkKY5Ayroqpfb53s24oLAsGclJOHTppOMyRM h11ZG/+MVue5/CvgZMnYWIpSB6k+yb87ehJ7TRPR0N8izXl7GuIVtXy+YlPOAt17EObE CuYNNQmbKNnNWw1nBckDN9qPJCKiJ2Pw0FSBcPKytLALwTiIna5VPuwe4fi/8wWarFyg 1tg7WFVuAYxT6bc3xJ1yxnx/ShCU+gDwO0c80i3V0iRhZrDiWRbpyVjxGCXFKlrZoFhI mGnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=3m1sr0LrL+PjOqHPfk+lF4hS37R2gKR3corz4Zp2ZWc=; b=F/evIhmKnnpel26z+25MJqLWEpIaVXmiSjuwEjmhZPwe2pmRB69TFlz+KSALnDDyWu dyNWH8o9zqIYK2EcD6+n4HBWab5S8zd41hURcZwCo43elXCIClOYpQH9OPnO4jKeaw4H 1sWNRDapukYEyBBby4rNBsOJ0Di8bKFpz5Sr9KRlxrP1u5hwTWsWLa7UYEtvIVNvpg/E E8kQrEDxPuCW6rR0l31VL5p2oObCkUJtzZTqByK1fH2l/ELMDmrT8MittBeypTsM9Q9u hL54z1r5BaBmt4OStUKI2z1TQa3KZlNPuzy6Lab2UgDRnDlPK8UtHBo7ouz2X237V5RU a8Lg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g11si1857012pgo.717.2018.02.23.11.16.36; Fri, 23 Feb 2018 11:16:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753591AbeBWTOu (ORCPT + 99 others); Fri, 23 Feb 2018 14:14:50 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:48308 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935551AbeBWSzi (ORCPT ); Fri, 23 Feb 2018 13:55:38 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id A36431225; Fri, 23 Feb 2018 18:55:37 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takuo Koguchi , Maxime Ripard , Mark Brown , Sasha Levin Subject: [PATCH 4.14 138/159] spi: sun4i: disable clocks in the remove function Date: Fri, 23 Feb 2018 19:27:26 +0100 Message-Id: <20180223170759.750887009@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180223170743.086611315@linuxfoundation.org> References: <20180223170743.086611315@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Takuo Koguchi [ Upstream commit c810daba0ab5226084a56893a789af427a801146 ] mclk and hclk need to be disabled. Since pm_runtime_disable does not disable the clocks, use pm_runtime_force_suspend instead. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Takuo Koguchi Acked-by: Maxime Ripard Signed-off-by: Mark Brown Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/spi/spi-sun4i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/spi/spi-sun4i.c +++ b/drivers/spi/spi-sun4i.c @@ -525,7 +525,7 @@ err_free_master: static int sun4i_spi_remove(struct platform_device *pdev) { - pm_runtime_disable(&pdev->dev); + pm_runtime_force_suspend(&pdev->dev); return 0; }