Received: by 10.223.185.116 with SMTP id b49csp1066583wrg; Fri, 23 Feb 2018 11:18:11 -0800 (PST) X-Google-Smtp-Source: AH8x225QLpWLYKmuUVeCCHlQnKrV+xL7zK5qCFFlCu5pdi/5LKIGY3Y/bsKEQcf9Kzp/hVbs1DHp X-Received: by 2002:a17:902:5819:: with SMTP id m25-v6mr2620753pli.248.1519413490868; Fri, 23 Feb 2018 11:18:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519413490; cv=none; d=google.com; s=arc-20160816; b=jq62rtjr1wWu1tPWE/eJSem7+p4vRi9VnD3aiWUhVygwN5WFg1Jglj4mCnlORYXTZe k5N19MHmeKlGdqfN7klHPDZREzOPv+TqtMy6k+Sc9abkJlCdOeJ191hzSvmkIiqhL770 LBXEod9Xu+bG/qi+vptOO8T4kUYgOLdde2wfiXI3E1JMuxXYrhVq+kLByx7k7Wcs1LN2 KYaIfKz2UISVgioo3mUHmcqGBi+sQioVmi16ReF1TjmnOwPChH2eP5VpNK55ik7JFOWe cCdWT4bJl8JxJa9U7PIdZgu+1z5l91IacFdOE0WgHF+VHPTtpRgOCVH3wNfoWtP/gxUh +fsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=RY6hPgOGNQQ5W9ZrcK+hHPGse2mV6rCwZTwIceyYiEg=; b=yFNpjRXlCV6kKlNal5QkfXXku1Ws23lCOE5AMFmsOxDZnu2yON7KtsLdLkD2bLNXMr ii1UjRC4vRKlTGlTJENTYcPnvLDjDv+/GbwfXQO92fA7FMRdpSo129R2LeWuDS05LwBH gzf0HuSEZPD779zOS79gEWOiQuokcr8zf/OPokctiJblj63AMz+gVHxr/kf8tGufdmDZ ixDVFeTn7caIMXvMmrKdZl/4gYPlQZM44IuiLUPo2KLOxAm6guA+syleK/OpLn0ogpKQ RoicDW+zPPOpMB8b4DaT8JzRBp0DUZAWWilXE3Cs0qxBKP0Zix2w9f5OajseBEJgJBn3 eIxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a13si2221297pfn.314.2018.02.23.11.17.56; Fri, 23 Feb 2018 11:18:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965123AbeBWSzR (ORCPT + 99 others); Fri, 23 Feb 2018 13:55:17 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:48092 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965092AbeBWSzN (ORCPT ); Fri, 23 Feb 2018 13:55:13 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id EBDC91225; Fri, 23 Feb 2018 18:55:12 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Dave Jiang , Vinod Koul , Sasha Levin Subject: [PATCH 4.14 131/159] dmaengine: ioat: Fix error handling path Date: Fri, 23 Feb 2018 19:27:19 +0100 Message-Id: <20180223170758.957755619@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180223170743.086611315@linuxfoundation.org> References: <20180223170743.086611315@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Christophe JAILLET [ Upstream commit 5c9afbda911ce20b3f2181d1e440a0222e1027dd ] If the last test in 'ioat_dma_self_test()' fails, we must release all the allocated resources and not just part of them. Signed-off-by: Christophe JAILLET Acked-by: Dave Jiang Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/dma/ioat/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/dma/ioat/init.c +++ b/drivers/dma/ioat/init.c @@ -390,7 +390,7 @@ static int ioat_dma_self_test(struct ioa if (memcmp(src, dest, IOAT_TEST_SIZE)) { dev_err(dev, "Self-test copy failed compare, disabling\n"); err = -ENODEV; - goto free_resources; + goto unmap_dma; } unmap_dma: