Received: by 10.223.185.116 with SMTP id b49csp1070560wrg; Fri, 23 Feb 2018 11:22:46 -0800 (PST) X-Google-Smtp-Source: AH8x226cp2F2Mu5xFXF3lYloNBxgcPYRWtphgh11mm80yJ4R93qOKQ/OmBqvbI7ImhS5bFy5Z/Yl X-Received: by 10.99.114.24 with SMTP id n24mr2115460pgc.400.1519413766861; Fri, 23 Feb 2018 11:22:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519413766; cv=none; d=google.com; s=arc-20160816; b=A7fLWCWMkQ7rEk/MpNicjNxiR/ypz6xI7w1IxCFYKRbiChe2RyxTidotaqVpWnWRRd 69IwxrvT7xvQAHpnSDGMuidcH8PG2/+06xmciAiIe7DSJO81kZvHyBMqhXcs8FCt0OTG O0MeSl+LQh4zZXYU9Mn3p8Y7pp04TpR6FGpTp1wxk5XjtGlJW2/5RHRY7XE1aPAB7fti Q7XYonbBZy3bP/nznBccCnvtt6pabp1a4P1p3K5rkyyEZT5S1G8gC7x9uRBhwgNnh9Ay IZpMUieLOk2zk/5hVCPH/8ADNb0hRzE4SnzH0dG6k9e2RUs/t5m/UfWNRIoE84jHxH5F OA4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=L95GNYTfeRAmzIcfaAOzrQdSN6qNFxEloZIbi/GJ17Q=; b=kwpNcF/manYIW7uQXZuPN7SDeKsVF4MohihVTfuO7WHP6GGGfFgrPRsJIQ8Hu9GbaX T1hLRPiZ7mGYzpv8MQyW+LVB7nDEIUZu9GNe26luY/zUH7KHfDurwPnBzu+xtmALqKt4 GcJdlrSuiqG39uPceiuGkdm6CT+7nrjhjrCs+iqt3A2xE1UUmbv4GIEwsCBcWJPNr0Us JIueVaTIdr6JI4WPUwo5F7TavHfwY3QnO5IU3vDdrUEW2FPmqE1+HMzv9X4KrD5rf0Qz U7BLUDpc9TX4QkrHbm/DjikAQWMTWW2hZb2dtRsb4amc6+dcxI0dDacHXITFDsVDgPDC mfWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id az5-v6si2165396plb.71.2018.02.23.11.22.32; Fri, 23 Feb 2018 11:22:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964841AbeBWSxy (ORCPT + 99 others); Fri, 23 Feb 2018 13:53:54 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:47530 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964828AbeBWSxw (ORCPT ); Fri, 23 Feb 2018 13:53:52 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id D4E2011C1; Fri, 23 Feb 2018 18:53:51 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Matthew Wilcox , Jonathan Corbet , Will Deacon , Sasha Levin Subject: [PATCH 4.14 101/159] scripts/kernel-doc: Dont fail with status != 0 if error encountered with -none Date: Fri, 23 Feb 2018 19:26:49 +0100 Message-Id: <20180223170755.666412125@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180223170743.086611315@linuxfoundation.org> References: <20180223170743.086611315@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Will Deacon [ Upstream commit e814bccbafece52a24e152d2395b5d49eef55841 ] My bisect scripts starting running into build failures when trying to compile 4.15-rc1 with the builds failing with things like: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2078: error: Cannot parse struct or union! The line in question is actually just a #define, but after some digging it turns out that my scripts pass W=1 and since commit 3a025e1d1c2ea ("Add optional check for bad kernel-doc comments") that results in kernel-doc running on each source file. The file in question has a badly formatted comment immediately before the #define: /** * struct brcmf_skbuff_cb reserves first two bytes in sk_buff::cb for * bus layer usage. */ which causes the regex in dump_struct to fail (lack of braces following struct declaration) and kernel-doc returns 1, which causes the build to fail. Fix the issue by always returning 0 from kernel-doc when invoked with -none. It successfully generates no documentation, and prints out any issues. Cc: Matthew Wilcox Cc: Jonathan Corbet Signed-off-by: Will Deacon Signed-off-by: Jonathan Corbet Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- scripts/kernel-doc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/scripts/kernel-doc +++ b/scripts/kernel-doc @@ -3216,4 +3216,4 @@ if ($verbose && $warnings) { print STDERR "$warnings warnings\n"; } -exit($errors); +exit($output_mode eq "none" ? 0 : $errors);