Received: by 10.223.185.116 with SMTP id b49csp1072467wrg; Fri, 23 Feb 2018 11:25:00 -0800 (PST) X-Google-Smtp-Source: AH8x227r2xK6FvRfs/O71/yD2NtpO51tLulRDlQw7ymne093zmAINBDN3neAdmEsLHLytT478FE6 X-Received: by 10.99.97.86 with SMTP id v83mr2207187pgb.138.1519413900037; Fri, 23 Feb 2018 11:25:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519413900; cv=none; d=google.com; s=arc-20160816; b=dCP1ZAfvRjR87jwRQ6EciRVvHfe0eE/JPnYrS3rU88v29MUu6qPDfXaGGd3pwTAoYJ IPmZg2BPQOY7h51GieF5FvvSjZt72NodQTS1WnQAmWCmSqdWad7yt2jC2NNSKsTWc6DG hGxku00wx73CiOdkGiOvWWpELb0uJTvgalSG1uD0t+6nM6jL47SJb54UFkFykIz0/jWl iXBmUbpdskjbSwkDf99lMYqUqg2pAF416hjlYyLS/fHLffOftWhX0pOSVl77985sblXA ajenWOWQnCPT43VEJdF9GRFW35z85oZAvdSE2H4Lff5wjZeAApw2QoJEiJc/Oo0JBPMK c9fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=FAKu+I+zuZZVwGO/H/kxABJMZdSpBSTLEhbMf6PcCHs=; b=0Gp0j7bCjq1lAePq+Sgyz5k0CnNhchiX9f8+PTc28nXvOvai04yVW7VrHj+E9AsRpv hdi3mCvbet2aMRqxU/rKnWqmHAbCrvz3OVCiCsR8P3UX7W8qZ6iK8ukJfoYgtHQEZsV/ jzhDV8RoNdtS5cRyf39SfHk321ltnqKczp5PK9iwyRvNuqc5+5scv9280K+9ZGvT/nIT ABAuAWQLXSA0QZkCULlcY0Nz1lNpufYpsF6NgFTCHa+k4rn+zma2FaZC6BkDm1mNM6u2 ed2Kn0VklasfmBbwzu1k/Zqz37AP91Hifd6a2GQLGxefkPTjIe9FpX4eONz1kbDT5Cxr XAPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a9-v6si2262379plt.242.2018.02.23.11.24.45; Fri, 23 Feb 2018 11:25:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935418AbeBWSxc (ORCPT + 99 others); Fri, 23 Feb 2018 13:53:32 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:47364 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935345AbeBWSxa (ORCPT ); Fri, 23 Feb 2018 13:53:30 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 58FAC1055; Fri, 23 Feb 2018 18:53:29 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dmitry Monakhov , Leon Romanovsky , Jason Gunthorpe , Sasha Levin Subject: [PATCH 4.14 093/159] IB/core: Init subsys if compiled to vmlinuz-core Date: Fri, 23 Feb 2018 19:26:41 +0100 Message-Id: <20180223170754.770331866@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180223170743.086611315@linuxfoundation.org> References: <20180223170743.086611315@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dmitry Monakhov [ Upstream commit a9cd1a673737dd81332fce1145801bfacfb90d90 ] Once infiniband is compiled as a core component its subsystem must be enabled before device initialization. Otherwise there is a NULL pointer dereference during mlx4_core init, calltrace: ->device_add if (dev->class) { deref dev->class->p =>NULLPTR #Config CONFIG_NET_DEVLINK=y CONFIG_MAY_USE_DEVLINK=y CONFIG_MLX4_EN=y Signed-off-by: Dmitry Monakhov Reviewed-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/core/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/infiniband/core/device.c +++ b/drivers/infiniband/core/device.c @@ -1261,5 +1261,5 @@ static void __exit ib_core_cleanup(void) MODULE_ALIAS_RDMA_NETLINK(RDMA_NL_LS, 4); -module_init(ib_core_init); +subsys_initcall(ib_core_init); module_exit(ib_core_cleanup);