Received: by 10.223.185.116 with SMTP id b49csp1073052wrg; Fri, 23 Feb 2018 11:25:42 -0800 (PST) X-Google-Smtp-Source: AH8x225a+HUjkwEvGCeK+Rievpld4mboKC/r/ZB/X+gXXASCHguKKbZz3+xuT9wUU1fyJnh1mjz1 X-Received: by 2002:a17:902:900b:: with SMTP id a11-v6mr2638891plp.249.1519413941907; Fri, 23 Feb 2018 11:25:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519413941; cv=none; d=google.com; s=arc-20160816; b=KMvO0bsvB7mwRsd79I+pW3NMkRz26Ml7Bii2flVxeJiQ6/ZhrIHyqy0L3O8aPhGydi uqmS29ZyTAWYejUvwl4+klA95w2crMARq9JgtiOLuAhEcE3QmFRY94HzPiDoUR6rcEM6 6t6ro15tkKtsIyTwF3MTjwc93x+A4P9KTt6rTmhDl5umkP1VfWe8NnMnL22ycGpl8o/A vLIdVAaTNFh8ecbSHZYVm09PJ2g9wCv3MsW1bZ7m0HWOL3xnQ5GjqQrC5/VgUkgj//TL fCGmm82wGayNiqsuXVJY9ODDBaqBawYgqDOAFVvpTTuC8SzNsJWeaz2nS/vw7lFiesNk NIdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=Ii5kSDBqt3LIYccraSRUXOm1OOJnr4krjl6ORd/zAsU=; b=kr+Z9ZynMgzL5HggEuGwk/Sej2pWReBXitOn2zUY0tGiL4z62WQoERTx4pslWTAFKr J9iM6pDYMGR7Q8/Q1/lvXNhjkx6qwXFXDZP8mJf0nYqQ6xPhxkHNdAGZUvVtvVUe663q Z+tP1c1dL0rWMTzIfyCfIPlBTsjBnKDBhvXxFwnH9iop3zCbjtqoBAjlsjn89W4XQDhG hZy3Uon5/VHthWs9SrzxjAb8BDvhgLbHMe9bdWQnyVe/XOM+5Upk29vNy/tev+iE450n FG33rcXzGFrvEvg3sA0A/mXLDTr4PbfWvuWOPc5fB/60fI6jNN3Pp/JOaRGil9MuWp3U 8cVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f89si2268309pfe.185.2018.02.23.11.25.27; Fri, 23 Feb 2018 11:25:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935292AbeBWSxC (ORCPT + 99 others); Fri, 23 Feb 2018 13:53:02 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:47172 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934921AbeBWSxA (ORCPT ); Fri, 23 Feb 2018 13:53:00 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 44B9CFCE; Fri, 23 Feb 2018 18:52:59 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andre Przywara , Chen-Yu Tsai , Linus Walleij , Sasha Levin Subject: [PATCH 4.14 084/159] pinctrl: sunxi: Fix A80 interrupt pin bank Date: Fri, 23 Feb 2018 19:26:32 +0100 Message-Id: <20180223170753.737248779@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180223170743.086611315@linuxfoundation.org> References: <20180223170743.086611315@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andre Przywara [ Upstream commit 6ad4cc8d1ac483e0fd33f605fb2788b0ecf51ed4 ] On the A80 the pins on port B can trigger interrupts, and those are assigned to the second interrupt bank. Having two pins assigned to the same interrupt bank/pin combination does not look healthy (instead more like a copy&paste bug from pins PA14-PA16), so fix the interrupt bank for pins PB14-PB16, which is actually 1. I don't have any A80 board, so could not test this. Fixes: d5e9fb31baa2 ("pinctrl: sunxi: Add A80 pinctrl muxing options") Signed-off-by: Andre Przywara Acked-by: Chen-Yu Tsai Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/pinctrl/sunxi/pinctrl-sun9i-a80.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/drivers/pinctrl/sunxi/pinctrl-sun9i-a80.c +++ b/drivers/pinctrl/sunxi/pinctrl-sun9i-a80.c @@ -145,19 +145,19 @@ static const struct sunxi_desc_pin sun9i SUNXI_FUNCTION(0x0, "gpio_in"), SUNXI_FUNCTION(0x1, "gpio_out"), SUNXI_FUNCTION(0x3, "mcsi"), /* MCLK */ - SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 14)), /* PB_EINT14 */ + SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 14)), /* PB_EINT14 */ SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 15), SUNXI_FUNCTION(0x0, "gpio_in"), SUNXI_FUNCTION(0x1, "gpio_out"), SUNXI_FUNCTION(0x3, "mcsi"), /* SCK */ SUNXI_FUNCTION(0x4, "i2c4"), /* SCK */ - SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 15)), /* PB_EINT15 */ + SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 15)), /* PB_EINT15 */ SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 16), SUNXI_FUNCTION(0x0, "gpio_in"), SUNXI_FUNCTION(0x1, "gpio_out"), SUNXI_FUNCTION(0x3, "mcsi"), /* SDA */ SUNXI_FUNCTION(0x4, "i2c4"), /* SDA */ - SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 16)), /* PB_EINT16 */ + SUNXI_FUNCTION_IRQ_BANK(0x6, 1, 16)), /* PB_EINT16 */ /* Hole */ SUNXI_PIN(SUNXI_PINCTRL_PIN(C, 0),