Received: by 10.223.185.116 with SMTP id b49csp1073053wrg; Fri, 23 Feb 2018 11:25:42 -0800 (PST) X-Google-Smtp-Source: AH8x227iqd2Sqn7H68n5iaU/DX/8z29aILsLdsi9zgnmVDSz7VE9DqV4d2SdbD6RXfx9a5FGklyx X-Received: by 10.98.117.139 with SMTP id q133mr2753416pfc.64.1519413941918; Fri, 23 Feb 2018 11:25:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519413941; cv=none; d=google.com; s=arc-20160816; b=GS3ooknTR8MZsRUrAeEO+B/zXesERwAjF58kF6xN74dcoJxRkk2GyiJd1Y5XFfWuCV lZji4+4vYv4ZV8/m2I1D/yPxfdcjgAq10TSjMt7NyWXUQ+JlubgV7Y1wlHjT2hgLuCT3 AmI8AOc/HXP90xFR4EUL57iqEVa3OoI6srHxgXFUJu+J65tKWfgviWEoPZsMAGQGWVY9 PaJNIAkyAGCOLPU7I3oMNlXYlGWLFH8l/k6gJSHfLtMH3lqrZPitovjezSdwaULaEA13 tGTl4kcuvUZjpZYNrh6ERRJ1LOEE2o1v6qNuBJ2i46ehQtz/x3du4mB5wi6Ist89ZzvS AnCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=7vBXQ6/nDhPP09/gnQINZKnF7mzDCDeB7P9x4nIzt2U=; b=eyl96sthfHDqV+BQNzTSJRvnnJdvuY2Fhn9VfetxuCnDesw1NQret1LQ7HRBbZpoTZ CvWbQz312Zhjaj4yVzqND4PO6QChYxmGMcDx6DUCAuoTM4pq3hXY/hg+Se7rxkrO+6tl qfCyf6gtuvHf858KWGkOUidp+rY/CWOgeoMcXJWh1+keJwlsEXVwTmSUtaaSTxXZRjsh Vbk/9ezoLPTUk+Yg2X5WPYF+OlbVcxFmcjtvaVt+E1YyWjhPgmZTXtPA096glO5jTBGL liN40m2YcSvzZKgR4oXaVLUQQD7MpHu0zl+cHR+6f1rZ7XFTV5DjKaXzAsqahpVE2lEn idvQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a66si2258995pfl.219.2018.02.23.11.25.27; Fri, 23 Feb 2018 11:25:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935324AbeBWSxI (ORCPT + 99 others); Fri, 23 Feb 2018 13:53:08 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:47222 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935312AbeBWSxF (ORCPT ); Fri, 23 Feb 2018 13:53:05 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 126841055; Fri, 23 Feb 2018 18:53:04 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Don Hiatt , Dennis Dalessandro , Jason Gunthorpe , Sasha Levin Subject: [PATCH 4.14 086/159] IB/hfi1: Initialize bth1 in 16B rc ack builder Date: Fri, 23 Feb 2018 19:26:34 +0100 Message-Id: <20180223170753.949193240@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180223170743.086611315@linuxfoundation.org> References: <20180223170743.086611315@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dennis Dalessandro [ Upstream commit 8935780b9f7bbad0f2eb5dd43f61ba7b509a1575 ] It is possible the bth1 variable could be used uninitialized so going ahead and giving it a default value. Otherwise we leak stack memory to the network. Fixes: 5b6cabb0db77 ("IB/hfi1: Add 16B RC/UC support") Reviewed-by: Don Hiatt Signed-off-by: Dennis Dalessandro Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/hw/hfi1/rc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/infiniband/hw/hfi1/rc.c +++ b/drivers/infiniband/hw/hfi1/rc.c @@ -815,7 +815,7 @@ static inline void hfi1_make_rc_ack_16B( struct hfi1_pportdata *ppd = ppd_from_ibp(ibp); struct hfi1_16b_header *hdr = &opa_hdr->opah; struct ib_other_headers *ohdr; - u32 bth0, bth1; + u32 bth0, bth1 = 0; u16 len, pkey; u8 becn = !!is_fecn; u8 l4 = OPA_16B_L4_IB_LOCAL;