Received: by 10.223.185.116 with SMTP id b49csp1074405wrg; Fri, 23 Feb 2018 11:27:20 -0800 (PST) X-Google-Smtp-Source: AH8x225aP7TN3Sm3p6oTGiuANB2E1+11JH2piEuVEkGTllOBrGT/ZTRUyPiXHJnF0zpSVNW7/nmm X-Received: by 10.98.23.136 with SMTP id 130mr2739211pfx.43.1519414040138; Fri, 23 Feb 2018 11:27:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519414040; cv=none; d=google.com; s=arc-20160816; b=oZ87tlyS/757GGtIm4w8btWp/ZTPmFHkyr2unlxc7yZ9zCJo02pHUzFEt4H38O9boN NKD8WYMv7uQbP02fdTaqNaOQFhJr5vz92IfifpPn14kLwU/RcPnvA0VdGD64N3ruPOLx TvC+Q1t9ihV7AvtJjGem2fWPv7ZbtVx1wCngVF68ADl1MgJ2115bgwNvwqA1F9XmfRH9 0yAtdnJRhy+X0Hom2OoA2vQu6Rx9Wp8w1chPvjLPgtDPVeUjogRLqtD05HsFoXTQ4z5j VtY8DYs16VuZPQR7ifrgHyutf72SpgUxhv4dWfoxyqlhduol7IN0vLQsev+ICiKR7bpN 6q/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=WyUbSsHFKUMikdgDhZ2mRxUREn3GnvwIUq/JfL/sD9s=; b=zwkF9KDZY2NcOoo2wn57BMaDrYYM+tZtkrsjMKGbvxQg9pzLYoAKmPxE/5P5pyqf6m gCqbJ1ZKdeTgub9DxsCgd+K29QgChrGvpQrDl3YMtI2w1Ab3RuoAKSAN3EnKJIlHy8Nj hcvNyFURVOg3/6x7JfzG8RyE+MPAyTp3JtV8rZRbjXcjta6RhUv50+LmFGEsjT8Owrlp SLGJ80sa9FJAZv1CmGOiN1s/jwMhxrDO/K01+sL1momNEobtGrmTj3gFvqfWu3w1zBDX alXJFXajSh5Z2NAZiCy5yPWjW8oaOuD4E2vAvuGYq8LYOt32/r0cCj04vlwAUDmAjlyj BwIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d2si1863632pgc.758.2018.02.23.11.27.05; Fri, 23 Feb 2018 11:27:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935194AbeBWSwm (ORCPT + 99 others); Fri, 23 Feb 2018 13:52:42 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:47042 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935166AbeBWSwk (ORCPT ); Fri, 23 Feb 2018 13:52:40 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id EF88EFF8; Fri, 23 Feb 2018 18:52:39 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+4fbcfcc0d2e6592bd641@syzkaller.appspotmail.com, Pablo Neira Ayuso , Cong Wang Subject: [PATCH 4.14 039/159] netfilter: xt_cgroup: initialize info->priv in cgroup_mt_check_v1() Date: Fri, 23 Feb 2018 19:25:47 +0100 Message-Id: <20180223170748.150467578@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180223170743.086611315@linuxfoundation.org> References: <20180223170743.086611315@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cong Wang commit ba7cd5d95f25cc6005f687dabdb4e7a6063adda9 upstream. xt_cgroup_info_v1->priv is an internal pointer only used for kernel, we should not trust what user-space provides. Reported-by: Fixes: c38c4597e4bf ("netfilter: implement xt_cgroup cgroup2 path match") Cc: Pablo Neira Ayuso Signed-off-by: Cong Wang Signed-off-by: Pablo Neira Ayuso Signed-off-by: Greg Kroah-Hartman --- net/netfilter/xt_cgroup.c | 1 + 1 file changed, 1 insertion(+) --- a/net/netfilter/xt_cgroup.c +++ b/net/netfilter/xt_cgroup.c @@ -52,6 +52,7 @@ static int cgroup_mt_check_v1(const stru return -EINVAL; } + info->priv = NULL; if (info->has_path) { cgrp = cgroup_get_from_path(info->path); if (IS_ERR(cgrp)) {