Received: by 10.223.185.116 with SMTP id b49csp1076464wrg; Fri, 23 Feb 2018 11:29:43 -0800 (PST) X-Google-Smtp-Source: AH8x225CXelE5miWyK2NIsZzEqZEjs1Q6ObkVxfoskbBZdlTA/aTUbmJRpZ0gBWjHhRnTbCPkMps X-Received: by 10.101.85.204 with SMTP id k12mr2294986pgs.40.1519414183764; Fri, 23 Feb 2018 11:29:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519414183; cv=none; d=google.com; s=arc-20160816; b=hxVwJW0JVn43ufzj37QLoPoxb7ut8zFp8Fqfyf3OWz50NwlW+kMi51i7eD205OQjbK hZGQVK4QxSCkvwKH3Jg8ibSXAG1DGpImTYyAKSmtJXJx2vii40R1wc1O0+ho90nWH8kl XUCnOP2orSatzA4UD0amEB0Mg8wEpLclVitItJRcdVA7HX7cxB7VyRUp+JjHCvanLl+r wmlvdsJaGgN4wnaZtNbYoyacJYaQFIMRDR7gkIWuMDxKd+ZwyOJollYJXxXFczajXCFq 0dXeGEdIP9HhirNLri8U0VHfyWVGj0//TMifLTGJg/w7/DYpzXaynBPJS4Cie1Ko9WN2 h51Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=+o87Hb+Zz3fsWAsN/aBXEb0P4o6SM/k9+ieHf9K1MXA=; b=IoWKrxkB9Za/R7w1Wg/MVxblDu8XMZtSI1Foyqc+r3stc/Iokmq1ofDg1uuFIH4PD5 eqBi/X+k6nmVrYwamS2DXLjg0mrGDI497OT7WNAd/07LBYd5AClqH4/CtYmq/jpvPFrd 4/if13p17luv6Y24If20lcOi+KO3pJTZhtH2ksYzUTTP1GKsbDAUjgEHQLXFWd5VQ43i V2QSoH2/NIpRjN7F3DlyQ1HOI4OP4Idh2Gx7VTUp0GL+h6diSx5IYEwUih9tTizjCmvy olrGkiQaoYA22iVLLCQtqBYz+cRU5QS7naPjvHXoG90We2lVCDXYDKV6bbqKzCtN/CqW BTPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n129si1863866pga.186.2018.02.23.11.29.28; Fri, 23 Feb 2018 11:29:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754634AbeBWT22 (ORCPT + 99 others); Fri, 23 Feb 2018 14:28:28 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:46628 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935083AbeBWSwG (ORCPT ); Fri, 23 Feb 2018 13:52:06 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 00D70E3B; Fri, 23 Feb 2018 18:52:05 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dave Gerlach , Nishanth Menon , Marc Zyngier , Sebastian Reichel , Roger Quadros , Tony Lindgren , Sasha Levin Subject: [PATCH 4.14 063/159] ARM: dts: Fix omap4 hang with GPS connected to USB by using wakeupgen Date: Fri, 23 Feb 2018 19:26:11 +0100 Message-Id: <20180223170751.239659718@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180223170743.086611315@linuxfoundation.org> References: <20180223170743.086611315@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tony Lindgren [ Upstream commit cf87634c8b24e24bf379b8c6807c8b0fb5f23567 ] There's been a reproducable USB OHCI/EHCI cpuidle related hang on omap4 for a while that happens after about 20 - 40 minutes on an idle system with some data feeding device being connected, like a USB GPS device or a cellular modem. This issue happens in cpuidle states C2 and C3 and does not happen if cpuidle is limited to C1 state only. The symptoms are that the whole system hangs and never wakes up from idle, and if a watchdog is configured the system reboots after a while. Turns out that OHCI/EHCI devices on omap4 are trying to use the GIC interrupt controller directly as a parent instead of the WUGEN. We need to pass the interrupts through WUGEN to GIC to provide the wakeup events for the processor. Let's fix the issue by removing the gic interrupt-parent and use the default interrupt-parent wakeupgen instead. Note that omap5.dtsi had this already fixes earlier by commit 7136d457f365 ("ARM: omap: convert wakeupgen to stacked domains") but we somehow missed omap4 at that point. Fixes: 7136d457f365 ("ARM: omap: convert wakeupgen to stacked domains") Cc: Dave Gerlach Cc: Nishanth Menon Cc: Marc Zyngier Cc: Sebastian Reichel Reviewed-by: Roger Quadros Signed-off-by: Tony Lindgren Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- arch/arm/boot/dts/omap4.dtsi | 2 -- 1 file changed, 2 deletions(-) --- a/arch/arm/boot/dts/omap4.dtsi +++ b/arch/arm/boot/dts/omap4.dtsi @@ -861,14 +861,12 @@ usbhsohci: ohci@4a064800 { compatible = "ti,ohci-omap3"; reg = <0x4a064800 0x400>; - interrupt-parent = <&gic>; interrupts = ; }; usbhsehci: ehci@4a064c00 { compatible = "ti,ehci-omap"; reg = <0x4a064c00 0x400>; - interrupt-parent = <&gic>; interrupts = ; }; };