Received: by 10.223.185.116 with SMTP id b49csp1076805wrg; Fri, 23 Feb 2018 11:30:06 -0800 (PST) X-Google-Smtp-Source: AH8x226deT1wMQRNFUBTejfjpnasBtUzc8ronKqgxCd5/9GgVi1IUUQJ4C1vLOyl/01X5ZgKFpH1 X-Received: by 2002:a17:902:6504:: with SMTP id b4-v6mr2647007plk.451.1519414206881; Fri, 23 Feb 2018 11:30:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519414206; cv=none; d=google.com; s=arc-20160816; b=OauWAO9ihFMsJZ6FzWkjHLuO5ERR4b8fXqiiHn9xkw7gtGxcnWz3iXKVmeSUFX4iOn f8mrfS6NSlRzMuuD+I+Ym2vXUD8/9Wp3ygrzFUL/LLGqp/0I0Ufmb8vPwYlZfXNTFuKy 3IBxDrVnqiCqCJZBQXxDH1iMmG/90TC8T8pd53A+CaMHMXBuS2SoT75M3UIICNImvBkd l6nquDaPASPTXW+AnXcAimp/ezHgWT0Z4N8oKbrtUPJQeqbHJF/Y4cSMS0YCtaBFS6IA myfw2VcZk+Bor6N/QYd28vYJUBpOddzfNs4AMbKMcj2Jwnj32ByVni2ttJBZ3H5lsor6 +oxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=2t7JfaRyLIPsSNC/K9HGlJ16Et1MoPbTscIobLIfzz0=; b=DPesSadYIX+/1Pwc+A/zvs7yhdl8tu/QIcQGtKtb1i8YixDDAr1RxgEETbKMpGUXep w//YEj2scMJGqOMgjXQm/QtFLPhsIC8JxDZSi1GcwvZXBIIYNrVBTeC1WN6F8AEjYGj9 T9pJpnechQTMJ3+WNs7u59DrhbMj27HBQvss7Hpr1KSg4u1SSTc0PsmKpK0O3nGrYIdN 1rOVSiS20w9vuQHrrJeuLb8CVMdzWbOGJUObLupzlANpgemz/X3K26cjKH6s0q7bGvkh xhD/xqT0WQikrKkpyOWx5YlaSsdZkGH6APmW+OXaI3yP6UH454aOJf2oiGkPEoIJtEU6 wdgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t134si1869060pgc.664.2018.02.23.11.29.52; Fri, 23 Feb 2018 11:30:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935054AbeBWSv7 (ORCPT + 99 others); Fri, 23 Feb 2018 13:51:59 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:46252 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934465AbeBWSvz (ORCPT ); Fri, 23 Feb 2018 13:51:55 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 90C4E950; Fri, 23 Feb 2018 18:51:54 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold , Sasha Levin Subject: [PATCH 4.14 060/159] serdev: fix receive_buf return value when no callback Date: Fri, 23 Feb 2018 19:26:08 +0100 Message-Id: <20180223170750.850913741@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180223170743.086611315@linuxfoundation.org> References: <20180223170743.086611315@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold [ Upstream commit fd00cf81a9a84776ba58e56bd042c726dcf75cf3 ] The receive_buf callback is supposed to return the number of bytes processed and should specifically not return a negative errno. Due to missing sanity checks in the serdev tty-port controller, a driver not providing a receive_buf callback could cause the flush_to_ldisc() worker to spin in a tight loop when the tty buffer pointers are incremented with -EINVAL (-22). The missing sanity checks have now been added to the tty-port controller, but let's fix up the serdev-controller helper as well. Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- include/linux/serdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/include/linux/serdev.h +++ b/include/linux/serdev.h @@ -184,7 +184,7 @@ static inline int serdev_controller_rece struct serdev_device *serdev = ctrl->serdev; if (!serdev || !serdev->ops->receive_buf) - return -EINVAL; + return 0; return serdev->ops->receive_buf(serdev, data, count); }