Received: by 10.223.185.116 with SMTP id b49csp1083379wrg; Fri, 23 Feb 2018 11:37:20 -0800 (PST) X-Google-Smtp-Source: AH8x224cfnln/SQESovcr3SEEzTvc8YrKnsJl7jn0TlAojmGC5wzYlj/ZGwiXE3XeGLL+H4u2ZNS X-Received: by 2002:a17:902:4827:: with SMTP id s36-v6mr2671869pld.337.1519414640609; Fri, 23 Feb 2018 11:37:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519414640; cv=none; d=google.com; s=arc-20160816; b=jfDmeo7bqBc/hRIIQ6S1C4XDwiy7B2WAKIj/ojB3LTftfFKW/HS60Cr2T7xCCqDBbi xFWQ6d2MmQY05Zi9ghwoc8WCBiNqQQOSLHyq4kCi4ll4YpttuW6L0sxkAvKVJR/c8Mmx mjXHbukaBp2HKdhOB6zSWAJUs/3oqC9cFulmMvHfyNmKWvQriTV/nIBSc6JQyyviQ6NC qjTxmSZh7CWSHQopUvWTyPfN+oG4YWyjgulP9L58ztvHoFtrWOWVtybtESMfiUx63Ec5 pMZKtkaHTrPQhyjwDEo0MY2x+Yu/Oy78i6hIs/mKU8gQ0xG1x1JSgI8cCovtaEwKkmZl jyfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=bSrWn7mNvLChBN5Nlq4cCDoPyP0iP5+pgnsnTvQNzso=; b=GH0eKmkb+Kg6rwVxFUaRBfsu7WunXLTyP6uiibFXYwXsJamvVZmgBmO+AKK9h6PeMI hZ4JdNCobpt0QDo4a2FYeQwNpwBoQIUIzX9RK+KBOICk9EKOe3DNZggRHFlZ95JuLQtP d3nFBYET4fhT9htnWQqkqIxCd+2Vq8KgnC4wQ1HQFf27B6Kc/YFRKGpXYvLxKijZ2OWq NQdGKciq7Mff9OtVL7LjwAXyCRFbWXfck3BjrcAWhrrjxWm2BxICsrAY+g8hn/gH6Ek/ ytMs2PGFqWNet9Fg4/35N3ZzXPTv+GrS/NadkI5N6Y4ZESsUmrdgfkKtT3zUcz06TYvq cLRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q11-v6si2175590pll.379.2018.02.23.11.37.06; Fri, 23 Feb 2018 11:37:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934763AbeBWSuf (ORCPT + 99 others); Fri, 23 Feb 2018 13:50:35 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:45682 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934454AbeBWSuc (ORCPT ); Fri, 23 Feb 2018 13:50:32 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id A06FC12DB; Fri, 23 Feb 2018 18:50:31 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+fa2d5f63ee5904a0115a@syzkaller.appspotmail.com, syzbot , Laura Abbott Subject: [PATCH 4.14 031/159] staging: android: ion: Switch from WARN to pr_warn Date: Fri, 23 Feb 2018 19:25:39 +0100 Message-Id: <20180223170747.053071254@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180223170743.086611315@linuxfoundation.org> References: <20180223170743.086611315@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Laura Abbott commit e4e179a844f52e907e550f887d0a2171f1508af1 upstream. Syzbot reported a warning with Ion: WARNING: CPU: 0 PID: 3502 at drivers/staging/android/ion/ion-ioctl.c:73 ion_ioctl+0x2db/0x380 drivers/staging/android/ion/ion-ioctl.c:73 Kernel panic - not syncing: panic_on_warn set ... This is a warning that validation of the ioctl fields failed. This was deliberately added as a warning to make it very obvious to developers that something needed to be fixed. In reality, this is overkill and disturbs fuzzing. Switch to pr_warn for a message instead. Reported-by: syzbot+fa2d5f63ee5904a0115a@syzkaller.appspotmail.com Reported-by: syzbot Signed-off-by: Laura Abbott Signed-off-by: Greg Kroah-Hartman --- drivers/staging/android/ion/ion-ioctl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/staging/android/ion/ion-ioctl.c +++ b/drivers/staging/android/ion/ion-ioctl.c @@ -71,8 +71,10 @@ long ion_ioctl(struct file *filp, unsign return -EFAULT; ret = validate_ioctl_arg(cmd, &data); - if (WARN_ON_ONCE(ret)) + if (ret) { + pr_warn_once("%s: ioctl validate failed\n", __func__); return ret; + } if (!(dir & _IOC_WRITE)) memset(&data, 0, sizeof(data));