Received: by 10.223.185.116 with SMTP id b49csp1130073wrg; Fri, 23 Feb 2018 12:27:45 -0800 (PST) X-Google-Smtp-Source: AH8x224h6CikqJdM98XRnmEPgioSMKMkBDmCFR0Pa4falCJ6ErV2vLLmv0nJnHWBG9KaXhNQgkst X-Received: by 10.98.25.10 with SMTP id 10mr2870265pfz.136.1519417665793; Fri, 23 Feb 2018 12:27:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519417665; cv=none; d=google.com; s=arc-20160816; b=Rv2I56GWMttnawv/Y5MaxbFFZMh57079PBTCrX0tUryb22paXv8dmGdRvUCuleJRKz I7lSHt5yk4qXfI3pzqCDuq6HfH7P6G8nMdDiRbOZmjGyLXeiBqGqbXl4nfTcDXMx9nF2 c+rQi1tXRD9cSKT44odeF1f8Aug2lbeBoNl1mujtW8ltIMmPnmujibDrc0n381/DeclH 4yUcaWSchXqtjvNWKvK7Hz3Eh44G5E7YwqUN9OHH36OAa3ZVVRpCzcGrnfdfa1Xb49x6 oiWUP0Vb9RElzafQiL2A6ogQhWYt8s+MRvms0AoBw3lxJcSLEwmLlV+xBuDa8wNP4EP5 bZHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=4d1XRmA8Z0tj87k/lvkVfC1Ro3xDiqhLYdX0sOKqRiw=; b=d1IOS9BUdlttOR+SuB0VekpOh4V8I12dGobHiAueOrUu4vFma61+2+ML4zIBlSuqRM 92vJglCnOzr5FvzDu2aiZMRwWzXy8urxGZztGKS84sasKi28y+Hwr1XzLJ/dl4RpWvkE eTSP+/8cwyPL0YgvIsOv525O1oYf/zmROvoFdPsVakVPf4qRuQQVSHV3UsNupJONu00k n4o8v+iRbkQ4Ou5Wel9zqxiBSmg04Jo/MqfI301INl7v1Gb8rpCf95Z6BLVm7+l3GVLy V5H/t7xmK34fbWL5bKcctoUp00Is45Tnpos+hITsuraChee2CWfed5C/4FwnMYHgyJSK wMEQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f11si1899172pgt.828.2018.02.23.12.27.30; Fri, 23 Feb 2018 12:27:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932151AbeBWShO (ORCPT + 99 others); Fri, 23 Feb 2018 13:37:14 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:38622 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754188AbeBWShK (ORCPT ); Fri, 23 Feb 2018 13:37:10 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id F207EF7D; Fri, 23 Feb 2018 18:37:09 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Johannes Thumshirn , "Martin K. Petersen" Subject: [PATCH 4.4 097/193] scsi: mvumi: use __maybe_unused to hide pm functions Date: Fri, 23 Feb 2018 19:25:30 +0100 Message-Id: <20180223170341.232962399@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180223170325.997716448@linuxfoundation.org> References: <20180223170325.997716448@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Arnd Bergmann commit fddbeb80a904aae41c84ed566e2b0d1de55907df upstream. The mvumi scsi hides the references to its suspend/resume functions in an #ifdef but does not hide the implementation the same way: drivers/scsi/mvumi.c:2632:12: error: 'mvumi_suspend' defined but not used [-Werror=unused-function] drivers/scsi/mvumi.c:2651:12: error: 'mvumi_resume' defined but not used [-Werror=unused-function] This adds __maybe_unused annotations so the compiler knows it can silently drop them instead of warning, while avoiding the addition of another #ifdef. Signed-off-by: Arnd Bergmann Reviewed-by: Johannes Thumshirn Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/mvumi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/scsi/mvumi.c +++ b/drivers/scsi/mvumi.c @@ -2629,7 +2629,7 @@ static void mvumi_shutdown(struct pci_de mvumi_flush_cache(mhba); } -static int mvumi_suspend(struct pci_dev *pdev, pm_message_t state) +static int __maybe_unused mvumi_suspend(struct pci_dev *pdev, pm_message_t state) { struct mvumi_hba *mhba = NULL; @@ -2648,7 +2648,7 @@ static int mvumi_suspend(struct pci_dev return 0; } -static int mvumi_resume(struct pci_dev *pdev) +static int __maybe_unused mvumi_resume(struct pci_dev *pdev) { int ret; struct mvumi_hba *mhba = NULL;