Received: by 10.223.185.116 with SMTP id b49csp1135284wrg; Fri, 23 Feb 2018 12:33:23 -0800 (PST) X-Google-Smtp-Source: AH8x227aPotIybM4jV6JylrOgiMkxd+6IiwHKPv5L2F9iVM3nSbUXOIkDnaPFcqZsLSK7OasDO5i X-Received: by 10.99.127.29 with SMTP id a29mr2303205pgd.451.1519418002987; Fri, 23 Feb 2018 12:33:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519418002; cv=none; d=google.com; s=arc-20160816; b=NLHwNbV+/OMFhhjlhULNiNx38E0wEKyVzowj/agAOQ/bN93oPiV2wbHrYA4gtIJJ/u qTum1/6Rm1C5JGla9h09WCvy7D1pAZI7+mYUlB8wMjsWOi8pr9/pzYUsYnw4aqHESXtq lq3uoGZ6AEWUG2LrZtM7tMD4Mr5D/VQAr3HQxT/FSVBVMBfWPmJ8c1qehoX2k+WPox/m l0FfiSipXUa1U7Jlp/zxt5xmx5kAG8SN8sofcahTtRUqiiU2j4yAwx6eGQhUpAP1Fth2 E6PJ5m7HA33Ru1u6EhaI7svj7hMevyitnBBYI8EkPJsvGiccSIeB8QOFXBGAH6Vt0HBa pSuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=hNy5E3dlVdS6mXaNDI43RJKpbdT5cqrqMD/qrOOy2nI=; b=W63o8vkxXTxda5zVO+ez6Nyu8B++uwgTsuhUC4XTU3ieDzdhoYQRUvXwJGNyFX02UR CCnaoYqNL6YRsyL/XLQzZszurOqN/cN1mlsbJ+eutoSGnlrnYYJ6/8/kiCt06DnisKks ej3ynuM0saCU+70yz0sA6gHuVf2UF1a/NQGsfQ1OrP6+Jx8BNKPFP0gIInweQRDVMdxa rw0i7v3/o1bAa+VWc229vecmQDdkTmdyMLDiDg81cXNPyvodxPEQqMFIUU/Z/7pdPthq BJ5lnNPpTslS4iCFcDW4OYTQ6SxMTg9nYM2yOxayB+2Bt04/U0CHpc6u/VyZnFj2XnVo EdFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b59-v6si2281139plc.596.2018.02.23.12.33.08; Fri, 23 Feb 2018 12:33:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754060AbeBWUbW (ORCPT + 99 others); Fri, 23 Feb 2018 15:31:22 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:37598 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753984AbeBWSgM (ORCPT ); Fri, 23 Feb 2018 13:36:12 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 615021308; Fri, 23 Feb 2018 18:36:11 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Matthew Wilcox , Jonathan Corbet , Will Deacon , Sasha Levin Subject: [PATCH 4.4 040/193] scripts/kernel-doc: Dont fail with status != 0 if error encountered with -none Date: Fri, 23 Feb 2018 19:24:33 +0100 Message-Id: <20180223170332.306392622@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180223170325.997716448@linuxfoundation.org> References: <20180223170325.997716448@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Will Deacon [ Upstream commit e814bccbafece52a24e152d2395b5d49eef55841 ] My bisect scripts starting running into build failures when trying to compile 4.15-rc1 with the builds failing with things like: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2078: error: Cannot parse struct or union! The line in question is actually just a #define, but after some digging it turns out that my scripts pass W=1 and since commit 3a025e1d1c2ea ("Add optional check for bad kernel-doc comments") that results in kernel-doc running on each source file. The file in question has a badly formatted comment immediately before the #define: /** * struct brcmf_skbuff_cb reserves first two bytes in sk_buff::cb for * bus layer usage. */ which causes the regex in dump_struct to fail (lack of braces following struct declaration) and kernel-doc returns 1, which causes the build to fail. Fix the issue by always returning 0 from kernel-doc when invoked with -none. It successfully generates no documentation, and prints out any issues. Cc: Matthew Wilcox Cc: Jonathan Corbet Signed-off-by: Will Deacon Signed-off-by: Jonathan Corbet Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- scripts/kernel-doc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/scripts/kernel-doc +++ b/scripts/kernel-doc @@ -2742,4 +2742,4 @@ if ($verbose && $warnings) { print STDERR "$warnings warnings\n"; } -exit($errors); +exit($output_mode eq "none" ? 0 : $errors);