Received: by 10.223.185.116 with SMTP id b49csp1135289wrg; Fri, 23 Feb 2018 12:33:23 -0800 (PST) X-Google-Smtp-Source: AH8x225SDUEt+wrqVcBUpisjQIZuKxfwWK+c8Equf6uNeeMif8AJ2OmQEYb3xydCGiNNnugOx8Km X-Received: by 2002:a17:902:8215:: with SMTP id x21-v6mr2872943pln.164.1519418003819; Fri, 23 Feb 2018 12:33:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519418003; cv=none; d=google.com; s=arc-20160816; b=H76mVQsn8ePyGr7wCZHwMtSmpzmSsU9mG29h/aLJjcEaue0+U8mDE1JvxVIjS7tJ0i V2/RJyvWzdFdbLqwKenyIhkIoCmHkXeOBqLKDKSqqeqmHscegtXDLtrhV5MjpADanYPm kn7ojDvwdENzeINZxkWFqaVUEBobQBxzq2q3BOeFhVwM/tzyQPjJLWEI6zLKTvbvk8hU DtOgobFrKr/x2NU74SQfYRUmtbnqBdcUTUoExMwsV8P3eTizR4O+xG1lIZCrfRAa7yXM KjCocUg0UhdpGg2XTqdlr8vDMZYP3nMN3T9hUsipJD00XfTIABs9s/P2nwQYwgqYkhk7 VT2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=xO4ylNpYN9CNBtcbjuNhgF82U8K5wydphxaW2HANwMo=; b=oZh6VD77oQW8uzuGLo6OzqDAB3fY+QI+SQLJerIJv0YLuEvhSJJ9ToeEmDLoQYzMxz Yyjcgys78DSzf5bcDYH2JnSI052Sa4FbBfX4Uhw0D6s+dm0U9bWfWhh8iz99PixCTRSA ArRlsIh0eD1OsMgHcMvp9CB83HyGwXI8wE0hYxwKNnuHIC1DPcWSS8OetE61HcvtdEom G0oXEvz/IcuvTY8bd4LFkixywd/8t8yksr5T/m1TLFHSgTfHVybpCjUwb5e0FZQzJhGZ FEA3TQA+A7esVdazIZEfWDAeuYqWmYXkYMw00NBDJXVUfrDm6Fv1C5YHnF6f2EhrvZ5z 1x8A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x21-v6si2264798pln.416.2018.02.23.12.33.09; Fri, 23 Feb 2018 12:33:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932110AbeBWUca (ORCPT + 99 others); Fri, 23 Feb 2018 15:32:30 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:37378 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753877AbeBWSfl (ORCPT ); Fri, 23 Feb 2018 13:35:41 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 9154511D8; Fri, 23 Feb 2018 18:35:40 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , "David S. Miller" Subject: [PATCH 4.4 064/193] vmxnet3: prevent building with 64K pages Date: Fri, 23 Feb 2018 19:24:57 +0100 Message-Id: <20180223170335.983494978@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180223170325.997716448@linuxfoundation.org> References: <20180223170325.997716448@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Arnd Bergmann commit fbdf0e28d061708cf18ba0f8e0db5360dc9a15b9 upstream. I got a warning about broken code on ARM64 with 64K pages: drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_rq_init': drivers/net/vmxnet3/vmxnet3_drv.c:1679:29: error: large integer implicitly truncated to unsigned type [-Werror=overflow] rq->buf_info[0][i].len = PAGE_SIZE; 'len' here is a 16-bit integer, so this clearly won't work. I don't think this driver is used much on anything other than x86, so there is no need to fix this properly and we can work around it with a Kconfig dependency to forbid known-broken configurations. qemu in theory supports it on other architectures too, but presumably only for compatibility with x86 guests that also run on vmware. CONFIG_PAGE_SIZE_64KB is used on hexagon, mips, sh and tile, the other symbols are architecture-specific names for the same thing. Signed-off-by: Arnd Bergmann Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/Kconfig | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -411,6 +411,9 @@ config XEN_NETDEV_BACKEND config VMXNET3 tristate "VMware VMXNET3 ethernet driver" depends on PCI && INET + depends on !(PAGE_SIZE_64KB || ARM64_64K_PAGES || \ + IA64_PAGE_SIZE_64KB || MICROBLAZE_64K_PAGES || \ + PARISC_PAGE_SIZE_64KB || PPC_64K_PAGES) help This driver supports VMware's vmxnet3 virtual ethernet NIC. To compile this driver as a module, choose M here: the