Received: by 10.223.185.116 with SMTP id b49csp1136988wrg; Fri, 23 Feb 2018 12:35:13 -0800 (PST) X-Google-Smtp-Source: AH8x224NCgetLIuV6qZRzYWtHgwqY5+A/VF9p4+GeipG/HXrbrAmg6oc/GsHmxwNRP85ENfI42DX X-Received: by 10.99.150.2 with SMTP id c2mr2398783pge.424.1519418113774; Fri, 23 Feb 2018 12:35:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519418113; cv=none; d=google.com; s=arc-20160816; b=PydQ9BppEFZC0kn5tzGuLyjcy6I2rl+B2N78P0njkoz/EAZZekzX0GAjXM895pJstG 2Z094ET98Y2G9j5G2RqWm8UTvgy5s2cKM5ZlYKvHanAAUMq5YaBZZhmhLs2mzXhfHIsC vrwpxpPDtdAqiFVHl41uxDMjA2M7FrAtFT+QTr2AbTz+vwtME5rlvF8CPR9JCrbnn7fP E3kEUcnLfMs57bWLTHIKP58CX3laj8YYJHjDOxjyKREAClov5fAuSvElm/XSXGhUea5f OK5pFaJcu8DhtWa3Ltk5ItEEVhpoKJH5GNtbX6oaKg9NC9afYZeSlkv+gj+oPfiLlziQ WCvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=Ms70K5zx6A7MN4u+p0/Gll3fepV6zNSsEJMBwt8le6Y=; b=MeIjEzapKxbxpnx9I12ZXwCnt19nVbaUEU9swV1+1GbdXpsc1j7FXaxYSZQApfUYd+ 9wgf1EVgYT/DNwznqGRBk7pxpQCY3fMxzKp7WlF+7KeC80GDqJXdmD5mQP+E46WmH3r5 5lksR98FwxnYifzrlCmwf4aglAr7iD8I6Q1hNsjovA8q9QCIOG4jDF1ph03E/SHlbCIv SZY3Rb7+t1AsaTpJ0wFsH2jvO2oU4xjtYGyReQdt5Gbffs02DofczptJs81wPjiRkIjv 4GdXwRifpd6iThuxynIrKTwIPyDUKLblFAzSxjJif8gsHZ5vRxCu/Wxcj1RPgAJ1dVTJ g0Og== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q13si1946455pgs.277.2018.02.23.12.34.59; Fri, 23 Feb 2018 12:35:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753740AbeBWSfJ (ORCPT + 99 others); Fri, 23 Feb 2018 13:35:09 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:37174 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751949AbeBWSfH (ORCPT ); Fri, 23 Feb 2018 13:35:07 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 48AD71286; Fri, 23 Feb 2018 18:35:06 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takuo Koguchi , Maxime Ripard , Mark Brown , Sasha Levin Subject: [PATCH 4.4 054/193] spi: sun4i: disable clocks in the remove function Date: Fri, 23 Feb 2018 19:24:47 +0100 Message-Id: <20180223170334.482991456@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180223170325.997716448@linuxfoundation.org> References: <20180223170325.997716448@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Takuo Koguchi [ Upstream commit c810daba0ab5226084a56893a789af427a801146 ] mclk and hclk need to be disabled. Since pm_runtime_disable does not disable the clocks, use pm_runtime_force_suspend instead. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Takuo Koguchi Acked-by: Maxime Ripard Signed-off-by: Mark Brown Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/spi/spi-sun4i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/spi/spi-sun4i.c +++ b/drivers/spi/spi-sun4i.c @@ -458,7 +458,7 @@ err_free_master: static int sun4i_spi_remove(struct platform_device *pdev) { - pm_runtime_disable(&pdev->dev); + pm_runtime_force_suspend(&pdev->dev); return 0; }