Received: by 10.223.185.116 with SMTP id b49csp1154361wrg; Fri, 23 Feb 2018 12:56:53 -0800 (PST) X-Google-Smtp-Source: AH8x227yHteUcmWLfbcOO57bk7AA60VHO4UlV41JvKhf7Ez1evqxw+DT9imSbS7gGjUTBqzRMXuq X-Received: by 10.99.172.2 with SMTP id v2mr2453640pge.204.1519419413638; Fri, 23 Feb 2018 12:56:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519419413; cv=none; d=google.com; s=arc-20160816; b=dVGB5GhyzwYFsMAl7ax3WBhk3KK1RolWb2V0ie43wtq8GtlGwVgoXuNFDdg7J6D+gI 1+Jm3CKX59WHx7dofUKt+INgavgnL+Bk8it2lORMP9VVIyFIeBDszsphgUqmrqDviyCT hSWkqTw/pFaKci5drfYALurHGxo0G4/3rOO7S+AbrHChKQp8inj4lAtYN/RqcNqCIktP 41s2Z/hLfy9+dtv7B04DJpY4ecqYMV22KzKRW3xZEtIlF5PP16zihErQj+h9D+/hTcdK XXBYWmoSPCnccru7hcUWQ5ygPydlxPMSACjh3/0SVhmEkcDoFI7LZQ2MGYI6OWODohpn N01w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=YyYFWzKrqxZ5ZGRz7y5T6uGr8Ga8YawLw/ecexkoo9w=; b=xkykfQwigF5YNWda+/M9rJLYg36TIN/lY5i+up8qL8vZBdNnc3EO3R5w99QQPAgCNZ uUilnmRLFETsz5yswUJgryjF6stXTSUTRhE2mCoc3AkolvFmfO5K4OtdJO7FjnTCBPF5 Ktgi2Cg21oe4NVDOhg82aibymX+83qa3A6MJOiiEpDd3VV+CyhXWsLUPB9kuN3OM01LE D7n8cfuIuzXKREg4oWgyBHlfHSWfJDUNL6KjQfLQ8Ce1XcSEv3dltJbyjWGYmjZ0yuzI EHDJzhA+DHGoK0oW30X8qylWwXgOz+KDfHdQHnVECjWDHUyQ9O2yFBWNREgIZfKzQvIa xMxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=tRhy4coj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p10si2359895pfe.171.2018.02.23.12.56.39; Fri, 23 Feb 2018 12:56:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=tRhy4coj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752179AbeBWU4E (ORCPT + 99 others); Fri, 23 Feb 2018 15:56:04 -0500 Received: from mail-pl0-f68.google.com ([209.85.160.68]:36643 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751667AbeBWU4C (ORCPT ); Fri, 23 Feb 2018 15:56:02 -0500 Received: by mail-pl0-f68.google.com with SMTP id v3so5572028plg.3 for ; Fri, 23 Feb 2018 12:56:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=YyYFWzKrqxZ5ZGRz7y5T6uGr8Ga8YawLw/ecexkoo9w=; b=tRhy4cojlrt3NYGyzaGDSPQSU8lR2O4EkNs86Fl5+5XsKPuZxOM1OFEpc2xv2tCOyJ NeLeOcWCkLkh7kSq6/9fGtnI21BHqRlQDVGJZAm1dyOqxyTirWcGbSbiFtsfqrXMw9ZM mGM4M6OZsIEZ15VaEIKwnpMqJzZ//nBuS0FmNcUq66zXzI10/cSjNvj3GfSmN/38nMwJ 9k6+O+Sx2gnx2ZFTE84t8GvFRXwtHVU/FMdi1Os73x18TcBULgKKm6xpRSX9/oN9QdMO I78SCVd2JJqle5LxRSzgWZ72udnrUrfg5opG6MxNM3xUDWnPJRId65vA5wa49QcmN7U3 4qYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=YyYFWzKrqxZ5ZGRz7y5T6uGr8Ga8YawLw/ecexkoo9w=; b=rq8zkb1Db9M7QB70YJtqAdfYPPCHS87ixiE9lyJ+WtPnXdaRYe97VeFXw7n2XbIDWO 6q5Zd9QsPCDS0ue1vYFEJ/Z+AMUPHgaIVoZXXwV0Q0LBZmnJOqCke3UDHTVl37Go7/aF jRmbzwjIqFeVpoMR106/x1FpsS+fl3JDzmgK3BfMivCC7SsxzvUKnuN0mxIHli4JvhwK Gn6PyhCcbKla6s5XNCqSD9dt5xmTximQRy7xrhx2EtbEnxhhaQrOG26kyihLpKJQMNdm /N/Ain0fjHZnzpQplXTDi7Ofc2V4sxbDp4W3TDt66E3kBYSHVviU7LIyFKyU4EVXJelU 71WQ== X-Gm-Message-State: APf1xPBzYVd4g+Ri5yOg3PJ/1d+9guKya+VV1FVr8Jr/vefxArTWyPWX aOZzyl1vR/Kgjjab8aeBSX8= X-Received: by 2002:a17:902:b413:: with SMTP id x19-v6mr2847610plr.420.1519419361948; Fri, 23 Feb 2018 12:56:01 -0800 (PST) Received: from localhost (108-223-40-66.lightspeed.sntcca.sbcglobal.net. [108.223.40.66]) by smtp.gmail.com with ESMTPSA id a87sm6498113pfj.13.2018.02.23.12.56.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Feb 2018 12:56:01 -0800 (PST) From: Guenter Roeck To: Benjamin Herrenschmidt Cc: Paul Mackerras , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Guenter Roeck Subject: [PATCH] powerpc/boot: Fix random build errors Date: Fri, 23 Feb 2018 12:55:59 -0800 Message-Id: <1519419359-19163-1-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Once in a while I see build errors similar to the following when building images from a clean tree. Building powerpc:virtex-ml507:44x/virtex5_defconfig ... failed ------------ Error log: arch/powerpc/boot/treeboot-akebono.c:37:20: fatal error: libfdt.h: No such file or directory Building powerpc:bamboo:smpdev:44x/bamboo_defconfig ... failed ------------ Error log: arch/powerpc/boot/treeboot-akebono.c:37:20: fatal error: libfdt.h: No such file or directory arch/powerpc/boot/treeboot-currituck.c:35:20: fatal error: libfdt.h: No such file or directory Rebuilds will succeed. Turns out that several source files in arch/powerpc/boot/ include libfdt.h, but Makefile dependencies are incomplete. Let's fix that. Signed-off-by: Guenter Roeck --- arch/powerpc/boot/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile index ef6549e57157..26d5d2a5b8e9 100644 --- a/arch/powerpc/boot/Makefile +++ b/arch/powerpc/boot/Makefile @@ -101,7 +101,8 @@ $(addprefix $(obj)/,$(zlib-y)): \ libfdt := fdt.c fdt_ro.c fdt_wip.c fdt_sw.c fdt_rw.c fdt_strerror.c libfdtheader := fdt.h libfdt.h libfdt_internal.h -$(addprefix $(obj)/,$(libfdt) libfdt-wrapper.o simpleboot.o epapr.o opal.o): \ +$(addprefix $(obj)/,$(libfdt) libfdt-wrapper.o simpleboot.o epapr.o opal.o \ + treeboot-akebono.o treeboot-currituck.o treeboot-iss4xx.o): \ $(addprefix $(obj)/,$(libfdtheader)) src-wlib-y := string.S crt0.S stdio.c decompress.c main.c \ -- 2.7.4