Received: by 10.223.185.116 with SMTP id b49csp1641474wrg; Sat, 24 Feb 2018 00:53:54 -0800 (PST) X-Google-Smtp-Source: AH8x227nSxcMybraMCQGofwcM502SuPTfd1VNXmpQlj3qaWdlI+/yUrfmZNd56OHKd3Z3LnVfWE1 X-Received: by 10.98.23.136 with SMTP id 130mr4322327pfx.43.1519462433930; Sat, 24 Feb 2018 00:53:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519462433; cv=none; d=google.com; s=arc-20160816; b=Aj5/e7tCTe+f+rvrbu+qYBkllAtN/Fy3QNE0ZIN0j8Y2WDttTfrm0p7OPi+07t8I9T oZCt58//4cxMZnBqF1Oxg3gHq8lfYGYqjMko4L6ULeiaFePjiWTv3WxFxeyVcBPpzKN0 syYicEzhL7Lb+DBITKt4OGa2BldxnB1N7tT8FFj5KJyYeL1oOWY1ipB0TDRb70IEILL9 zNHc2sp7KFZfbVGhFvVYMrR4uHZxoZ+cv1nxv3Fi65Sykm2nxYqrexIXqVRhpOkidG9b Gl96jQnwOzvj2EiFu/D0H3aBp8DEmY9c4D51NjXx2P7KrxC9qdNYOnJ+VwOabF5QZCm0 in1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=GPyzeLAvqq32XfDNReOhmhamuAMn41DFZJ9lkeVixdE=; b=ayDy2noRGS5UkOeix0wosv5M5CaE8kw0rOBA5xKEEdl4GXfWLXuQ7WMp/dTTjSumVF PMQUA6EZbd3tRaV4kLwm4RjtIDPeFFpAI0OaBsoTe7FnylbJVqYHrh0hc5Z2mf3dVW6v JvDPAlyQvLVS7J/wHqDBXJSqf+4u1TBeAV0dM/eZeTgt2G+WQjV9MM3Y8KuHvQtqC25b itma13ZV4aTLbGBPVLae0js+kdU2ZbYIw9nCsFXw1m80WoyCDZr+6IWu+/tTnleBZUnR Ddjn1qHe+/M5smOc6vfYbUs7LhtqFda34E0Pz3kAxkt0y56JE2vbKbBXQcQN4ibsfhJ3 BzIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 9si2651702pgh.687.2018.02.24.00.53.38; Sat, 24 Feb 2018 00:53:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751302AbeBXIxA (ORCPT + 99 others); Sat, 24 Feb 2018 03:53:00 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:36464 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750844AbeBXIw6 (ORCPT ); Sat, 24 Feb 2018 03:52:58 -0500 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 8C9E480198; Sat, 24 Feb 2018 09:52:57 +0100 (CET) Date: Sat, 24 Feb 2018 09:52:56 +0100 From: Pavel Machek To: Florian Vaussard Cc: Jacek Anaszewski , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/2] leds: ncp5623: Add device tree binding documentation Message-ID: <20180224085256.GC12996@amd> References: <20180221214654.3306-1-florian.vaussard@gmail.com> <20180221214654.3306-2-florian.vaussard@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4jXrM3lyYWu4nBt5" Content-Disposition: inline In-Reply-To: <20180221214654.3306-2-florian.vaussard@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4jXrM3lyYWu4nBt5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > +Required properties: > + - compatible: Should be "onnn,ncp5623" > + - reg: I2C slave address (fixed to 0x38) =2E. > +Required properties: > + - reg : LED channel number (0..2) For consistency, there should be no space between reg and :. Anyway, this can be fixed later. Acked-by: Pavel Machek --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --4jXrM3lyYWu4nBt5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlqRJ+gACgkQMOfwapXb+vLIkwCfSPiuc1/xejFwvmcl3F7iEveb UP4An2AEE786yTF8507ah0emHKw8M/Bu =fOsR -----END PGP SIGNATURE----- --4jXrM3lyYWu4nBt5--