Received: by 10.223.185.116 with SMTP id b49csp2337599wrg; Sat, 24 Feb 2018 17:42:29 -0800 (PST) X-Google-Smtp-Source: AH8x225qTSaWtSmAbj15hkULPYoGtd1vihcTBJLnygxoRIgy+oybFOpnuUE40QgajmBoPPfhL1j2 X-Received: by 2002:a17:902:5a88:: with SMTP id r8-v6mr6538352pli.426.1519522949558; Sat, 24 Feb 2018 17:42:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519522949; cv=none; d=google.com; s=arc-20160816; b=ne5xlOVRdT+5igS3TsASC5Dajqqjpq4/W3VyiSXISUr+SZC0CnUvxBJdi1b1I5hWia Hrto09hp7JYfGCLXhTd1+X4Xg+Qhne5eNjDICxZvcWxI97I8XSGcgtBhtHRbLlQVwbqV 71h3/LvZYni53CaD0x6aopHUuFPdaRqAu35/1qLRA3XFAg8j9tBF2AEhh3uf7PoRw/Vv 1Htm+lJHK0CALHpzCnzoQ7g7Oz57WsicQuSpa5RLbfgZH0v59I+ctI3Wu9MetJazkJsS faeVeLlGadhjwDkn1DjCLbCqs9m8tG9yPbSpfGsirnOtD1I3vSvssP7Pec44ZKBo12uM 2CoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=22bgXJnLEhnlsELlqsWujITyqI4qjnm4X4yUS5DO40M=; b=qDQIG/Q+aOYiCH58vrzlBMvd3bT/tejYVDNw7ZfPcZDxjQoyp3vMl33pgXYQiZa3Mm VdXtZFVj7+6Ca+8sAq5hRHISr4RZL1RNwCoo6JxCYLTHHw2tUMDKp5Kic45Um2UQQ512 rjgHl0Qk3bEW2EdGSjkCUXflWbgqJCMLlN9wgsW8mMkqFg+WDJmvA+b4PcBeMSaG5lrZ qbuZfdpnQ5gZN9gv+NxT2J+6m2OiyvVNxSH0RVCUBEYH3M1ti1mR8+XD+PRaacoc88vy Be3WmAY0UkGbiRjKF3TQQrqcubq9X3Hm2fjmGbGNGmQQJhdiPLmS4shB3Kdj+NsqSGSC I49A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nexb-com.20150623.gappssmtp.com header.s=20150623 header.b=boiFE4F0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f8-v6si4307308plo.813.2018.02.24.17.41.34; Sat, 24 Feb 2018 17:42:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nexb-com.20150623.gappssmtp.com header.s=20150623 header.b=boiFE4F0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751605AbeBYBjl (ORCPT + 99 others); Sat, 24 Feb 2018 20:39:41 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:55179 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751558AbeBYBjj (ORCPT ); Sat, 24 Feb 2018 20:39:39 -0500 Received: by mail-wm0-f66.google.com with SMTP id z81so11234382wmb.4 for ; Sat, 24 Feb 2018 17:39:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=22bgXJnLEhnlsELlqsWujITyqI4qjnm4X4yUS5DO40M=; b=boiFE4F09d1qxHDKbPAEt8ySVhtcwi+l6Zc94+iUoW3/WPBdK1JT+Mt9Mp6plh1pLa if8v+trgJBdSxYppBwAx1pCnaghDrwbf/w4U+LkLIcChbg++hzoU/QETVc+WyuKJQByN WONduddNcLlYxgbPOK0bFhJOq8CWcgrd4CX0Y+gwex2L8+8fjWTR3xUSYNP0XSvaTNIm wGQS+BToAEEw3ikzOCvjXX+qCgRKf6TPTQGt0iayQ+ytvLQLV8VuvxCws3LRVosxjG/f Ed9uRgdgPAsBGrBAVAsYLNO7jBB/MuOpr5Unl9Q1nW06947yQ70lC/Q/yPqUoYLZ7JT2 Z54Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=22bgXJnLEhnlsELlqsWujITyqI4qjnm4X4yUS5DO40M=; b=pPU7Fsikd/04/DXe00RTmoaWSHthmQUVwLoNykuZbopK8W3GH7uQ4+ttlOKXkYLK1O iQ3Nw/AyNnSp5AAxfVpzDPaHEQS7eYNmsGRTReIZBVm/etk9F6bbLTg/6gH0l1egUszX JX88f7hKfWbo4Tymwjgz7dj3mdyr3PtkjbyIc9AulmRJdIwOjLLfDNiYEVdGHtd7gsPw /utE8gZMggbuAYtRx0R34PQ3Qw+pT1S1OqiA5ubSxPBB4B+HS8wBJ18feO3R+CVe++SD gSsEIDGdcCFCWbOYIV1C3ACcYCRuW1QtnIwCBsLtyNAgISoE2PcyLpO9jaGmY9w7FXrE h3lQ== X-Gm-Message-State: APf1xPCLcgYP9u9yFyWBDkoSYt/zrKxqqSZtOUQ1rbBR+lKKHBCo/MpQ Woh9s5vKqBsTUgnT+3QIGyvP08kD5ksp0yetdqAbzg== X-Received: by 10.28.235.4 with SMTP id j4mr5412012wmh.52.1519522778272; Sat, 24 Feb 2018 17:39:38 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.195.139 with HTTP; Sat, 24 Feb 2018 17:38:57 -0800 (PST) In-Reply-To: <1519421630-12025-2-git-send-email-joe.lawrence@redhat.com> References: <1519421630-12025-1-git-send-email-joe.lawrence@redhat.com> <1519421630-12025-2-git-send-email-joe.lawrence@redhat.com> From: Philippe Ombredanne Date: Sat, 24 Feb 2018 17:38:57 -0800 Message-ID: Subject: Re: [PATCH v0 1/3] livepatch: add sample cumulative patch To: Joe Lawrence Cc: live-patching@vger.kernel.org, LKML , Josh Poimboeuf , Jessica Yu , Jiri Kosina , Miroslav Benes , Petr Mladek , Jason Baron , Evgenii Shatokhin Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joe, On Fri, Feb 23, 2018 at 1:33 PM, Joe Lawrence wrote: > Add a simple atomic replace / cumulative livepatch example. > > Signed-off-by: Joe Lawrence > --- > samples/livepatch/Makefile | 1 + > samples/livepatch/livepatch-cumulative.c | 216 +++++++++++++++++++++++++++++++ > 2 files changed, 217 insertions(+) > create mode 100644 samples/livepatch/livepatch-cumulative.c > > diff --git a/samples/livepatch/Makefile b/samples/livepatch/Makefile > index 2472ce39a18d..dd0e2a8af1af 100644 > --- a/samples/livepatch/Makefile > +++ b/samples/livepatch/Makefile > @@ -5,3 +5,4 @@ obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-shadow-fix2.o > obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-demo.o > obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-mod.o > obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-busymod.o > +obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-cumulative.o > diff --git a/samples/livepatch/livepatch-cumulative.c b/samples/livepatch/livepatch-cumulative.c > new file mode 100644 > index 000000000000..ab036439e08c > --- /dev/null > +++ b/samples/livepatch/livepatch-cumulative.c > @@ -0,0 +1,216 @@ > +/* > + * Copyright (C) 2018 Joe Lawrence > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License > + * as published by the Free Software Foundation; either version 2 > + * of the License, or (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, see . > + */ May be you could use the new SPDX tags instead of this fine but long legalese? [1] This would replace ~12 lines of comment by a single line with the same effect. Thanks! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Philippe