Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3] drivers/virt: vm_gen_counter: initial driver
 implementation
To:     Or Idgar <idgar@virtualoco.com>, linux-kernel@vger.kernel.org,
        arnd@arndb.de, gregkh@linuxfoundation.org
Cc:     oidgar@redhat.com, ghammer@redhat.com, Or Idgar <oridgar@gmail.com>
References: <20180225155525.25436-1-idgar@virtualoco.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <ae751fe8-c21e-3569-e71c-5a25ee5f1632@infradead.org>
Date:   Sun, 25 Feb 2018 13:07:11 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180225155525.25436-1-idgar@virtualoco.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 02/25/2018 07:55 AM, Or Idgar wrote:
> From: Or Idgar <oridgar@gmail.com>
> 
> This patch is a driver which expose the Virtual Machine Generation ID
> via sysfs. The ID is a UUID value used to differentiate between virtual
> machines.
> 
> The VM-Generation ID is a feature defined by Microsoft (paper:
> http://go.microsoft.com/fwlink/?LinkId=260709) and supported by multiple
> hypervisor vendors.
> 
> Signed-off-by: Or Idgar <oridgar@gmail.com>
> ---
> 
> Changes in v3 from v1 (v2 lack of patch changelog):
> - replaced GPL2 section with SPDX line.
> - including linux/kobject.h for hypervisor_kobj.
> - using acpi_os_map_memory instead acpi_os_map_iomem.
> 
>  Documentation/ABI/testing/sysfs-hypervisor |  13 +++
>  drivers/misc/Kconfig                       |   6 ++
>  drivers/misc/Makefile                      |   1 +
>  drivers/misc/vmgenid.c                     | 140 +++++++++++++++++++++++++++++
>  4 files changed, 160 insertions(+)
>  create mode 100644 Documentation/ABI/testing/sysfs-hypervisor
>  create mode 100644 drivers/misc/vmgenid.c

$Subject says drivers/virt/. Please choose one.

> diff --git a/drivers/misc/vmgenid.c b/drivers/misc/vmgenid.c
> new file mode 100644
> index 000000000000..6b7ec9bd45e8
> --- /dev/null
> +++ b/drivers/misc/vmgenid.c
> @@ -0,0 +1,140 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Virtual Machine Generation ID driver
> + *
> + * Copyright (C) 2018 Red Hat, Inc. All rights reserved.
> + *	Authors:
> + *	  Or Idgar <oridgar@gmail.com>
> + *	  Gal Hammer <ghammer@redhat.com>
> + *
> + */
> +#include <linux/init.h>
> +#include <linux/module.h>
> +#include <linux/kernel.h>
> +#include <linux/kobject.h>
> +#include <linux/acpi.h>
> +#include <linux/uuid.h>
> +
> +MODULE_LICENSE("GPL");
> +MODULE_AUTHOR("Or Idgar <oridgar@gmail.com>");
> +MODULE_AUTHOR("Gal Hammer <ghammer@redhat.com>");
> +MODULE_DESCRIPTION("Virtual Machine Generation ID");
> +MODULE_VERSION("0.1");
> +
> +ACPI_MODULE_NAME("vmgenid");
> +
> +static u64 phy_addr;

Minor nit:
I would prefer phys_addr since we also have PHY devices that have a phy addr.

thanks,
-- 
~Randy