Received: by 10.223.185.116 with SMTP id b49csp3089671wrg; Sun, 25 Feb 2018 13:37:34 -0800 (PST) X-Google-Smtp-Source: AH8x226e+TYxgAK+/9uGfKDBb2kKFS9IHgK3xUONaTEw2x6NVjLeLsgO527GokwWU10vgja/TKxD X-Received: by 2002:a17:902:850a:: with SMTP id bj10-v6mr8651285plb.5.1519594654180; Sun, 25 Feb 2018 13:37:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519594654; cv=none; d=google.com; s=arc-20160816; b=X0leNZxlck6PaExNY4fck5n6NADgBuL+9z0/vuMZlF8M2Px8L1GXA5e+/V+Bc0yB+g X1VwC201XeizQkycIBHcLCVPKKFHDLeW0A8B54v9OkgTOT2K+GSKVACdODH1cBW1F6gf DrMsbY4Mi0RprGN4si5fcpk7QtacH22R7w/vyJspUy57rWK/CCcKf3PCRZy+PtUieef6 XSm1jXVRLs5wxh4TbTEzdIEEQjSBTnbA5sYetiV4JP7Dcm/91HaOPHPKx95U7RiYU94R XF/uVPwaFKDD7bFp/fbuc/R8jZTNSiDAMCfudE7Jtfc4I8FFbFpIfdEj6sALwfNEIJlf 86Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=tqj0w6swPT91737s3kjrrGKEe1GxVaGcYsa37oaS5gw=; b=CAlyXE2FrVfD1ejQHiy/IZ2xBEiL0HBl0ZJXDtDkVIVsSthAOgmTGpelkn2WAtzndR U+F1M2b9x2cw8i+Hww60oZHOuvU8TEinVXZxlu9nph5l00YZwSzXFsS0OE1XOnHmdGiX A47TzFocmXHxUXF0WYuEcqWtAyXtUF+2AO4jzhqL0pKidszibuWC3FWAwvNHX1MTYac7 nBtQGRmrhcVzWGafVKighM9DK6Tvk62d8v/eD8Qq6jj0Np6ZDM6AS6hnYURJh3NUfU7L XDm9GchO5806TIvdxRKlp97Wc3Fej4pXouCNEWjBrNvs0OUBlitL0X4I+W5yJOwa73Lu Ui+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d6-v6si5576865plo.661.2018.02.25.13.37.19; Sun, 25 Feb 2018 13:37:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751982AbeBYVdv (ORCPT + 99 others); Sun, 25 Feb 2018 16:33:51 -0500 Received: from g9t5009.houston.hpe.com ([15.241.48.73]:37194 "EHLO g9t5009.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751760AbeBYVdj (ORCPT ); Sun, 25 Feb 2018 16:33:39 -0500 Received: from g4t3433.houston.hpecorp.net (g4t3433.houston.hpecorp.net [16.208.49.245]) by g9t5009.houston.hpe.com (Postfix) with ESMTP id B278755; Sun, 25 Feb 2018 21:33:38 +0000 (UTC) Received: from anatevka.ftc.rdlabs.hpecorp.net (anatevka.americas.hpqcorp.net [10.34.81.6]) by g4t3433.houston.hpecorp.net (Postfix) with ESMTP id 239734A; Sun, 25 Feb 2018 21:33:37 +0000 (UTC) From: Jerry Hoemann To: wim@linux-watchdog.org, linux@roeck-us.net Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, rwright@hpe.com, maurice.a.saldivar@hpe.com, mingo@kernel.org, marcus.folkesson@gmail.com, Jerry Hoemann Subject: [PATCH v4 00/10] watchdog/hpwdt: Update driver to use watchdog core. Date: Sun, 25 Feb 2018 14:32:49 -0700 Message-Id: <20180225213259.2861-1-jerry.hoemann@hpe.com> X-Mailer: git-send-email 2.13.6 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org == v4 == Modifications from prior version: Manual merging and patch reordering has caused minor white space and diff changes. Such change shouldn't have effected the logic and are omitted below: Patch 001 Remove legacy NMI sourcing. 1) Updated patch documentation to reflect Spectre concerns. 2) Restored comment at #endif Patch 002 watchdog/hpwdt: remove include files no longer 1) Squashed onto Patch001. Patch 0003: watchdog/hpwdt: Update nmi_panic message. 1) Unchanged Patch 0004: watchdog/hpwdt: white space changes 1) Redacted. Patch 0005: watchdog/hpwdt: Update Module info. 1) Now Patch 0004 2) Update only module description to reflect branding changes. 3) Rest of patch redacted. Patch 0006 Select CORE 1) Merged with 0007 Patch 0007 Modify to use watchdog core 1) squashed on Patch 0006. 2) Now Patch 0005 3) Requested white space changes. 4) Use "wdd" for watchdog_device like other watchdog drivers do Patch 0008 Programable-Pretimeout 1) hpwdt_settimeout re-worked to take into account timeout <= pretimeout. Patterned after watchdog_set_timeout. 2) hpwdt_set_pretimeout re-worked to take into account requested pretimeout <= timeout. 3) Clarify patch doc to reflect above. Patch 0009 condition-early-return-of-NMI 1) Requested syntatic surgar. 2) Now Patch 0006 Patch 0010 remove-allow_kdump 1) Now Patch 0007 Patch 0011 Add-dynamic-debug 1) Now Patch 0009 2) Typo fix 3) New dev_dbg resulting from changes to set timeout and pretimeout. Patch 0012 Update driver version. 1) Now Patch 0010 New Patch 1) Patch 0001 Update Copyright == v3 == Incorperating code review feedback. 1) Patch 0003: Use existing hex_byte_pack instead of creating new function. 2) Patch 0005: Redacted change in module_param permission. 3) Patch 0006: switch from pr_debug etc., to dev_dbg where possible. 4) Patch 0006: No longer updating soft_margin post module load. 5) Patch 0006: Initialize hpwdt_dev.parent before registering watchdog. 6) Patch 0006: Redacted change to dev_info message w.r.t. allow_kdump 7) Patch 0006 & 0007: Reorder patches to maintain bisectability. 8) Patch 0008: Change pr_debug to dev_dbg 9) Patch 0010: Change dev_info message w.r.t. allow_kdump where feature is removed. Note, I am explicitly ignoring the checkpatch error on Patch 0008 for specifying permisson of "0" instead of "0000". == v2 == 1) Fix compiler error when CONFIG_HPWDT_NMI_DECODING is not defined. 2) Break out driver version change to its own patch (0011). == v1 == The primary purposes of this patch set are to 1) Update the hpwdt driver to use the watchdog core. 2) Reduce complexity by removing unnecessary features. 3) Add customer requested features like optional pretimeout. 4) Enhance readability/maintainability of the driver. The size of the resultant driver is reduced from over 900 lines to 350 lines. Patch 1& 2 remove legacy NMI sourcing. Patch 3 adds useful indication of NMI cause to panic message Patch 4 & 5 are general cleanup Patch 6 & 7 updates the driver to user the watchdog core. Patch 8 makes the pretimeout NMI programmable. Patch 9 modifies whether the NMI handler claims the NMI. Patch 10 retracts the allow_kdump module parameter. Jerry Hoemann (10): watchdog/hpwdt: Update copyright. watchdog/hpwdt: Remove legacy NMI sourcing. watchdog/hpwdt: Update nmi_panic message. watchdog/hpwdt: Update Module info. watchdog/hpwdt: Modify to use watchdog core. watchdog/hpwdt: condition early return of NMI handler on iLO5 watchdog/hpwdt: remove allow_kdump module parameter. watchdog/hpwdt: Programable Pretimeout NMI watchdog/hpwdt: Add dynamic debug watchdog/hpwdt: Update driver version. drivers/watchdog/Kconfig | 1 + drivers/watchdog/hpwdt.c | 789 +++++++---------------------------------------- 2 files changed, 121 insertions(+), 669 deletions(-) -- 2.13.6