Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 2/2] x86/apic: Replace common tools with new ones
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
CC:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        <x86@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@kernel.org>, <ebiederm@xmission.com>,
        Baoquan He <bhe@redhat.com>
References: <20180223075430.12395-1-douly.fnst@cn.fujitsu.com>
 <20180223075430.12395-2-douly.fnst@cn.fujitsu.com>
 <CAHp75Vf8ChDopMygXPj05+hivUtymt+i=WDOVKrB=dPt7Sp1Pw@mail.gmail.com>
From:   Dou Liyang <douly.fnst@cn.fujitsu.com>
Message-ID: <6bd94039-966d-6212-2afe-92f601d87421@cn.fujitsu.com>
Date:   Mon, 26 Feb 2018 08:51:45 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <CAHp75Vf8ChDopMygXPj05+hivUtymt+i=WDOVKrB=dPt7Sp1Pw@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Andy,

At 02/23/2018 08:40 PM, Andy Shevchenko wrote:
> On Fri, Feb 23, 2018 at 9:54 AM, Dou Liyang <douly.fnst@cn.fujitsu.com> wrote:
>> The pending interrupt check code is old, update the following code.
>>
>>    -Replace for() with for_each_set_bit()
> 
>> -                       for (j = 31; j >= 0; j--) {
>> -                               if (value & (1<<j)) {
>> +                       for_each_set_bit(j, &value, 32) {
> 
> for_each_set_bit(), mind 'set' part, is equivalent to for-if pair...
> 
>> +                               if (j) {
> 
> ...here you just exclude bit 0 from consideration by unknown reason.
> 

Oops! my fault, will modify it.

Thanks,
	dou

>>                                          ack_APIC_irq();
>>                                          acked++;
>>                                  }
>>                          }
>