Received: by 10.223.185.116 with SMTP id b49csp3301076wrg; Sun, 25 Feb 2018 19:24:16 -0800 (PST) X-Google-Smtp-Source: AH8x225u0YsT+jNTj4IQgfmovuj8JWY4eij8JK8XOPlimQC3icEpJIpm86Ud46zv42q/Xc+hVHl/ X-Received: by 2002:a17:902:8ec6:: with SMTP id x6-v6mr9372624plo.402.1519615456214; Sun, 25 Feb 2018 19:24:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519615456; cv=none; d=google.com; s=arc-20160816; b=WckV30ifbVikOUtzXDYGrDK4jBN01DjQ26uIwi15LbAB93KJ2mvUatns9c/av5P7LO j6oEn3abGgBi2M9dGL4j7hU0QOTfj7rDdv8MkJx3DTEMfEp+7dCN9Y3unPm2QkJipCBP 1XzIAzpgExJz81iSD0ouSky84BHSdUp7lJg2WWpVI9gDhWl78KucBs71QbWY8mZg+FbB gVx0mZtzCNb9+6P27aYTWGuzYUc2Y9zNWvkQEkmCFpqFQfSl0mW02AFUWKeMGcMCc8w2 r8A4RYrHGGlTefOXt6kpYHnbhKzuesn2lmBBVaTlJ/RaIpSWyZ4tTEegafbJBpaljf1L DHhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=zaiWosH+tzGiQUO9c0X1dbdlehbB0tU49JNrZGbmUHU=; b=ZrafRelNEOzmY9iCGfCt8+90sO84re/2Nr0H0Z1BbqJhpcFKGTayK9BpCC+2akZD22 0aJUs/rMbwgu/2d5piMUiD/SXdkaMDrDF7DMb5KJxNYSanyP5PfM5yKdyZc4rA/o+A4D O2V7fOOiTiZbHUlIFRj/tJOepygfvskol16yS4yUAQphQy4Pz5cjyINBc063q7eyvhwm C2sFOOe+6icbpdENlWR1BjsxRdq1gO4pW5YJgn8Dl6fjqbuUnbOkH6WB8NtWn9Hu/FR/ Eq7c4en5jQCaEZRx+ed1K3iDTmn7d8ZrMbUz4thKxlEQFUJ+18XsL+Ne29WZiuWaTEic 1Q0g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l8-v6si6088059pln.153.2018.02.25.19.24.01; Sun, 25 Feb 2018 19:24:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752184AbeBZDWi (ORCPT + 99 others); Sun, 25 Feb 2018 22:22:38 -0500 Received: from g4t3426.houston.hpe.com ([15.241.140.75]:40468 "EHLO g4t3426.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752094AbeBZDWd (ORCPT ); Sun, 25 Feb 2018 22:22:33 -0500 Received: from g9t2301.houston.hpecorp.net (g9t2301.houston.hpecorp.net [16.220.97.129]) by g4t3426.houston.hpe.com (Postfix) with ESMTP id 2F5154F; Mon, 26 Feb 2018 03:22:33 +0000 (UTC) Received: from anatevka.ftc.rdlabs.hpecorp.net (anatevka.americas.hpqcorp.net [10.34.81.6]) by g9t2301.houston.hpecorp.net (Postfix) with ESMTP id AE16653; Mon, 26 Feb 2018 03:22:32 +0000 (UTC) From: Jerry Hoemann To: wim@linux-watchdog.org, linux@roeck-us.net Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, rwright@hpe.com, maurice.a.saldivar@hpe.com, mingo@kernel.org, marcus.folkesson@gmail.com, Jerry Hoemann Subject: [PATCH v5 3/9] watchdog/hpwdt: Update nmi_panic message. Date: Sun, 25 Feb 2018 20:22:21 -0700 Message-Id: <20180226032227.14615-4-jerry.hoemann@hpe.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180226032227.14615-1-jerry.hoemann@hpe.com> References: <20180226032227.14615-1-jerry.hoemann@hpe.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Include the nmistat in the nmi_panic message to give support an indication why the NMI was called (e.g. a timeout or generate nmi button.) Signed-off-by: Jerry Hoemann --- drivers/watchdog/hpwdt.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c index 1d20bc6d2c44..44c3038cc531 100644 --- a/drivers/watchdog/hpwdt.c +++ b/drivers/watchdog/hpwdt.c @@ -113,19 +113,23 @@ static int hpwdt_my_nmi(void) */ static int hpwdt_pretimeout(unsigned int ulReason, struct pt_regs *regs) { - if ((ulReason == NMI_UNKNOWN) && !hpwdt_my_nmi()) + unsigned int mynmi = hpwdt_my_nmi(); + static char panic_msg[] = + "00: An NMI occurred. Depending on your system the reason " + "for the NMI is logged in any one of the following resources:\n" + "1. Integrated Management Log (IML)\n" + "2. OA Syslog\n" + "3. OA Forward Progress Log\n" + "4. iLO Event Log"; + + if ((ulReason == NMI_UNKNOWN) && mynmi) return NMI_DONE; if (allow_kdump) hpwdt_stop(); - nmi_panic(regs, "An NMI occurred. Depending on your system the reason " - "for the NMI is logged in any one of the following " - "resources:\n" - "1. Integrated Management Log (IML)\n" - "2. OA Syslog\n" - "3. OA Forward Progress Log\n" - "4. iLO Event Log"); + hex_byte_pack(panic_msg, mynmi); + nmi_panic(regs, panic_msg); return NMI_HANDLED; } -- 2.13.6