Received: by 10.223.185.116 with SMTP id b49csp3468575wrg; Sun, 25 Feb 2018 23:57:36 -0800 (PST) X-Google-Smtp-Source: AH8x224zClYzD4kybXGviU24FVy2c0MsC6lPBBMPqZrOoxB+uK/wTpGE44ww0IR7i5oDjhgyBYmL X-Received: by 2002:a17:902:74c3:: with SMTP id f3-v6mr9852335plt.444.1519631856288; Sun, 25 Feb 2018 23:57:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519631856; cv=none; d=google.com; s=arc-20160816; b=K0/eWivijZNO135uh8D7p5e/U8J3quwGlP1ulsiVokfGkPXF7CDjwCgE7ei80bVQbQ Ymh3q9hroPCeJIhJ63o/9OYTNQ+2ErL1Hf9FW/JLaL+CeIn31MIb06ZUONx+hxFo/Xxz TavL+P14w3ivS9sDl/m4HGtQvNUb82/orcmX4rx8EptCT/+bw4IB7AfXGEjp9tQlVxNs sWM38uaca9mitIe4u2xIO2gpleFD89ZsCJRmztXN1yvtKLbMw3VaYYtpdW7eJGkodEPr RGGwLqTYEDLrkrnMD4x48MY0gp4wGV5wSuzNSBYzZFMXwjI3aHfhnA987s9LAC1Emv+u taGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=JMvXvu21T208T6ijjbPV6SUz9WCw/K4SR9BmcWuHt+4=; b=NAy0ptgbeeZm4l2uNdaCMOHdw6Jk/VqBwf+sk8TeRQTKo2lGnoHcJN9RF+HKonDr3y iF5YZDBcuo+h8L4ZZyA+myvkZSD1/kckGu/jx66n5o2muyZqHkUo4rle+OtEdNM/7He0 1slheqM5CBErbRBk/dKsCO70/K+KitRh1xFMsXCMQJ78rSjy2UDNd0lkdTg/YYr6xq80 HNtEnwSfwOdWzOZPm15UFt0dsMQvlWWqF3WUMUln+yFfwd3Zm+sMfjub7nDZYK3MSM/u WsgQYOk0HY/OjR/GmCS8KN8BGm6MIf7Q7VUR7IFDNYfBbUlvfvmANa9septPdxXAnxxU najw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=GxYHlKSh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u62si5236953pgd.579.2018.02.25.23.57.20; Sun, 25 Feb 2018 23:57:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=GxYHlKSh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752118AbeBZH4m (ORCPT + 99 others); Mon, 26 Feb 2018 02:56:42 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:52224 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751153AbeBZH4l (ORCPT ); Mon, 26 Feb 2018 02:56:41 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w1Q7u8XJ081991; Mon, 26 Feb 2018 07:56:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2017-10-26; bh=JMvXvu21T208T6ijjbPV6SUz9WCw/K4SR9BmcWuHt+4=; b=GxYHlKShk7uwCgyu0Kfx5QJN/05wHzt1b2juO6o1iJ/mHq2B4T1v/yGnLeDSvsXCc6Sf lct714jVYxYfCtGytyxbgiGUkafXBJBjS3po3fWP2wWWofXJ/znJ2SricF9A59RZtr4b fQD7R64hVDoss5+/yok+BEFoSmqRkavt50L2Y/dChY3sMa8lA0AUtPH3zyH/K1dKh1bn fZid8paCPCjMDDyqKYn2oqUzTAz7t+hzpWQSR9ScHXL6f4rMdFZPQjMbSUWrYz++lm9j mHZfcZoxEFXG5wqVkOJtJ25qFTN2oFVzrZ7g9AuZ1MbYkoTZ5id2EGADIMSie2qX5Vvn Jw== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2130.oracle.com with ESMTP id 2gce47g0y7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 26 Feb 2018 07:56:35 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w1Q7uZVw003884 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 26 Feb 2018 07:56:35 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w1Q7uY2k016217; Mon, 26 Feb 2018 07:56:34 GMT Received: from mwanda (/197.254.35.146) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 25 Feb 2018 23:56:33 -0800 Date: Mon, 26 Feb 2018 10:56:25 +0300 From: Dan Carpenter To: Ivan Safonov Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Hans de Goede , Janani Sankara Babu , linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging:r8188eu: use lib80211 CCMP decrypt Message-ID: <20180226075625.kcksm35y4clqvi5l@mwanda> References: <20180223145742.25783-1-insafonov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180223145742.25783-1-insafonov@gmail.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8815 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=620 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1802260107 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 23, 2018 at 05:57:42PM +0300, Ivan Safonov wrote: > Custom AES decrypt implementation replaced with lib80211 library. > > Signed-off-by: Ivan Safonov The new code looks like original RTL code (really bad) so I'm guessing you copy and pasted the code from somewhere else? The idea is good, but RTL code is painful to look at. regards, dan carpenter