Received: by 10.223.185.116 with SMTP id b49csp3481668wrg; Mon, 26 Feb 2018 00:14:31 -0800 (PST) X-Google-Smtp-Source: AH8x227WZpuHNEWMTdFFB7NTWy0K7AsHyyEe5gDgMoF6o3qOF7KGiAcclBlmH4jFjJgVUWD0t7MZ X-Received: by 2002:a17:902:9a04:: with SMTP id v4-v6mr9680991plp.252.1519632871196; Mon, 26 Feb 2018 00:14:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519632871; cv=none; d=google.com; s=arc-20160816; b=Xf0ZDhuug5mGXXH+EJhfQcQkLB875xZNUOBXJjVKF/xV5AC53IF1C60q6cfr1MCrli DXYXQVnsFrRRSM9CskR9vDOND34qtpoxi955ITpEJVGQkpuwGVcm4wItj7ahcmkiicUW WF/CwUTAJkuOn4AM1zHZmq0K4Ai/l+97jd7mUzdm9a7MxdSA0+h5+jXrcnELwbU/PLVZ BHOZXXAklaeyVPAjGUupR8AdOgBYhiINYh/VV7xnWDpznXy7wiPb8vADyleEWodXfjin Xr5WfNVpoxAXPZMsxOAtYh1DLyIzr5H3zMMfR0BhK/Rub0SlOOtAUxFVlLg1Z+/ETjQ6 nO4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=xtIEpqS+WVEhoaiRO6/rEllXwjywXivNQbfyBNKqqmc=; b=e3sfqJTrGg0RCabeAo/rlySg91D3vc7ocz/cM829Gq2I3jJtgsJaKewk0DBaloh4nX Vc0K3HbAALsbIWNf2EZJ5NzO2Y4Cltx2vbMhLrDkSnSC9A0IIT4mUnRV6byJLwhm788E zE4tFDDDCVxTMtOWkkI74B3+yz0us42jgFwLpXibCZbvtn0t+RS7SvJdqkkGrl5vSpaI N5FG5Xvku4mCkL+BhK4b0Z9blQ3n+0SsRpQBJRcXw4ZNCQglu2sLGhYrEj00v1uTCMMQ pbEGv7g20Y07cywbcPzPVMpo1hVTaNEMgPw3A9ZcQqhXcrgZ+tl7DgP6fn5VyATbODKz ZAAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=EVpGljNv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y10si2404813pge.31.2018.02.26.00.14.16; Mon, 26 Feb 2018 00:14:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=EVpGljNv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752198AbeBZIMS (ORCPT + 99 others); Mon, 26 Feb 2018 03:12:18 -0500 Received: from mail-pf0-f171.google.com ([209.85.192.171]:41449 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751310AbeBZIMP (ORCPT ); Mon, 26 Feb 2018 03:12:15 -0500 Received: by mail-pf0-f171.google.com with SMTP id f80so1111350pfa.8 for ; Mon, 26 Feb 2018 00:12:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xtIEpqS+WVEhoaiRO6/rEllXwjywXivNQbfyBNKqqmc=; b=EVpGljNvf4mMdAKcdTaoQv7CDsOD4PT2sWg6MA49sWTje5rMJIXjP9HAzzIJJtNThJ bJO6TzAvxQOYW9WWpxvUldKvE6reb5jliJiq/fisjo61jIN+fa+LoNoGxW28MNyqbzvA 4erxgDoqFXMks8KyxVnMUwnSxqO3x4jHd7YCuMcbGfYiuoGc7lTdAUzObuqOKIGNy3Wv hSczWE7wgjozh46FLeSch3mNerNCEBySoPmz6jgVzsY0ANQSmpKUnK2lzoazxx2IddiQ L7GIcid47WeP3GtsV390jOhhZ19BFlMrbpeqJLesXWb1KW3TjdPwJc5TvpldDLYjK50+ +S0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xtIEpqS+WVEhoaiRO6/rEllXwjywXivNQbfyBNKqqmc=; b=XqDElzdLUcNXN6li0uM8N0J+LPePPZ1seqZnZaOoexSPV45jMT0D0ytiY6/09YVFj+ jmbBSQc4RU51LOkxqSI2PpFQyEoPB7R/TBi/p1v4pVlSCBgz5JQ9H3cb2cOh2y23Y02g QeXA3jUxpFcPXYesiuYxIiYo3OZoBX3rOq9y+4JJVX0m2T87+bJNymFc7Pssv3TuLcGA 6OJ+fY+IT3eIHMjFTW/VypGfoSGuVraA2/dA/N9E2LE4sO8VgnB6n5dj4NN3TroiNT+l OKmkmFEN2RGY1Z+aCkdbpyQySQ/UOEX+RYlmBpDBZGIycXcTkI9ROjs+zZHN+UvxeCyg LSwg== X-Gm-Message-State: APf1xPBcFpda726AMSqwZfHRb2yfvV5UlMYzsw6e8Z55+M2qHY3jkWXL sYOCOwbXHYvRhm5ORADGrZ4= X-Received: by 10.99.2.140 with SMTP id 134mr7913829pgc.117.1519632734971; Mon, 26 Feb 2018 00:12:14 -0800 (PST) Received: from localhost ([175.223.19.102]) by smtp.gmail.com with ESMTPSA id a5sm11293852pfn.66.2018.02.26.00.12.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Feb 2018 00:12:13 -0800 (PST) Date: Mon, 26 Feb 2018 17:12:10 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , Mike Rapoport , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky Subject: Re: [PATCHv3 1/2] zsmalloc: introduce zs_huge_object() function Message-ID: <20180226081210.GF12539@jagdpanzerIV> References: <20180210082321.17798-1-sergey.senozhatsky@gmail.com> <20180214055747.8420-1-sergey.senozhatsky@gmail.com> <20180220012429.GA186771@rodete-desktop-imager.corp.google.com> <20180226054927.GA12539@jagdpanzerIV> <20180226055804.GD112402@rodete-desktop-imager.corp.google.com> <20180226065035.GD12539@jagdpanzerIV> <20180226074652.GB168047@rodete-desktop-imager.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180226074652.GB168047@rodete-desktop-imager.corp.google.com> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (02/26/18 16:46), Minchan Kim wrote: [..] > > hm, I think `huge_size' on it's own is a bit general and cryptic. > > zs_huge_object_size() or zs_huge_class_size()? > > I wanted to use more general word to hide zsmalloc internal but > I realized it's really impossible to hide them all. > If so, let's use zs_huge_class_size and then let's add big fat > comment what the API represents in there. Will do. Thanks! -ss